Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125407
Precedence: bulk
MIME-Version: 1.0 (Mimestream 1.3.8)
Date: Tue, 3 Sep 2024 07:24:55 -0400
Message-ID: <CAGKNXQG32aF58gPnf1ywbmde72F_Wwjib0oXhN_ve6336RnQXg@mail.gmail.com>
Subject: [PHP-DEV] RFC: Deprecate json_encode() on classes marked as non-serializable
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009d5e3c0621354ee6"
From: phofstetter@sensational.ch (Philip Hofstetter)

--0000000000009d5e3c0621354ee6
Content-Type: text/plain; charset="UTF-8"

Hello,

As per my previous email to the list, I have now created the official RFC
to deprecate calling json_serialize() on instances of classes marked with
ZEND_ACC_NOT_SERIALIZABLE.

https://wiki.php.net/rfc/deprecate-json_encode-nonserializable

I have also created a PR with the implementation here:

https://github.com/php/php-src/pull/15724

I have considered other options, both constraining the implementation to
just Generator and/or to add special cases for Generator (and maybe
Iterator), but they either continue to keep the asymmetry between
serialize() and json_encode() and/or are making things even more
inconsistent.

Please tell me what you think, especially, if you agree that
blanked-deprecating all of ZEND_ACC_NOT_SERIALIZABLE classes is acceptable
BC-wise (after a bit of deliberation over the weekend, I think it is and
most json-serializations of such marked classes are probably unintentional).

Thanks in advance for all comments

Philip

--0000000000009d5e3c0621354ee6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<html><body><div dir=3D"ltr">Hello,<div><br><div class=3D"gmail_signature" =
data-smartmail=3D"gmail_signature"><div dir=3D"ltr">As per my previous emai=
l to the list, I have now created the official RFC to deprecate calling jso=
n_serialize() on instances of classes marked with ZEND_ACC_NOT_SERIALIZABLE=
.</div><div dir=3D"ltr"><br></div><div dir=3D"ltr"><a href=3D"https://wiki.=
php.net/rfc/deprecate-json_encode-nonserializable">https://wiki.php.net/rfc=
/deprecate-json_encode-nonserializable</a><br></div><div dir=3D"ltr"><br></=
div><div dir=3D"ltr">I have also created a PR with the implementation here:=
</div><div dir=3D"ltr"><br></div><div dir=3D"ltr"><a href=3D"https://github=
.com/php/php-src/pull/15724">https://github.com/php/php-src/pull/15724</a><=
br></div><div dir=3D"ltr"><br></div><div dir=3D"ltr">I have considered othe=
r options, both constraining the implementation to just Generator and/or to=
 add special cases for Generator (and maybe Iterator), but they either cont=
inue to keep the asymmetry between serialize() and json_encode() and/or are=
 making things even more inconsistent.</div><div dir=3D"ltr"><br></div><div=
 dir=3D"ltr">Please tell me what you think, especially, if you agree that b=
lanked-deprecating all of ZEND_ACC_NOT_SERIALIZABLE classes is acceptable B=
C-wise (after a bit of deliberation over the weekend, I think it is and mos=
t json-serializations of such marked classes are probably unintentional).</=
div><div dir=3D"ltr"><br></div><div dir=3D"ltr">Thanks in advance for all c=
omments</div><div dir=3D"ltr"><br></div><div dir=3D"ltr">Philip</div><div d=
ir=3D"ltr"><br></div><div dir=3D"ltr"><br></div></div></div></div></body></=
html>

--0000000000009d5e3c0621354ee6--