Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125401
Content-Type: multipart/alternative;
 boundary="------------dlGS03OvgvLJ52xg7WQN0mAs"
Message-ID:
 <AM8P250MB0170B3DDB767BBB7587652BEE2932@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
Date: Tue, 3 Sep 2024 02:36:11 +0200
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Debug Build Container Image for GitHub Packages
To: Ben Ramsey <ramsey@php.net>
Cc: internals@lists.php.net
References: <CABTDVhAxc7VDcQt_aM=YP+ZZiBeMv5_sQ6Nk6FALGKUP=6JHhw@mail.gmail.com>
 <5C7B4216-6D52-4BF0-9C30-89DD5465FB48@php.net>
 <AM8P250MB0170C190694AE15A863DBF1DE2922@AM8P250MB0170.EURP250.PROD.OUTLOOK.COM>
 <8D35CEB1-3B48-4889-BEAB-63AAE6DB8A01@php.net>
Content-Language: en-US
In-Reply-To: <8D35CEB1-3B48-4889-BEAB-63AAE6DB8A01@php.net>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: AM8P250MB0170:EE_|AM8P250MB0199:EE_
X-MS-Office365-Filtering-Correlation-Id: 5587c10b-d50f-4c7b-f391-08dccbb06912
X-Microsoft-Antispam:
	BCL:0;ARA:14566002|12050799009|461199028|19110799003|8060799006|5072599009|15080799006|440099028|3412199025;
X-Microsoft-Antispam-Message-Info:
	RenEhp1iz2AohEPQiSdwdk0endW0IFvPHIVa5lMOzqpSTS7Tx7jE1GjyEvhTtqMNuKEUCWU3buL2BF2+oD9Vjw1Ib3QEpAh828blw8ZVJNIfOzLFxHo5I8P+eKr1nUjpSbMrqFnuvmxEaAnBg0yR47+CDzsaLnq2Q/cLqHYOfMgv3txrkn28Jdb3oIoXjjR9EzMsW1lGKXs3IqsED2VCSD8WWXSzi/c89zozFMeRwRCd2KobkRzX8RVFoELM84xDlVtH2nQgrsyIKknWe9JrsCh6+KiGRbrSN4mLlIe72zjG39FB5r131aE7pM6pZflO+UPgSzBlEr7Ff3x1fyVc8V0M4wsWgnX668dywVESgujUshLzONBt++3YPBQHSFAfJIsPOVPdyhdSnXljm1tYL6ruLY0J43lhjFqXb02R2Vl8HmP1B0pgT/nyvhpqnhGZBP3ylJEgh+i0KvMW6orE4ZAfNB8dze+VnfGz6bkCXQFt6goTMLk4uMg+ptn0FVqlBeZ6a1brZXY+5y0yOK0LqUoWDJ/HQA/MPKlc8NzTc1ePFB9FtYiJVvsgLxbFRn7mG2u9SzV45Iy6Sk3kvOAyhIbEpIYqpaaGr1txf6iVJ/BIcdxRl0oT/hsx1q7RMUOBWgV0dEehJJzrftesbwn0PvpB80GMn0W4bDmEjd5Qk1nx95QDkNq7XYdgUruavyBP6tDhnS8WPsAHH7TFiE6fVNDuRgA6bXqm/0lW2FPjRfw9NKWAF0UbIDknBSOedWzK
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?UG5iSjlCR3BpOGNPNk5iSTRaakloT0pCWTJ3c0UxQ3RjUE5raGtWOEJkVVRh?=
 =?utf-8?B?R2crVkxNUU1UTWcxZzZoeEpPbkwrM2pZNEt4OHNoM3RHaUNsZ0I2d1pOamhl?=
 =?utf-8?B?TVlTOUIzVW5VTU9iNHNjTFNxUnZFNFVCVC9yKzlhbU9DVXh0ZldneXZsSlhH?=
 =?utf-8?B?clFBZkF2MmFzVnpGODdYcWFWSEp4bU84bGd0QmluaGZKWW9FWk1kOE5zS1Jx?=
 =?utf-8?B?RTh6aWR3MVZSTytDNlQxclhIay95eUxGN3JybVdyYTJkNHNwaDNzOEtxRWZY?=
 =?utf-8?B?V0tib090cWVjK2szM0dTSjlMMWpLanJOMXIxZng0MjhvMkhhRWxPOXo2QWZK?=
 =?utf-8?B?UXEzWU5CR00xMHlPVXhuVi9ia0J4dVBqYVV3Vzg5ZmZ5dlUxWWtqOVVBVFNw?=
 =?utf-8?B?aHNobXdDZUxYQkp4S3BnM0tnUWRDbUxYQzJoaEhNWHAwNnhISlN2TTZjdlgw?=
 =?utf-8?B?RHJuNHc3QzNXMy8ySUhYb0Z3MkZWMml6VXVFbUdOR3VwdURsTXpnMlc2M1Nn?=
 =?utf-8?B?NlFZbjdrYUZpSEM1VTN3NGMyVTQxdEsvNlVrbXB1L1hrVlV0dWZmRThOQ3hF?=
 =?utf-8?B?ZU4wUVRjTVNqdzEvdGdOZ09kaUVyU0J5WFRaWk53N3hVZmVJN3RMb1ltYVFN?=
 =?utf-8?B?VVk4WkhnTFFGVGlYbUYvRk5BZTN3RFZBVmRhUVZXemxqdkJrK1Rxejc0SUZ0?=
 =?utf-8?B?REc4OW5mdE5HUXlDai9mMDNRNGJRZDhzMWZMc01yWnkxMDlsR01nMVh4WU5h?=
 =?utf-8?B?U3lhVHg5ZFNNVmhUOG9EbjBmeEsrVlNoekV4UW1zT0ZpMS9oV3BZbXBHOUNr?=
 =?utf-8?B?UVUydnpLbEFTUXd2Z3BkZk9DWldSU2g3ZGM1UDBlb0F3MnRVYnVxZEoxenVG?=
 =?utf-8?B?TUZFblFWTURMcmxIWEtCVisrVWoxVzhyc0tNNTN6TXJDeHdCY2RJSXNJc0h3?=
 =?utf-8?B?YzgzZmMzRUtua3dzbmUrbU9ubWsyUWdLL2tVL0tqSzFmQjkzZ1R5QjB2L0Mr?=
 =?utf-8?B?MHY0MTJHMWplcGRUazVxV2RYakRFV1RTRXFhVnFDUXZaRkFvSHRQYXR4b0N3?=
 =?utf-8?B?OUlGRlFtSjZKZFpoZzFTM0w0aVdmcHNQTHE0TmVsNi9tQVJuR0s1WElvTDha?=
 =?utf-8?B?cnZSVjlJUklNTzZPdWQvaTBVQmI4OUY4NmRVMnBLbllKc3pRNys5djhlTXJH?=
 =?utf-8?B?NmdZYzBBc0U4VE9TaTFQMnB4TmFMcDI1cUh2ZUVSZGp0Umk5VDRySTNxOFNm?=
 =?utf-8?B?b0pyRlZ2WG9ZS1IwWDVLWjlabHhpdWs3N0RFbTdXSklydWVFd0pmUVhBWVFo?=
 =?utf-8?B?ZEJSNVVGWnliUnJZakYva3hnSG8wdk9YMmIzMU9WRGxKd2NTdUMxMHcwaUtp?=
 =?utf-8?B?TGxIbVp2a1hONmliMzFITGdGdVNCcVlPcU53Z1FoYStUZzNCbmtVaFBUSEhy?=
 =?utf-8?B?R0ZMVGIxTjVUa1lwZnZwNWtVSFlVcFdtV2p5MXh4OEoxaFFWM2V3MEN3Zmdm?=
 =?utf-8?B?eDlXS0MxZFBWamZzNUNUYmR4SDEwc3JDOG43OEcrMG1nVEM3Z3lXRDBWdXhp?=
 =?utf-8?B?SXFxSG1FeHpuVVJFaDU3SGJtZnBJVGxCQWc5anFKcjdraU1DdHh3c3cxNEND?=
 =?utf-8?B?SExQK1dZL2laanJBd214UmdKM3NSRVg5RFliL2dEQ2I5eXZOY1d3bU9jaHVV?=
 =?utf-8?B?YURUQ25ER3NvQnFGc0VtcTBZMmgvdWFtQm9id0R5a3c4ZEo3dmdSblc4L0Z1?=
 =?utf-8?Q?edAUFsuFpCTPOmMXNs=3D?=
X-OriginatorOrg: sct-15-20-7784-11-msonline-outlook-95b76.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 5587c10b-d50f-4c7b-f391-08dccbb06912
X-MS-Exchange-CrossTenant-AuthSource: AM8P250MB0170.EURP250.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Sep 2024 00:36:11.9530
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8P250MB0199
From: bobwei9@hotmail.com (Bob Weinand)

--------------dlGS03OvgvLJ52xg7WQN0mAs
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

On 3.9.2024 02:18:30, Ben Ramsey wrote:
>> On Sep 2, 2024, at 18:53, Bob Weinand<bobwei9@hotmail.com> wrote:
>>
>> On 3.9.2024 01:44:21, Ben Ramsey wrote:
>>>> On Sep 2, 2024, at 08:11, Go Kudo<zeriyoshi@gmail.com> wrote:
>>>>
>>>> Hi Internals.
>>>>
>>>> PHP currently does not provide official container images. Given that DockerHub adequately maintains these and considering the maintenance costs, we haven't felt the need to change the status quo.
>>>>
>>>> However, the official DockerHub images lack debug builds, which can be somewhat inconvenient when trying to report bugs or reproduce issues.
>>>>
>>>> What if we were to provide debug build container images that are compatible with the official DockerHub images? Fortunately, we already conduct most of our development on GitHub, which has a container registry called Packages.
>>>>
>>>> This could be achieved simply by creating a single repository under the php organization on GitHub. What are your thoughts on this?
>>>>
>>>> Best Regards.
>>>> Go Kudo
>>> Since the folks who do the DockerHub builds already have all the infrastructure set up to maintain the images, I think it might be easier to work with them to have them provide debug builds.
>>>
>>> Perhaps there’s someone from that team on this list who can speak to that?
>>>
>>> Cheers,
>>> Ben
>> Hey Ben,
>>
>> what I'd _really_ like to see is not debug-builds, but debug symbols.
>>
>> Basically, you'd have a docker image "php:8.3" and a docker image "php:8.3-dbgsym". The former image then just has a gnu_debuglink. The latter has the actual symbols file included and is based on the former.
>>
>>
>> Thanks,
>>
>> Bob
>
> I think the team who manages the Docker builds could also provide images with debug symbols. Since they’re already equipped for it and have the experience, why don’t we partner with them to provide these images to the community?
>
> Cheers,
> Ben

Yes. Absolutely.

The problem, however, if you want to provide a build with debug symbols 
and one without, the primary value for me would be being able to take a 
core dump produced in an image without debug symbols and then simply 
open the image with debug symbols and inspect it there.

To the best of my knowledge however, it isn't trivially possible to 
build two docker images with the same docker build invocation. Basically 
you'd need an intermediary image, from which you then create both (so, 3 
different docker builds - one base image which has the build and the 
symbols but is not uploaded. And two images where the base images files 
are copied into.). I believe this would not be compatible with the way 
docker-library/php is built currently.

So, yes, please reach out to them what they are willing to do.


Thanks,

Bob

--------------dlGS03OvgvLJ52xg7WQN0mAs
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body>
    <div class="moz-cite-prefix">On 3.9.2024 02:18:30, Ben Ramsey wrote:<br>
    </div>
    <blockquote type="cite" cite="mid:8D35CEB1-3B48-4889-BEAB-63AAE6DB8A01@php.net">
      <blockquote type="cite">
        <pre wrap="" class="moz-quote-pre">On Sep 2, 2024, at 18:53, Bob Weinand <a class="moz-txt-link-rfc2396E" href="mailto:bobwei9@hotmail.com">&lt;bobwei9@hotmail.com&gt;</a> wrote:

On 3.9.2024 01:44:21, Ben Ramsey wrote:
</pre>
        <blockquote type="cite">
          <blockquote type="cite">
            <pre wrap="" class="moz-quote-pre">On Sep 2, 2024, at 08:11, Go Kudo <a class="moz-txt-link-rfc2396E" href="mailto:zeriyoshi@gmail.com">&lt;zeriyoshi@gmail.com&gt;</a> wrote:

Hi Internals.

PHP currently does not provide official container images. Given that DockerHub adequately maintains these and considering the maintenance costs, we haven't felt the need to change the status quo.

However, the official DockerHub images lack debug builds, which can be somewhat inconvenient when trying to report bugs or reproduce issues.

What if we were to provide debug build container images that are compatible with the official DockerHub images? Fortunately, we already conduct most of our development on GitHub, which has a container registry called Packages.

This could be achieved simply by creating a single repository under the php organization on GitHub. What are your thoughts on this?

Best Regards.
Go Kudo
</pre>
          </blockquote>
          <pre wrap="" class="moz-quote-pre">
Since the folks who do the DockerHub builds already have all the infrastructure set up to maintain the images, I think it might be easier to work with them to have them provide debug builds.

Perhaps there’s someone from that team on this list who can speak to that?

Cheers,
Ben
</pre>
        </blockquote>
        <pre wrap="" class="moz-quote-pre">
Hey Ben,

what I'd _really_ like to see is not debug-builds, but debug symbols.

Basically, you'd have a docker image &quot;php:8.3&quot; and a docker image &quot;php:8.3-dbgsym&quot;. The former image then just has a gnu_debuglink. The latter has the actual symbols file included and is based on the former.


Thanks,

Bob
</pre>
      </blockquote>
      <pre wrap="" class="moz-quote-pre">

I think the team who manages the Docker builds could also provide images with debug symbols. Since they’re already equipped for it and have the experience, why don’t we partner with them to provide these images to the community?

Cheers,
Ben</pre>
    </blockquote>
    <p>Yes. Absolutely.</p>
    <p>The problem, however, if you want to provide a build with debug
      symbols and one without, the primary value for me would be being
      able to take a core dump produced in an image without debug
      symbols and then simply open the image with debug symbols and
      inspect it there.</p>
    <p>To the best of my knowledge however, it isn't trivially possible
      to build two docker images with the same docker build invocation.
      Basically you'd need an intermediary image, from which you then
      create both (so, 3 different docker builds - one base image which
      has the build and the symbols but is not uploaded. And two images
      where the base images files are copied into.). I believe this
      would not be compatible with the way docker-library/php is built
      currently.</p>
    <p>So, yes, please reach out to them what they are willing to do.</p>
    <p><br>
    </p>
    <p>Thanks,</p>
    <p>Bob<br>
    </p>
    <p><span style="white-space: pre-wrap">
</span></p>
  </body>
</html>

--------------dlGS03OvgvLJ52xg7WQN0mAs--