Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125387
Message-ID: <e1321b08-2329-4000-95b9-dc3daf1dca9a@gmx.de>
Date: Mon, 2 Sep 2024 15:24:40 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] strrchr with needle with multiple characters
Content-Language: de-DE
To: Vincent Langlet <misterdeviling@gmail.com>,
 PHP Internals List <internals@lists.php.net>
References: <CABEW5qcXrpZCjsbqF9bgDwX4vgCP71aEExwdwRopVL3PW=Tvrg@mail.gmail.com>
In-Reply-To: <CABEW5qcXrpZCjsbqF9bgDwX4vgCP71aEExwdwRopVL3PW=Tvrg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:oi2kbo/uzEo=;l5cYCgN1VlQ8Ox1LLVccFqVwHEO
 GcjsJQJ7NM8hf9+BLg/LkYBobMswhl2WHr9jwGnhmkjO72SkbXFD2PVUyopIefhUpjhoj0YNy
 ZEOIe7IRVglOpjUC41m8wxOZERUdgkdRE+FNYGh33OoRaRSUHkjOnFFZXOhn2IUR0RxaBSEz3
 DXIxmkSldVCHTMJDGEheQCYlAzZe7mUoa8hLD6M/QukSgNT9eYiK3KCo+spH4Ur/4HzumpRCM
 4B7fQ3K/PNqqpigcM/AqPeALwCMn+LZeLR8JrSrTrSeD0cpl7RdbmBRh5fmVl8HSDwRB1uO7o
 tprWAqi1kV5D51nw7xf3vC3nC0gxyBFkRcD3v9XJrcQflrw4OhkuVkB5SOKQNl++SNPYJWAV8
 NeLpRSTZyWyxDBI0WkFixUSI1u3AAHYTNIe1CwFGpMJMDhsSiJBn7DOwtDSdD2Mois+tKkfsN
 wNy49ohbux9RLoHSdfprq/QQFmuEUuinclRK4z65Eh6IJGZqzMIie4K/JT+ypOaymMxY08qCN
 F648p3HYn0k1s2FlK57zHO//szdecIF5K9yUrgeTebTjAXz5yUjQaFfLgBe80sdT+E79GcK7f
 LZrYIsInvrvs9EJFvfPqgQT5Q7gRCGf1n0HfgEu3/PcqMHBliK6IWCaKSZnGRNf7QcvknuxZS
 X99P8WTkGlKUhqxAdED0snvcHaCrpUYEM12TdqZwkjXjdZHulxtYrsnYpaKanW88nfgtvzbnK
 In1hEGV+fb3kQlZUV0gOh1VmDspasCCHFGGxIlU5BoXx6XJoT+wy2JvrZJJzEBmjuKn5Sl+2c
 rQT1YuhbHoD8KTkZo1Pm9Pww0oWcgwb3xLMoPd25CNHxQ=
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 02.09.2024 at 13:17, Vincent Langlet wrote:

> I was today old when I discovered the big difference between strchr and
> strrchr in the way they handle needle with multiple characters.
>
> It's explained in the doc https://www.php.net/manual/en/function.strrchr=
.php
> - If needle contains more than one character, only the first is used. Th=
is
> behavior is different from that of strstr()
> <https://www.php.net/manual/en/function.strstr.php>.
>
> You can see an example https://3v4l.org/7j5ab
>
> I feel like this behavior has no benefit (if I want to look for the firs=
t
> character, I can pass `substr($needle, 0, 1)` instead) and is just
> error-prone.
>
> Is there a reason for such behavior ? Would it be easy to change it (I h=
ave
> no knowledge at all in C and in the existing PHP code) ?

strchr() is an alias of strstr(), and I would always use the latter
name, because strchr() is indeed confusing.  Anyhow, strstr() is very
useful in C, but not so much in PHP, since in PHP it will always
allocate a new string, even if that is not needed.

Now, comparing strstr() and strrchr() is of course still possible, but
different behavior is less astonishing.  Of course, strrchr() could warn
or even throw if $needle has more than one character, but that may
unnecessarily break code for a small benefit.

Christoph