Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:125374 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id 0F21D1A00BD for ; Sun, 1 Sep 2024 07:17:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1725175137; bh=zFD2Y4kvC8KTEGnq5lahm3BNUdOQTF4iM6H1RhQ9pBA=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=Dp0t32DQbsV8Fj9gsCfKF62Tf3KuabHMXW+SCmLIh+GhGb6soAa2PmQoLmLMYzxe5 EVaNcKDLYy+8TMtkzxoS2WqqbEtGtqfzJppfQODCKR+0DCBogRc0q479cAhemJl46u vF2OhZgvSMEJRfOZ3AahSL/CsJDItkOsFIGab9LYJflbkSUhphxDBqXpJ9d7zEZy0D REfOIYStJ69MEl5FpqmZQJym++L7C6ML1xAd3rpLDw9ZyXh+WQCU7fxDuRcIbpTkqy /rE8ZLTFHqFDIl5m6xlvrRluVQHBscPSMAHZbczgdMjIfTf86JjD8pnURhU5WF8L0V BuAnSYVw7PIeA== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id DC4D018006A for ; Sun, 1 Sep 2024 07:18:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DMARC_MISSING,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sun, 1 Sep 2024 07:18:56 +0000 (UTC) Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-e02b79c6f21so3394659276.2 for ; Sun, 01 Sep 2024 00:17:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=newclarity-net.20230601.gappssmtp.com; s=20230601; t=1725175019; x=1725779819; darn=lists.php.net; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Al6OkQBgZvL/Y7iUI9RKa18XbVyVr0L7czrYJlpcbAE=; b=PhxuLi6s0NID8mWZgs/6Y0d2nKx2gvm+UBi/u0by+eSKMwZbam+go3OJHh5REPH1++ 9Q/RfMFgGgeFVOvn+W9diZ5V3Ifff5ZHTjqzZira0K3BT2wT/UV7BgJe0OvIBnBI1eWN tvobYY5bnBfJkq9RgYcvU/Tfer/dIGOudKtraG5ii6FsEGJD1YAzwHIpy2+5UUwamo43 mdUq1ruiwZngMzhcon4VzlbdAOwKCiTEuSenZfg2pK8X8mR0fHiq45pj5oacimDdt2qC zPMfH/olse5NFtr7hfQ0WkWYk9f9a4OnvWJaaJhvTQ0OUrX7lKftxtJ60JlSH8bfpLvL ZwWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725175019; x=1725779819; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Al6OkQBgZvL/Y7iUI9RKa18XbVyVr0L7czrYJlpcbAE=; b=Z8YP230ySnG2nSTOwbl6KfbXcUB0pQ+bY6WLS23WYfn3+bJxSSqYQr2ea9CWa9P49L 10HwSCvKZMW3ciM8P5HNVPrcwCMIstnMIjJAGre4yETZiapIAFFwn9mWjC0oXRck/rrJ 1A5kKLzWWoTBIjKSv1qtHRBMoIsPN7mvYC0IXzREbgiokYbwGbOCLjmQo6z7QO83PD7/ 4ny5qPFW9cnK3BbVxorhTOhwBS8cxKCKXkvidjL2GVnGZv/Ss4lKzCTXZKcSiS2gIcly ZeOvl4KB+c5xI7WgQPpaO4gxfZnL9v1kfulHZ3t9r29FbdHSNPSGtBs63syTfOWr+yWo kztg== X-Forwarded-Encrypted: i=1; AJvYcCWfyL6/+uMN5HepOf5QMBiDVH2tMgSzk2q+RcsI9F2DkjwOdraBlipB30u55xzb04VmMsvEaxCzeEI=@lists.php.net X-Gm-Message-State: AOJu0YyjpOypUKZ3zDtd+qIvslqUGl8kuheQYo337AQUmExx23mRxAzz /D30Vnox8S49ljfyvp0QO5Tiy8NXVnvqjhbrVQ1UYXsLw1j9z1ns3nRMwiJTqkRWL+wVKsCtvia 4asQ= X-Google-Smtp-Source: AGHT+IHIPNHNNNgPwnnl9nQKC85We0SSOOAEL18moQQRv6EBj5RafPDPwwxtZlGUfVG5E5Ap3VZCvQ== X-Received: by 2002:a05:6902:704:b0:e1a:9336:8b65 with SMTP id 3f1490d57ef6-e1a93368d7dmr2933882276.32.1725175019292; Sun, 01 Sep 2024 00:16:59 -0700 (PDT) Received: from smtpclient.apple (c-98-252-216-111.hsd1.ga.comcast.net. [98.252.216.111]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e1a8e7a14a5sm580877276.20.2024.09.01.00.16.58 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Sep 2024 00:16:58 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.10\)) Subject: Re: [PHP-DEV] PHP 8.3.11 Released In-Reply-To: <261c47a3-f3d7-4328-9cb9-1b9a44e0fb5b@gmx.de> Date: Sun, 1 Sep 2024 03:16:58 -0400 Cc: Derick Rethans , PHP internals , Jakub Zelenka Content-Transfer-Encoding: quoted-printable Message-ID: <621B5876-919D-4C97-B0B3-0E5A658F8EA7@newclarity.net> References: <9b35954d-ae70-4c74-ab85-2ecacfd594fb@gmx.de> <594b4499-7919-496d-a039-1c1afa06b8a1@gmx.de> <2E5F4DF6-CCE0-43BB-9F1B-5E82FFB89EBB@php.net> <261c47a3-f3d7-4328-9cb9-1b9a44e0fb5b@gmx.de> To: "Christoph M. Becker" X-Mailer: Apple Mail (2.3696.120.41.1.10) From: mike@newclarity.net (Mike Schinkel) > On Aug 31, 2024, at 1:44 PM, Christoph M. Becker = wrote: >=20 > On 31.08.2024 at 19:35, Derick Rethans wrote: >=20 >> Shouldn't we have bumped the API number for this? Better safe than = sorry. >=20 > That ABI break was accidentially committed. There was some discussion > whether to stick with the break and bump API numbers, or to revert, = and > there was consensus that in this case the latter makes more sense = (after > all, just a single release was affected, and only relevant for > extensions which actually use the streams layer). >=20 >> And I'm wondering why we have no tests for ABI breaks here? I'm sure = that I have seen a report (from Remi?) that highlighted these breakages = when I was still involved in the mongodb extension. >=20 > There was the idea to do some verifcation, but maybe it's enough to = add > something to the PR-labeler which just labels any PR which modifies a > public header. One of the benefits for users when software authors strictly follow = SemVer is that automated tooling can decide if an automatic upgrade = should be safe. Depending on out-of-band information to convey BC = breakage can result in those who use automatic upgrades to see = unexpected failures en masse since automated tooling won't look at = bespoke, non-standard labels when deciding. =20 If enough software authors choose to be less strict about SemVer it = could have the fallout that many people decide it is just too risky to = use automated tooling. Once bitten, twice shy. One approach I have seen on other projects take is they retract the = versions with BC breakage and then release an update reversing the = breakage.=20 Something to consider. -Mike=