Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125373
Message-ID: <261c47a3-f3d7-4328-9cb9-1b9a44e0fb5b@gmx.de>
Date: Sat, 31 Aug 2024 19:44:40 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] PHP 8.3.11 Released
Content-Language: de-DE
To: Derick Rethans <derick@php.net>, internals@lists.php.net,
 Jakub Zelenka <bukka@php.net>
References: <CAEKnhAEtioYxpYO9byRr4-ygoP0O9ig5rxYnwCVGc2RKs2grJQ@mail.gmail.com>
 <9b35954d-ae70-4c74-ab85-2ecacfd594fb@gmx.de>
 <CAEKnhAHVrLC0BHNq74g1YCo=M9AhXZfghdWJ=zY2WYpGsDXQSw@mail.gmail.com>
 <594b4499-7919-496d-a039-1c1afa06b8a1@gmx.de>
 <2E5F4DF6-CCE0-43BB-9F1B-5E82FFB89EBB@php.net>
In-Reply-To: <2E5F4DF6-CCE0-43BB-9F1B-5E82FFB89EBB@php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:Wc73Yxj1ZPo=;MxzTvJaLBkYo4Zz475tumvcmYZG
 ThDcgQh32jnrludCToTZWkoXPQcz2kuSBIX/AjSUvCiCBxxo3P+5WE8f029U2aNEh3UJO2H8X
 WXoqTQQnnykQEPxv6L08l+IVn8b/Si0dG1fWhngRC554lMWsjoYCb9r6vG8Floxyso5iS9Wof
 nM/1fDD8kgbop8NeSp8HEJHjSJ9dmbTwmQaPq9+vZ0w1+yavp8/yDAkoL8mipSTqAC8ZC943w
 SXpyLWivjr2VVxIo4MmH7xX7H7nsx6pVobjK8M+AUTb0PVvMl1mhc5Pn3EOswLa8W7LxzH4UY
 XRmEfUCxp+Y3k8uw2T0AQ5aG+N/WDP7V9cgUVezudcjOhD9+Z90yqRMokNw4shWDKec0urqn8
 pAVMK5t+3NS+ENmhDhan3VqhjBjh47tapY4xUzOktSBS5Uwem2MDBAbgtRNlOkkWVy1P4gFp1
 ioyEoOFLYw6iegHVE1ScKRGmdh5O4V9n9d+Sk6uq9H2rO+1Joc8MqJ+XUTyWRJ3ustfscPree
 xFse+P0nnLPdF244Kp26QqbvRKIPQnU7U8Oc1XaCh9CW6InxyGyLPTsiTHabAIW5fGd8ZrrR+
 HZQlUEzPgWO67h0bq1t31NC44LFwgmt4VsFXynKF+gQatF/SEiWDA3Pmd8ShhAPjoIvDRIr4Q
 iPnJEMHKbF4UhaQvIVr9vhrCY2WWe7F5YTzdASl3kE1Q4LbAfctbS1xHZJr2+5RQVX7b6bOTy
 zeN2wZwq9rXeSf+z+21vDd3M00t+7yBCV7DzSdyx50qEqQzwbUnuoU6WGStttDgN99jLtLMMR
 3WckxXE+XaNkcromzxK/od+Q==
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 31.08.2024 at 19:35, Derick Rethans wrote:

> Shouldn't we have bumped the API number for this? Better safe than sorry=
.

That ABI break was accidentially committed.  There was some discussion
whether to stick with the break and bump API numbers, or to revert, and
there was consensus that in this case the latter makes more sense (after
all, just a single release was affected, and only relevant for
extensions which actually use the streams layer).

> And I'm wondering why we have no tests for ABI breaks here? I'm sure tha=
t I have seen a report (from Remi?) that highlighted these breakages when =
I was still involved in the mongodb extension.

There was the idea to do some verifcation, but maybe it's enough to add
something to the PR-labeler which just labels any PR which modifies a
public header.

Christoph