Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125367
Feedback-ID: i8414410d:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Fri, 30 Aug 2024 19:10:15 -0500
To: "php internals" <internals@lists.php.net>
Message-ID: <f8e1d610-f8c5-460a-a73d-68dd37ab4636@app.fastmail.com>
In-Reply-To: 
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
References: 
 <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <dd61999c-1ebd-4765-9add-cd8065968965@gmail.com>
 <CAOV5rgYZ_s1of-igLFEK7oqqh6=3HeYv0=JvvKvvjkcp0F6Q9Q@mail.gmail.com>
 <CAH5C8xV67frqOBCvLt73RM7QO86_pu40sHP5h71_kDRbKPtA8Q@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: larry@garfieldtech.com ("Larry Garfield")

On Mon, Aug 26, 2024, at 2:40 AM, M=C3=A1t=C3=A9 Kocsis wrote:
> Hi Ignace, Niels,
>
> Sorry for being silent for so long, I was working hard on the=20
> implementation besides some summer activities :) I can say that I had
> really good progress in the last month and now I think (hope) that I=20
> managed to address most of the concerns/suggestions people mentioned
> in this thread. To summarize the most important changes:

I'm not fluent enough in the different parsing styles to comment on the =
difference there.

I do have concerns about the class design, though.  Given the improvemen=
ts to the language, the accessor methods offer zero benefit at all.  Pub=
lic-read properties (readonly or otherwise) would be faster and offer no=
 less of a guarantee.  If you want to allow someone to extend the class =
and provide some custom logic, use aviz instead of readonly and extender=
s can use hooks instead of the methods.  The getters don't offer any val=
ue anymore.

It took me a while to realize that, I think, the fromWhatWg() method is =
using an in/out parameter for error handling.  That is an insta-no on my=
 part.  in/out reference parameters make sense in C, maybe C++, and basi=
cally nowhere else.  I view them as a code smell everywhere they're used=
 in PHP.  Better alternatives include exceptions or union returns.

It looks like you've removed the with*() methods.  Why?  That means it c=
annot be used as a builder mechanism, which is plenty valuable.  (Though=
 could be an issue with query as a string vs array.)

The WhatWgError looks to me like it's begging to be an Enum.

I am confused by the new ini value.   It's for use in cases where you're=
 NOT parsing the URL yourself, but relying on some other extension that =
does URL parsing internally as a side effect? =20

As usual, I am not a fan of an ini setting, but I cannot think of a diff=
erent alternative off hand.

--Larry Garfield