Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125363
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\))
Subject: Re: [PHP-DEV] json_encode() and Generators / RFC Karma
In-Reply-To: <CAGKNXQGahmJ8nHVy1C8d7B=Zf-jse0U6KkNBeSijDJHgbJet1Q@mail.gmail.com>
Date: Fri, 30 Aug 2024 16:47:43 +0200
Cc: internals@lists.php.net
Content-Transfer-Encoding: quoted-printable
Message-ID: <783E4F90-4823-4224-B45C-E9D6EFC4479F@gmail.com>
References: <CAGKNXQGahmJ8nHVy1C8d7B=Zf-jse0U6KkNBeSijDJHgbJet1Q@mail.gmail.com>
To: Philip Hofstetter <phofstetter@sensational.ch>
From: claude.pache@gmail.com (Claude Pache)



> Le 30 ao=C3=BBt 2024 =C3=A0 09:36, Philip Hofstetter =
<phofstetter@sensational.ch> a =C3=A9crit :
>=20
> Hello,
>=20
> In the aftermath of an internal refactoring of an internal code-base =
to turn something eager into something more lazy using Generators, it =
occurred to me that while PHP refuses to serialize() a Generator, =
accidentally running json_encode() over a Generator produces the worst =
possible result:
>=20
> It silently encodes generators as {}.
>=20
> I would like to write an RFC to first deprecating and later =
disallowing to json_encode Generators.
>=20

Hi,

Note that the issue is not limited to Generators. For instance a Closure =
object is also json-encodable but not serialisable.

IMO, every internal class (not just Generator) that is marked as =
non-serialisable, should also be non-json-encodable.

=E2=80=94Claude