Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125189
Precedence: bulk
MIME-Version: 1.0
References: <CAA8B983-FD39-4AB1-B314-62608B0C0EF4@a8c.com> <76D9E1DA-57CE-45C3-8E3E-B08A0B70FB60@a8c.com>
 <efaf4c62-a552-4232-8a22-410578c13b8d@gmail.com> <7ED2EE07-D7C6-43A4-A4E1-E9928E8B8D31@automattic.com>
In-Reply-To: <7ED2EE07-D7C6-43A4-A4E1-E9928E8B8D31@automattic.com>
Date: Sat, 24 Aug 2024 21:56:21 +0200
Message-ID: <CAJmjfvXvBpxc-t2SkrK587Cm+=iOY9tNmpt-SC-pgg7pALJ9XA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Decoding HTML and the Ambiguous Ampersand
To: Dennis Snell <dennis.snell@automattic.com>
Cc: Niels Dossche <dossche.niels@gmail.com>, Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000df4e1f0620734962"
From: jakob@givoni.dk (Jakob Givoni)

--000000000000df4e1f0620734962
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Dennis,

Overall it sounds like a reasonable RFC.

> Dennis:
>
> > Niels:
> >
> > I'm not so sure that the name "decode_html" is self-descriptive enough,
it sounds very generic.
>
> The name is not very important to me. For the sake of history, the reason
I have chosen =E2=80=9Cdecode HTML=E2=80=9D is because, unlike an HTML pars=
er, this is
focused on taking a snippet of HTML =E2=80=9Ctext=E2=80=9D content and deco=
ding it into a
=E2=80=9Cplain PHP string.=E2=80=9D

Why not make it two methods called "decode_html_text" and
"decode_html_attribute"?
Consider the following reasons:
1. The function doesn't actually decode html as such, it decodes either an
html text node string or an html attribute string.
2. Saves the $context parameter and the constants/enums, making the call
significantly shorter.
3. It feels like decoding either text or attribute are two significantly
different things. I admit I could be wrong, if code like
decode_html($e->isAttritbute() ? HtmlContext::Attribute :
HtmlContext::Text, $e->getContent()) is likely to be seen. But I somehow
don't foresee a lot of situations where text and attribute strings end up
in the same code path?

A couple of other options that would silence anyone opposed to implicitly
favouring utf-8:
html_text_to_utf8 and html_attribute_to_utf8

Best,
Jakob

--000000000000df4e1f0620734962
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Dennis,<br><br>Overall it sounds like a reasonable RFC.=
<div>=C2=A0 <br>&gt; Dennis:</div><div>&gt;<br>&gt; &gt; Niels:</div><div>&=
gt; &gt;<br>&gt; &gt; I&#39;m not so sure that the name &quot;decode_html&q=
uot; is self-descriptive enough, it sounds very generic.<br>&gt;<br>&gt; Th=
e name is not very important to me. For the sake of history, the reason I h=
ave chosen =E2=80=9Cdecode HTML=E2=80=9D is because, unlike an HTML parser,=
 this is focused on taking a snippet of HTML =E2=80=9Ctext=E2=80=9D content=
 and decoding it into a =E2=80=9Cplain PHP string.=E2=80=9D<br><br>Why not =
make it two methods called &quot;decode_html_text&quot; and &quot;decode_ht=
ml_attribute&quot;?</div><div>Consider the following reasons:</div><div>1. =
The function doesn&#39;t actually decode html as such, it decodes either an=
 html text node string or an html attribute string.</div><div>2. Saves the =
$context parameter and the constants/enums, making the call significantly s=
horter.=C2=A0</div><div>3. It feels like decoding either text or attribute =
are two significantly different things. I admit I could be wrong, if code l=
ike decode_html($e-&gt;isAttritbute() ? HtmlContext::Attribute : HtmlContex=
t::Text, $e-&gt;getContent()) is likely to be seen. But I somehow don&#39;t=
 foresee a lot of situations where text and attribute strings end up in the=
 same code path?</div><div><br></div><div>A couple of other options that wo=
uld silence anyone opposed to implicitly favouring utf-8:</div><div>html_te=
xt_to_utf8 and html_attribute_to_utf8</div><div><br></div><div>Best,</div><=
div>Jakob</div><div>=C2=A0</div></div>

--000000000000df4e1f0620734962--