Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125157
Precedence: bulk
MIME-Version: 1.0
References: <21D6F160-5EAE-44FA-907B-E1DAAC1B8D75@rwec.co.uk>
 <53BD062A-4D7F-4E5D-852E-6D27641213A8@koalephant.com> <f32382b4-3bee-47ab-88ed-ad2ab154c319@app.fastmail.com>
 <7607FD64-5572-466E-9866-63C2536B2A09@koalephant.com> <0d269a38-28fe-494c-a903-50022e09f27b@app.fastmail.com>
 <E848530A-038F-40E0-A87D-D0C823C5E967@koalephant.com> <63DAE337-B117-4380-8735-186DC30FE0B7@rwec.co.uk>
 <CAPyj-LDCdo+UE0W1q6LOAVHrt6mVmGft9K4mBDvjkBWR3TT4kA@mail.gmail.com> <A4408F9B-45A2-47E4-94F6-FBE0FBD14F86@koalephant.com>
In-Reply-To: <A4408F9B-45A2-47E4-94F6-FBE0FBD14F86@koalephant.com>
Date: Fri, 23 Aug 2024 20:17:03 +0200
Message-ID: <CAPyj-LACVgBLWo7eFRvwGt9y1WRbd9MkQrNhPpbStk8exC_R2g@mail.gmail.com>
Subject: Re: [PHP-DEV] [Concept] Flip relative function lookup order (global,
 then local)
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: tovilo.ilija@gmail.com (Ilija Tovilo)

On Fri, Aug 23, 2024 at 8:11=E2=80=AFPM Stephen Reay <php-lists@koalephant.=
com> wrote:
>
> On 24 Aug 2024, at 00:32, Ilija Tovilo <tovilo.ilija@gmail.com> wrote:
>
> > I obviously also disagree with 3. as I wouldn't have sent this
> > proposal otherwise. :) Performance improvements are hard to come by
> > nowadays. It was measured on real codebases (Symfony and Laravel).
>
> Just to make sure I'm not misunderstanding something here - Symphony and =
Laravel (or anyone else) can get the exact same performance benefit you're =
talking about, if they use either a leafing `\` or `use function...` in the=
ir own code, today, correct?

As I wrote in my e-mail:

> For some context: Before proposing this change, I asked Symfony if
> they were interested in disambiguating calls to improve performance,
> given I did some work to make fully qualified calls faster. But they
> were not, stating that the change would be too verbose for their
> liking.
>
> Making unqualified calls to mean local would force Symfony into making
> the change, which is not the approach I'm interested in taking.

Yes, the full performance benefits can be achieved by prefixing your
entire codebase, which includes not only your own code but also the
code of your framework. How much you benefit from just converting your
own code of course depends on how much you rely on vendor code.

> I'm not going to pretend to know how many files either project has that u=
ses global functions, but neither of those two existing options seems parti=
cularly "hard to come by" in my mind.

The "hard to come by" part is referring to the engine, which is quite
optimized for the current semantics. Some of PHPs quirky semantics
make it hard to improve it further, this being one of them.