Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125088
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51\))
Subject: Re: [PHP-DEV] [Concept] Flip relative function lookup order (global,
 then local)
Date: Wed, 21 Aug 2024 11:22:40 +0200
References: <CAPyj-LCoBY2bPHLmsyONYDbY9aRSraLz5QNskeTiWfpMD0pTSg@mail.gmail.com>
 <c385b525-37f7-446b-aa96-72272ef9e407@app.fastmail.com>
 <CAPyj-LA4kTJTrQZUkn9kNMvWdH6SsFGU5mBO6EcpuUcRpXesgw@mail.gmail.com>
 <CAAwdEzDqcCa-rQMFmD+6mQ4wWHJW+8Bi4_5LQ3GbfcK4PCYp3Q@mail.gmail.com>
 <CAAKU0umwCHfJicXzwbahQeYF1f4DhWkpAtURxOiZjiq4bQ+qUw@mail.gmail.com>
 <8B2CA646-5778-4C66-A17C-8A30405A854B@cschneid.com>
 <CAMkukMw5_TTSj_WvppQ-Se9DUeO8LZWxQA7Dd+4nmnLHbYw_Pg@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
In-Reply-To: <CAMkukMw5_TTSj_WvppQ-Se9DUeO8LZWxQA7Dd+4nmnLHbYw_Pg@mail.gmail.com>
Message-ID: <F14EB478-1A65-414E-A31B-5244F190A202@cschneid.com>
From: cschneid@cschneid.com (Christian Schneider)

Am 21.08.2024 um 09:44 schrieb Faizan Akram Dar <hello@faizanakram.me>:
> On Wed, Aug 21, 2024, 9:34 AM Christian Schneider =
<cschneid@cschneid.com> wrote:
>> The point where I think we disagree is that it improves the code. It =
may improve performance of the code (even though I somewhat doubt this =
has a *significant* impact on most projects) but it IMHO hurts =
readability. Writing the additional \ is less of a problem but as code =
is read a lot more often than written I think the additional =
"line-noise" is something I'd like to avoid.
>=20
> You don't have to write additional \,=20
> you can add "use function" statements
>  if you prefer that style.=20

I think that is trading one problem for another:
- Having to declare all global functions like strlen with 'use' is =
(IMHO) unnecessary boilerplate which also needs to be kept in sync with =
the rest of the code below
- I am generally wary of top declarations changing "semantics" of code =
further down the line. Being able to tell what is being done without =
(far away) context is a feature and that's why I e.g. prefer =
foo($GLOBALS['bar']) to global $bar; ... foo($bar).

Regards,
- Chris