Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125085
Precedence: bulk
MIME-Version: 1.0
References: <CAPyj-LCoBY2bPHLmsyONYDbY9aRSraLz5QNskeTiWfpMD0pTSg@mail.gmail.com>
 <c385b525-37f7-446b-aa96-72272ef9e407@app.fastmail.com> <CAPyj-LA4kTJTrQZUkn9kNMvWdH6SsFGU5mBO6EcpuUcRpXesgw@mail.gmail.com>
 <CAAwdEzDqcCa-rQMFmD+6mQ4wWHJW+8Bi4_5LQ3GbfcK4PCYp3Q@mail.gmail.com>
 <CAAKU0umwCHfJicXzwbahQeYF1f4DhWkpAtURxOiZjiq4bQ+qUw@mail.gmail.com> <8B2CA646-5778-4C66-A17C-8A30405A854B@cschneid.com>
In-Reply-To: <8B2CA646-5778-4C66-A17C-8A30405A854B@cschneid.com>
Date: Wed, 21 Aug 2024 09:44:10 +0200
Message-ID: <CAMkukMw5_TTSj_WvppQ-Se9DUeO8LZWxQA7Dd+4nmnLHbYw_Pg@mail.gmail.com>
Subject: Re: [PHP-DEV] [Concept] Flip relative function lookup order (global,
 then local)
To: Christian Schneider <cschneid@cschneid.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ba2d9506202cb53a"
From: hello@faizanakram.me (Faizan Akram Dar)

--000000000000ba2d9506202cb53a
Content-Type: text/plain; charset="UTF-8"

On Wed, Aug 21, 2024, 9:34 AM Christian Schneider <cschneid@cschneid.com>
wrote:

> Am 20.08.2024 um 17:14 schrieb Levi Morrison <levi.morrison@datadoghq.com
> >:
> > Keep in mind that qualifying
> > every global function is annoying but probably can be somewhat
> > automated, and will bring better performance. So again, this improves
> > the existing code even without upgrading.
>
> Just to be sure: Would code *not* using namespaces also have to qualify
> global function calls? I admit that I somewhat skimmed the discussion so I
> might have missed that point.
>
> The point where I think we disagree is that it improves the code. It may
> improve performance of the code (even though I somewhat doubt this has a
> *significant* impact on most projects) but it IMHO hurts readability.
> Writing the additional \ is less of a problem but as code is read a lot
> more often than written I think the additional "line-noise" is something
> I'd like to avoid.
>
> Regards,
> - Chris
>

Hi Chris,

You don't have to write additional \,
you can add "use function" statements
 if you prefer that style.
It's no different from referencing global
classes, they either need to be prefixed
 with \ or need to have a corresponding "use" statement.



Kind regards,
Faizan

--000000000000ba2d9506202cb53a
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Wed, Aug 21, 2024, 9:34 AM Christian Schneider &lt;=
<a href=3D"mailto:cschneid@cschneid.com">cschneid@cschneid.com</a>&gt; wrot=
e:<br></div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;bo=
rder-left:1px #ccc solid;padding-left:1ex">Am 20.08.2024 um 17:14 schrieb L=
evi Morrison &lt;<a href=3D"mailto:levi.morrison@datadoghq.com" target=3D"_=
blank" rel=3D"noreferrer">levi.morrison@datadoghq.com</a>&gt;:<br>
&gt; Keep in mind that qualifying<br>
&gt; every global function is annoying but probably can be somewhat<br>
&gt; automated, and will bring better performance. So again, this improves<=
br>
&gt; the existing code even without upgrading.<br>
<br>
Just to be sure: Would code *not* using namespaces also have to qualify glo=
bal function calls? I admit that I somewhat skimmed the discussion so I mig=
ht have missed that point.<br>
<br>
The point where I think we disagree is that it improves the code. It may im=
prove performance of the code (even though I somewhat doubt this has a *sig=
nificant* impact on most projects) but it IMHO hurts readability. Writing t=
he additional \ is less of a problem but as code is read a lot more often t=
han written I think the additional &quot;line-noise&quot; is something I=
9;d like to avoid.<br>
<br>
Regards,<br>
- Chris<br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=3D=
"auto">Hi Chris,</div><div dir=3D"auto"><br></div><div dir=3D"auto">You don=
&#39;t have to write additional \,=C2=A0</div><div dir=3D"auto">you can add=
 &quot;use function&quot; statements</div><div dir=3D"auto">=C2=A0if you pr=
efer that style.=C2=A0</div><div dir=3D"auto">It&#39;s no different from re=
ferencing global</div><div dir=3D"auto">classes, they either need to be pre=
fixed</div><div dir=3D"auto">=C2=A0with \ or need to have a corresponding &=
quot;use&quot; statement.</div><div dir=3D"auto"><br></div><div dir=3D"auto=
"><br></div><div dir=3D"auto"><br></div><div dir=3D"auto">Kind regards,</di=
v><div dir=3D"auto">Faizan</div><div dir=3D"auto"><br></div><div dir=3D"aut=
o"><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" style=3D"ma=
rgin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
</blockquote></div></div></div>

--000000000000ba2d9506202cb53a--