Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125039
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.8\))
Subject: Re: [PHP-DEV] Should there be a `get_declared_enums()` function ?
In-Reply-To: <66C036DA.6090801@adviesenzo.nl>
Date: Sun, 18 Aug 2024 00:46:09 -0400
Cc: PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <BB2932D9-DB92-40D6-8B48-3561E5884706@newclarity.net>
References: <66BD5F05.8010409@adviesenzo.nl>
 <8dc51539-20bb-4017-b859-76066e2287e5@gmx.de>
 <4AA66A3E-1ACF-48F5-81A2-C6AAAE8B3FD0@newclarity.net>
 <66BFFC0C.1090900@adviesenzo.nl>
 <DF2F5FC7-0F5F-4000-95CF-1FBC6CDA7745@newclarity.net>
 <66C036DA.6090801@adviesenzo.nl>
To: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
From: mike@newclarity.net (Mike Schinkel)

> On Aug 17, 2024, at 1:36 AM, Juliette Reinders Folmer =
<php-internals_nospam@adviesenzo.nl> wrote:
>> What if instead PHP were to implement an optional 2nd callback =
parameter to `include()` / `require()` / `include_once()` / =
`require_once()` to allow us to capture the symbols loaded and their =
paths? The callback function could return `void` and accept an array of =
`$symbols` with the following guaranteed minimum structure?
>>=20
>> $symbols =3D array(
>>    'classes' =3D> [],
>>    'interfaces' =3D> [],
>>    'traits' =3D> [],
>>    'enums' =3D> [],
>> );
>>=20
> Except `include()` and friends aren't function calls, but language =
constructs/expressions and don't take parameters as such, so I don't see =
how that would be possible without changing `include()` and friends to =
function calls (along the lines of what happened for `exit` in PHP 8.4 =
with non-parenthesized use still possible to mitigate the otherwise huge =
breaking change),

I know that those functions can be called as a function and return a =
value like the following:

$return_value =3D include($path);

I was making an assumption that since they be called like a function =
they could also accept optional parameters, although I admittedly was =
only assuming and do not know for sure.  Do you know for a fact that =
they cannot take a 2nd parameter, or just assuming like I was?  =20

Does anyone else know for certain it is would be possible for =
`include()` et.al. to accept an optional 2nd parameter?

However, even if a 2nd parameter is not a viable option then this could =
be addressed by instead adding  a single new function with a signature =
of `spl_autoload_callback($fn callback):callback` where the callback has =
a signature of `function ($symbols array)` which could be used like so:

function loadFile($path)
{
   if (strpos(__DIR__, 'phar://') !=3D=3D 0) {
     $path =3D realpath($path);
     if ($path =3D=3D=3D false) {
       return false;
     }
   }
   if (isset(self::$loadedClasses[$path]) =3D=3D=3D true) {
     return self::$loadedClasses[$path];
   }
   $prior_callback =3D spl_autoload_callback(function($symbols) use =
($path) {
     foreach ($symbols['classes'] as $className) {
       self::$loadedClasses[$path]    =3D $className;
       self::$loadedFiles[$className] =3D $path;
     }
   });
   include($path);
   spl_autoload_callback($prior_callback);
   return self::$loadedClasses[$path];
}

>> This approach would be a less disruptive than my prior suggestion
> Not so sure about that considering the above ;-)

Well then I think a single new function would be very low on the =
disruption scale, no?

> This probably needs some more bike shedding ;-)

Shedding of bike undertaken. :-)

-Mike