Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125032
Feedback-ID: ifab94697:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Sat, 17 Aug 2024 23:33:03 +0200
To: "Stephen Reay" <php-lists@koalephant.com>
Cc: internals@lists.php.net
Message-ID: <c7782917-55ce-4d5b-bfad-2048d9a0af2d@app.fastmail.com>
In-Reply-To: <94259551-80EE-41F4-9CF9-679B79B5EA49@koalephant.com>
References: <a897e9e9-dcc7-47f9-86db-c3c15294046a@app.fastmail.com>
 <94259551-80EE-41F4-9CF9-679B79B5EA49@koalephant.com>
Subject: Re: [PHP-DEV] function autoloading v4 RFC
Content-Type: multipart/alternative;
 boundary=7996b196146d4e929c0d34cee186c7bd
From: rob@bottled.codes ("Rob Landers")

--7996b196146d4e929c0d34cee186c7bd
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 16, 2024, at 02:22, Stephen Reay wrote:
>=20
> Sent from my iPhone
>=20
> > On 16 Aug 2024, at 04:45, Rob Landers <rob@bottled.codes> wrote:
> >=20
> > Userland functions don't throw that error, so it shouldn't be an iss=
ue. (You can pass as many arguments as you want to a userland function, =
as long as there are enough of them).
>=20
> Hi Rob,
>=20
> I didn't mean the actual internal error about too many args I meant th=
e concept - it's possible a userland autoloader callback has some signat=
ure other than a single string parameter.
>=20
> I don't know if that happens in the wild or if that's considered a BC =
or not but there is a hypothetical case there where old code would stop =
working.
>=20
> Cheers
>=20
> Stephen=20
>=20

I wouldn't consider it a BC break, no. But (ironically?), Symfony crashe=
s with this change. It really shouldn't but if you take a look at https:=
//github.com/symfony/symfony/blob/7.2/src/Symfony/Component/Config/Resou=
rce/ClassExistenceResource.php#L70 and it's definition in https://github=
.com/symfony/symfony/blob/7.2/src/Symfony/Component/Config/Resource/Clas=
sExistenceResource.php#L142, you'll see that they define a function that=
 accepts two parameters. It crashes when it receives a second parameter =
of `int` instead of it's expected exception.

I've opened a drive-by PR as an attempt to fix it (https://github.com/sy=
mfony/symfony/pull/58030), but I suspect there will be other projects as=
 well that do something silly like that. They'll just have to fix it.

=E2=80=94 Rob
--7996b196146d4e929c0d34cee186c7bd
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Fri, Aug 16,=
 2024, at 02:22, Stephen Reay wrote:<br></div><blockquote type=3D"cite" =
id=3D"qt" style=3D""><div><br></div><div>Sent from my iPhone<br></div><d=
iv><br></div><div>&gt; On 16 Aug 2024, at 04:45, Rob Landers &lt;<a href=
=3D"mailto:rob@bottled.codes">rob@bottled.codes</a>&gt; wrote:<br></div>=
<div>&gt;&nbsp;<br></div><div>&gt; Userland functions don't throw that e=
rror, so it shouldn't be an issue. (You can pass as many arguments as yo=
u want to a userland function, as long as there are enough of them).<br>=
</div><div><br></div><div>Hi Rob,<br></div><div><br></div><div>I didn't =
mean the actual internal error about too many args I meant the concept -=
 it's possible a userland autoloader callback has some signature other t=
han a single string parameter.<br></div><div><br></div><div>I don't know=
 if that happens in the wild or if that's considered a BC or not but the=
re is a hypothetical case there where old code would stop working.<br></=
div><div><br></div><div>Cheers<br></div><div><br></div><div>Stephen&nbsp=
;<br></div><div><br></div></blockquote><div><br></div><div>I wouldn't co=
nsider it a BC break, no. But (ironically?), Symfony crashes with this c=
hange. It really shouldn't but if you take a look at&nbsp;<a href=3D"htt=
ps://github.com/symfony/symfony/blob/7.2/src/Symfony/Component/Config/Re=
source/ClassExistenceResource.php#L70">https://github.com/symfony/symfon=
y/blob/7.2/src/Symfony/Component/Config/Resource/ClassExistenceResource.=
php#L70</a>&nbsp;and it's definition in&nbsp;<a href=3D"https://github.c=
om/symfony/symfony/blob/7.2/src/Symfony/Component/Config/Resource/ClassE=
xistenceResource.php#L142">https://github.com/symfony/symfony/blob/7.2/s=
rc/Symfony/Component/Config/Resource/ClassExistenceResource.php#L142</a>=
, you'll see that they define a function that accepts two parameters. It=
 crashes when it receives a second parameter of `int` instead of it's ex=
pected exception.<br></div><div><br></div><div>I've opened a drive-by PR=
 as an attempt to fix it (<a href=3D"https://github.com/symfony/symfony/=
pull/58030">https://github.com/symfony/symfony/pull/58030</a>), but I su=
spect there will be other projects as well that do something silly like =
that. They'll just have to fix it.<br></div><div><br></div><div id=3D"si=
g121229152">=E2=80=94 Rob<br></div></body></html>
--7996b196146d4e929c0d34cee186c7bd--