Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125027
Feedback-ID: i8414410d:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Sat, 17 Aug 2024 08:17:32 -0500
To: "php internals" <internals@lists.php.net>
Message-ID: <c5cb6473-5cda-4dff-b897-346b09288447@app.fastmail.com>
In-Reply-To: <66BFF486.3020707@adviesenzo.nl>
References: <66BD5F05.8010409@adviesenzo.nl>
 <8dc51539-20bb-4017-b859-76066e2287e5@gmx.de>
 <CANLbj-oEjsJrpVcxG53Vg5rJOcMb3W3xksH2Z+gR1awDW2bSdQ@mail.gmail.com>
 <66BFF486.3020707@adviesenzo.nl>
Subject: Re: [PHP-DEV] Should there be a `get_declared_enums()` function ?
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
From: larry@garfieldtech.com ("Larry Garfield")

On Fri, Aug 16, 2024, at 7:53 PM, Juliette Reinders Folmer wrote:
> On 16-8-2024 17:01, Ayesh Karunaratne wrote:
>> I went ahead and created PR https://github.com/php/php-src/pull/15443 along with tests, UPGRADE notice, etc. I think having a `get_declared_enums` function will be helpful. The implementation is simple and straightforward too. 
> Thanks for creating the PR Ayesh!
>
> I'm presuming it's too late for PHP 8.4, what with feature freeze 
> having come & gone this week.
>
> Based on the mostly supportive responses on the list, I wonder whether 
> an RFC is needed. If so, I'd be happy to create an initial draft (for 
> PHP 8.5).
>
> Smile,
> Juliette

I would prefer to have an RFC for this, even if it's short.  I'm not against it, I just think there's enough non-trivial questions (eg, impact on get_declared_classes()) that it warrants an RFC process/discussion.

--Larry Garfield