Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125021
Precedence: bulk
MIME-Version: 1.0
References: <66BD5F05.8010409@adviesenzo.nl> <8dc51539-20bb-4017-b859-76066e2287e5@gmx.de>
 <CANLbj-oEjsJrpVcxG53Vg5rJOcMb3W3xksH2Z+gR1awDW2bSdQ@mail.gmail.com> <66BFF486.3020707@adviesenzo.nl>
In-Reply-To: <66BFF486.3020707@adviesenzo.nl>
Date: Sat, 17 Aug 2024 11:26:11 +0700
Message-ID: <CANLbj-onYejzzPieQoTG_qUDOs+tKLmWhcEcYi-NEnFsjVU3+w@mail.gmail.com>
Subject: Re: [PHP-DEV] Should there be a `get_declared_enums()` function ?
To: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
From: ayesh@php.watch (Ayesh Karunaratne)

>
> I'm presuming it's too late for PHP 8.4, what with feature freeze having come & gone this week.
>
> Based on the mostly supportive responses on the list, I wonder whether an RFC is needed. If so, I'd be happy to create an initial draft (for PHP 8.5).
>

Thank you!

We now have the Release Cycle Update RFC approved
(https://wiki.php.net/rfc/release_cycle_update#allow_features_that_do_not_require_an_rfc_in_the_beta_period),
and it does allow minor new features during the beta period.

Quoting from the RFC:

> [snip]
> It therefore seems illogical to allow RFC-requiring features to be merged during the beta period, but not minor improvements that do not require an RFC, such as adding constant, parameters, config options, or even small functions or methods.
>
> We propose to explicitly allow minor features, optimizations, and internal API / ABI changes, during the beta period.

I think the `get_declared_enums` is small enough to be considered a
minor change given we don't change any engine internals. Given the
positive response on the mailing list, I think we can have this in PHP
8.4 as well, subject to RMs approval of course. There's also a PR from
yesterday (https://github.com/php/php-src/pull/15446) that added a new
Curl constant.