Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125017
Subject: Re: [PHP-DEV] Should there be a `get_declared_enums()` function ?
To: PHP internals <internals@lists.php.net>
References: <66BD5F05.8010409@adviesenzo.nl>
 <8dc51539-20bb-4017-b859-76066e2287e5@gmx.de>
 <CANLbj-oEjsJrpVcxG53Vg5rJOcMb3W3xksH2Z+gR1awDW2bSdQ@mail.gmail.com>
Cc: Ayesh Karunaratne <ayesh@php.watch>
Message-ID: <66BFF486.3020707@adviesenzo.nl>
Date: Sat, 17 Aug 2024 02:53:26 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <CANLbj-oEjsJrpVcxG53Vg5rJOcMb3W3xksH2Z+gR1awDW2bSdQ@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------040605020706050801040708"
From: php-internals_nospam@adviesenzo.nl (Juliette Reinders Folmer)

This is a multi-part message in MIME format.
--------------040605020706050801040708
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 16-8-2024 17:01, Ayesh Karunaratne wrote:
> I went ahead and created PR https://github.com/php/php-src/pull/15443 
> along with tests, UPGRADE notice, etc. I think having a 
> `get_declared_enums` function will be helpful. The implementation is 
> simple and straightforward too. 

Thanks for creating the PR Ayesh!

I'm presuming it's too late for PHP 8.4, what with feature freeze having 
come & gone this week.

Based on the mostly supportive responses on the list, I wonder whether 
an RFC is needed. If so, I'd be happy to create an initial draft (for 
PHP 8.5).

Smile,
Juliette



--------------040605020706050801040708
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    On 16-8-2024 17:01, Ayesh Karunaratne wrote:<br>
    <blockquote
cite="mid:CANLbj-oEjsJrpVcxG53Vg5rJOcMb3W3xksH2Z+gR1awDW2bSdQ@mail.gmail.com"
      type="cite">
      I went ahead and created PR
      <a class="moz-txt-link-freetext" href="https://github.com/php/php-src/pull/15443">https://github.com/php/php-src/pull/15443</a>
      along with tests, UPGRADE notice, etc.
      I think having a `get_declared_enums` function will be helpful.
      The
      implementation is simple and straightforward too.
    </blockquote>
    <br>
    Thanks for creating the PR Ayesh!<br>
    <br>
    I'm presuming it's too late for PHP 8.4, what with feature freeze
    having come &amp; gone this week.<br>
    <br>
    Based on the mostly supportive responses on the list, I wonder
    whether an RFC is needed. If so, I'd be happy to create an initial
    draft (for PHP 8.5).<br>
    <br>
    Smile,<br>
    Juliette<br>
    <br>
    <br>
  </body>
</html>

--------------040605020706050801040708--