Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:125010
Content-Type: text/plain;
	charset=utf-8
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.8\))
Subject: Re: [PHP-DEV] Should there be a `get_declared_enums()` function ?
In-Reply-To: <8dc51539-20bb-4017-b859-76066e2287e5@gmx.de>
Date: Fri, 16 Aug 2024 20:00:55 -0400
Cc: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>,
 PHP internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <4AA66A3E-1ACF-48F5-81A2-C6AAAE8B3FD0@newclarity.net>
References: <66BD5F05.8010409@adviesenzo.nl>
 <8dc51539-20bb-4017-b859-76066e2287e5@gmx.de>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
From: mike@newclarity.net (Mike Schinkel)

To everyone on this thread and thus nobody in specific (hence my top =
post):

Given that get_declared_*() populates a new ZEND_HASH each time the =
function is called[1] =E2=80=94 which for classes can easily be hundreds =
of strings =E2=80=94 would there be any appetite to:=20

1. Add an optional parameter =E2=80=94 e.g. =
`get_declared_classes($startingFrom)` =E2=80=94 that can limit the =
number of symbols starting with "n"  where if n=3D=3D100 then it would =
return array_slice($symbols,100), and=20

2. Add a function =E2=80=94 `get_declared_class_count()` =E2=80=94 that =
returns the current number of declared symbols of whichever kind of =
symbol, so we can get the "n" before calling `include`/`require` to use =
with get_declared_*() after calling  `include`/`require`?

Used in a (very simplistic) example:

function autoload($class) {
   $starting=46rom =3D get_declared_class_count();
   if (!file_exists("src/{$class}.php")) {
     return;
   }
   include_once "src/{$class}.php";
   foreach (get_declared_classes($startingFrom) as $class) {
     if (!method_exists($class,'init')) {
       continue;
     }
     $class::init();
   }
}

This would cut down on creating hashes with 100+ strings that get =
immediately thrown away, and also cut down on memory =
fragmentation/garbage collector churn.=20

-Mike

[1] =
https://github.com/php/php-src/blob/18d41502da0da1bb3928e60c41f1b821974c2c=
01/Zend/zend_builtin_functions.c#L1371


> On Aug 16, 2024, at 7:13 AM, Christoph M. Becker <cmbecker69@gmx.de> =
wrote:
>=20
> On 15.08.2024 at 03:51, Juliette Reinders Folmer wrote:
>=20
>> Should a `get_declared_enums()` function be added ?
>=20
> Here we go:
>=20
>    function get_declared_enums() {
>        $enums =3D [];
>        $exts =3D get_loaded_extensions(false);
>        foreach ($exts as $ext) {
>            $re =3D new ReflectionExtension($ext);
>            $classes =3D $re->getClasses();
>            foreach ($classes as $class) {
>                if ($class->isEnum()) {
>                    $enums[] =3D $class->name;
>                }
>            }
>        }
>        return $enums;
>    }
>=20
> Porting this to C is left as an excercise for the reader. ;)  Hint:
> =
<https://github.com/php/php-src/blob/8853cf3ae950a1658054f286117bc8f77f724=
f00/Zend/zend_builtin_functions.c#L1371-L1399>
>=20
> Note that the terminating folding marker is backwards.
>=20
>> And should the `get_declared_classes()` function be adjusted to =
exclude
>> enums ?
>=20
> For reasons that have been stated elsewhere in this thread, I don't
> think so.
>=20
> Cheers,
> Christoph