Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124994
Date: Fri, 16 Aug 2024 15:57:04 -0400
To: Bilge <bilge@scriptfusion.com>
Cc: "=?utf-8?Q?internals=40lists.php.net?=" <internals@lists.php.net>
Message-ID: <59BED9FD-EB77-4B44-9F93-7FC573EC7F14@getmailspring.com>
In-Reply-To: <501db7d2-55e1-4b20-bb6e-1e079aa4939b@scriptfusion.com>
References: <501db7d2-55e1-4b20-bb6e-1e079aa4939b@scriptfusion.com>
Subject: Re: [PHP-DEV] String enums & __toString()
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="66bfaf10_327b23c6_17d67"
From: john@coggeshall.org (John Coggeshall)

--66bfaf10_327b23c6_17d67
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

> Didja really?
>
> https://wiki.php.net/rfc/auto-implement_stringable_for_string_backed_enums
I swear I did. <shame>
That said, looking at that RFC it's a slightly different take than what I am suggesting. This RFC suggests that string enums automatically implement Stringable . I am pointing out that it's a little silly IMO that we don't allow __toString() at all and let the developer choose if they want to implement Stringable . Looking through the PR comments it's pretty clear there was a decent amount of support for this alternative idea. It also looks like the PR for this died on the vine and I'm curious is there is any interest in reviving the discussion?
I'm not seeing an obvious upside to forbidding straight out __toString() , especially (as is pointed out in the PR comments) that you can use other native interfaces like JsonSerializable without issue.

--66bfaf10_327b23c6_17d67
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

<blockquote><div><div>Didja really=3F</div><br><div><a href=3D=22https://=
wiki.php.net/rfc/auto-implement=5Fstringable=5Ffor=5Fstring=5Fbacked=5Fen=
ums=22 title=3D=22https://wiki.php.net/rfc/auto-implement=5Fstringable=5F=
for=5Fstring=5Fbacked=5Fenums=22>https://wiki.php.net/rfc/auto-implement=5F=
stringable=5Ffor=5Fstring=5Fbacked=5Fenums</a><br></div></div></blockquot=
e><div><div>I swear I did. &lt;shame&gt;</div><br><div>That said, looking=
 at that R=46C it's a slightly different take than what I am suggesting. =
This R=46C suggests that <code>string</code>&nbsp; enums automatically im=
plement <code>Stringable</code>&nbsp;. I am pointing out that it's a litt=
le silly IMO that we don't allow <code>=5F=5FtoString()</code>&nbsp; at a=
ll and let the developer choose if they want to implement <code>Stringabl=
e</code>&nbsp;. Looking through the PR comments it's pretty clear there w=
as a decent amount of support for this alternative idea. It also looks li=
ke the PR for this died on the vine and I'm curious is there is any inter=
est in reviving the discussion=3F </div><br><div>I'm not seeing an obviou=
s upside to forbidding straight out <code>=5F=5FtoString()</code>&nbsp;, =
especially (as is pointed out in the PR comments) that you can use other =
native interfaces like <code>JsonSerializable</code>&nbsp; without issue.=
 </div><br></div>
--66bfaf10_327b23c6_17d67--