Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124981
Message-ID: <6b87792b-607a-45db-bace-7175ef659024@gmx.de>
Date: Fri, 16 Aug 2024 17:43:59 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Should there be a `get_declared_enums()` function ?
Content-Language: de-DE
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>,
 PHP internals <internals@lists.php.net>
References: <66BD5F05.8010409@adviesenzo.nl>
 <8dc51539-20bb-4017-b859-76066e2287e5@gmx.de>
 <CAOWwgpkkg41x=iN_R3jTo=AxR8r__UjEXjrajbbcKUW9StTnMQ@mail.gmail.com>
In-Reply-To: <CAOWwgpkkg41x=iN_R3jTo=AxR8r__UjEXjrajbbcKUW9StTnMQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:lvCANzPHcP4=;sgwt/xN4U+xRW3S/ifTwuqKkp5X
 SYkRLLAMKLO4wL2mpsoH1xEY7UEd3KTkU8ix4DK3zraruo6YUXleelZbzgCTP79VV2wYdzSyD
 v03TXFJ/3DJHNuN55bcygIL1TiCsOZq3kUQW/ZXgQdmVGQx6WgNqs++MvV/me8w1A8yGbC/dk
 Wte+OQatmc0FYhG6GQzTIc3hgyjm3ABxpulXhEcxnLVAymcPukzcegKBspH68J3OTBmC3/c8m
 1sRP1lkdYX2c8sKTwIsNIrEBGOKUq0L5iYWdD5DT56R8AhQcq/UOjyyNCAvn7wxkWdzB8J5o2
 zNzzdUwpg2f0eGaO7nZBzkFFrf1cVblz4vjpMatdirRASmKBpfyZwRLHMojUKZiXNV2q9sk73
 bSADQldZddj+cTbSyJ3gusmo91NNpyuLMFA47rg5cGMC7stPiQqfDv6y0yBHmLAkpmMp68uz6
 OR6WUAtwSRBDFUJnaPmwmRgPuXT4dz9iRY3FbDk4VNBqz+MN1p7WN31Qi/XpZtrxezur3IYI3
 7ZW5iI8JySa8d0/ujd4BX9gXU6Do6Jmu+v43ITSxEe5EnvMJlopWBBt+bhHBsBt0m2hpgDymT
 QpYEZVdQF2UK1nWZgO0YTEVB9ql5rkwut8GWXraw9n7Ljg39i7C4ufLAF+Bt5p33WokDqxcc7
 yPz1cvBnCpHFszw7/omxn4y8LKlkk9UKy6bU3u8vDQOXEchQ4jxy5uktYKj66GaTv88WYrTB3
 kak8JWU6UOmi3NsqM0gO58ckrp5NfyhoNQQMynG2c5yHwYm2+gjbn1/X1mnUU5VL40v4FMah+
 Wv2i1mRE44+baVRyBiqo34OQ==
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 16.08.2024 at 17:11, Nicolas Grekas wrote:

>> Should a `get_declared_enums()` function be added ?
>>
>> Here we go:
>>
>>     function get_declared_enums() {
>>         $enums =3D [];
>>         $exts =3D get_loaded_extensions(false);
>>         foreach ($exts as $ext) {
>>             $re =3D new ReflectionExtension($ext);
>>             $classes =3D $re->getClasses();
>>             foreach ($classes as $class) {
>>                 if ($class->isEnum()) {
>>                     $enums[] =3D $class->name;
>>                 }
>>             }
>>         }
>>         return $enums;
>>     }
>
> And here is a one liner:
>
>     function get_declared_enums() {
>          return array_filter(get_declared_classes(), 'enum_exists');
>     }

Nice!

Are you suggesting that there is no need for get_declared_enums() in the
core, since it can be implemented in userland with a single function call?

If so, I still would argue that it makes sense to implement the function
in the core for (a) consistency, and (b) performance reasons.

Cheers,
Christoph