Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124980
Precedence: bulk
MIME-Version: 1.0
References: <66BD5F05.8010409@adviesenzo.nl> <8dc51539-20bb-4017-b859-76066e2287e5@gmx.de>
In-Reply-To: <8dc51539-20bb-4017-b859-76066e2287e5@gmx.de>
Date: Fri, 16 Aug 2024 17:11:29 +0200
Message-ID: <CAOWwgpkkg41x=iN_R3jTo=AxR8r__UjEXjrajbbcKUW9StTnMQ@mail.gmail.com>
Subject: Re: [PHP-DEV] Should there be a `get_declared_enums()` function ?
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008738ce061fce6028"
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--0000000000008738ce061fce6028
Content-Type: text/plain; charset="UTF-8"

> Should a `get_declared_enums()` function be added ?
>
> Here we go:
>
>     function get_declared_enums() {
>         $enums = [];
>         $exts = get_loaded_extensions(false);
>         foreach ($exts as $ext) {
>             $re = new ReflectionExtension($ext);
>             $classes = $re->getClasses();
>             foreach ($classes as $class) {
>                 if ($class->isEnum()) {
>                     $enums[] = $class->name;
>                 }
>             }
>         }
>         return $enums;
>     }
>
> Porting this to C is left as an excercise for the reader. ;)  Hint:
> <
> https://github.com/php/php-src/blob/8853cf3ae950a1658054f286117bc8f77f724f00/Zend/zend_builtin_functions.c#L1371-L1399
> >
>
> Note that the terminating folding marker is backwards.
>
> > And should the `get_declared_classes()` function be adjusted to exclude
> > enums ?
>
> For reasons that have been stated elsewhere in this thread, I don't
> think so.
>


And here is a one liner:

    function get_declared_enums() {
         return array_filter(get_declared_classes(), 'enum_exists');
    }

--0000000000008738ce061fce6028
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-=
left:1px solid rgb(204,204,204);padding-left:1ex">
&gt; Should a `get_declared_enums()` function be added ?<br>
<br>
Here we go:<br>
<br>
=C2=A0 =C2=A0 function get_declared_enums() {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $enums =3D [];<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 $exts =3D get_loaded_extensions(false);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 foreach ($exts as $ext) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $re =3D new ReflectionExtension($=
ext);<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $classes =3D $re-&gt;getClasses()=
;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 foreach ($classes as $class) {<br=
>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 if ($class-&gt;isEn=
um()) {<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 $enum=
s[] =3D $class-&gt;name;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 }<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 return $enums;<br>
=C2=A0 =C2=A0 }<br>
<br>
Porting this to C is left as an excercise for the reader. ;)=C2=A0 Hint:<br=
>
&lt;<a href=3D"https://github.com/php/php-src/blob/8853cf3ae950a1658054f286=
117bc8f77f724f00/Zend/zend_builtin_functions.c#L1371-L1399" rel=3D"noreferr=
er" target=3D"_blank">https://github.com/php/php-src/blob/8853cf3ae950a1658=
054f286117bc8f77f724f00/Zend/zend_builtin_functions.c#L1371-L1399</a>&gt;<b=
r>
<br>
Note that the terminating folding marker is backwards.<br>
<br>
&gt; And should the `get_declared_classes()` function be adjusted to exclud=
e<br>
&gt; enums ?<br>
<br>
For reasons that have been stated elsewhere in this thread, I don&#39;t<br>
think so.<br></blockquote><div><br></div><div><br></div><div>And here is a =
one liner:</div><div><br></div><div>=C2=A0 =C2=A0 function get_declared_enu=
ms() {<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return array_filter(get_declare=
d_classes(), &#39;enum_exists&#39;);<br>=C2=A0 =C2=A0 }<br>=C2=A0</div></di=
v></div>

--0000000000008738ce061fce6028--