Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124974
Precedence: bulk
MIME-Version: 1.0
References: <34548342633f1d87b2fc77c643bd895a18f71b66.camel@ageofdream.com>
In-Reply-To: <34548342633f1d87b2fc77c643bd895a18f71b66.camel@ageofdream.com>
Date: Fri, 16 Aug 2024 14:35:09 +0300
Message-ID: <CAAwdEzBWN40q10Q5ua_ZME29dJSqs=BHB1LxJ62mN-vXWNw0xQ@mail.gmail.com>
Subject: Re: [PHP-DEV] [DISCUSSION] Class Constant Enums?
To: Nick Lockheart <lists@ageofdream.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000045e0e061fcb5b48"
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000045e0e061fcb5b48
Content-Type: text/plain; charset="UTF-8"

Hi Nick,

>
> Is there any interest in having enums as class constants?
>
> I'm often finding cases where I would like to have an enum inside of a
> class, but don't want a free-floating enum that's basically like
> another class.
>
>
...<snip>...


>
> class SSHClient {
>
>    public const enum CommandResult
>    {
>        case Success;
>        case Failure;
>        case Unknown;
>        case Timeout;
>    }
>
>    // ...
> }
>
>
> // Usage:
>
> SSHClient::CommandResult::Success
>


I feel this topic could be maybe more broad and be called "nested classes"
that are already supported in multiple languages: Java, Swift, Python, C#,
C++, JavaScript, etc.

The syntax you showed is usually identical with what other languages use,
except that probably the const is unnecessary.
The nested class can have visibility as sometimes having it private makes
sense.
Accessing it through `::` is probably fine, but a deeper look at the
grammar might be necessary.
The nested class would have access to parent class private properties and
methods.

I also mentioned this topic on the subject of defining a type in an
autoloader compatible way.
And indeed, a type could also be defined nested in a class if we want to
support that as well.

Now, this feature is not simple, and I think it needs proper sponsorship
from someone experienced with internals.

Regards,
Alex

--000000000000045e0e061fcb5b48
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi Nick,</div><div class=3D"gmail_quote"><blockquote =
class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px sol=
id rgb(204,204,204);padding-left:1ex"><br>
Is there any interest in having enums as class constants?<br>
<br>
I&#39;m often finding cases where I would like to have an enum inside of a<=
br>
class, but don&#39;t want a free-floating enum that&#39;s basically like<br=
>
another class.<br>
<br></blockquote><div>=C2=A0</div><div>...&lt;snip&gt;...=C2=A0<br></div><d=
iv>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0p=
x 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
class SSHClient {<br>
<br>
=C2=A0 =C2=A0public const enum CommandResult<br>
=C2=A0 =C2=A0{<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0case Success;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0case Failure;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0case Unknown;<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0case Timeout;<br>
=C2=A0 =C2=A0}<br>
<br>
=C2=A0 =C2=A0// ...<br>
}<br>
<br>
<br>
// Usage:<br>
<br>
SSHClient::CommandResult::Success<br></blockquote><div><br></div><div><br><=
/div><div>I feel this topic could be maybe more broad and be called &quot;n=
ested classes&quot; that are already supported in multiple languages: Java,=
 Swift, Python, C#, C++, JavaScript, etc.</div><div><br></div><div>The synt=
ax you showed is usually identical with what other languages=C2=A0use, exce=
pt that probably the const is unnecessary.</div><div>The nested class can h=
ave visibility=C2=A0as sometimes having it private makes sense.</div><div>A=
ccessing it through `::` is probably fine, but a deeper look at the grammar=
 might be necessary.</div><div>The nested class would have access to parent=
=C2=A0class private properties and methods.</div><div><br></div><div>I also=
 mentioned this topic on the subject of defining a type in an autoloader co=
mpatible way.</div><div>And indeed, a type could also be defined nested in =
a class if we want to support that as well.</div><div><br></div><div>Now, t=
his feature is not simple, and I think it needs proper sponsorship from som=
eone experienced with internals.</div><div><br></div><div>Regards,</div><di=
v>Alex</div><div>=C2=A0</div></div></div>

--000000000000045e0e061fcb5b48--