Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124972
Precedence: bulk
MIME-Version: 1.0
References: <66BD5F05.8010409@adviesenzo.nl>
In-Reply-To: <66BD5F05.8010409@adviesenzo.nl>
Date: Fri, 16 Aug 2024 13:12:34 +0300
Message-ID: <CAAwdEzC86j=0TtOG4A2ygWiFzYmGU8ALb+4m5S2V0H4YUZfR6g@mail.gmail.com>
Subject: Re: [PHP-DEV] Should there be a `get_declared_enums()` function ?
To: Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000aee4eb061fca3378"
From: drealecs@gmail.com (=?UTF-8?Q?Alexandru_P=C4=83tr=C4=83nescu?=)

--000000000000aee4eb061fca3378
Content-Type: text/plain; charset="UTF-8"

Hey Juliette,


> Should a `get_declared_enums()` function be added ?
>

Yes

And should the `get_declared_classes()` function be adjusted to exclude
> enums ?
>

No

You listed these entities: classes, interfaces, traits and enums.
But while there is a clear differentiation between what is considered a
class, an interface or a trait, enums are just a subtype of classes.
"all enums are classes, but not all classes are enums."

So for keeping this valid, `get_declared_classes()` should return all
classes (including enums).
While `get_declared_enums()` should return all enums.

If one really wants all classes except enums, they could use `array_diff(
get_declared_classes(), get_declared_enums()`.
This would avoid the backward compatibility issues that Larry also
mentioned.

Regards,
Alex

--000000000000aee4eb061fca3378
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hey=C2=A0Juliette,</div><div class=3D"gmail_quote"><d=
iv>=C2=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0p=
x 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div bgcol=
or=3D"#FFFFFF"><font size=3D"-1"><font face=3D"Verdana">Should a `</font></=
font><font size=3D"-1"><font face=3D"Verdana"><font size=3D"-1"><font face=
=3D"Verdana">get_declared_enums()</font></font>`
        function be added ?<br></font></font></div></blockquote><div><br></=
div><div>Yes=C2=A0</div><div><br></div><blockquote class=3D"gmail_quote" st=
yle=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padd=
ing-left:1ex"><div bgcolor=3D"#FFFFFF"><font size=3D"-1"><font face=3D"Verd=
ana">
        And should the `get_declared_classes()` function be adjusted to
        exclude enums ?<br></font></font></div></blockquote><div><br></div>=
<div>No</div><div><br></div><div>You listed these entities: classes, interf=
aces, traits and enums.</div><div>But while there is a clear=20

differentiation

between what is considered a class, an interface or a trait, enums are just=
 a subtype of classes.</div><div>&quot;all enums are classes, but not all c=
lasses are enums.&quot;</div><div><br></div><div>So for keeping this valid,=
=C2=A0<span style=3D"font-family:Verdana">`get_declared_classes()`</span>=
=C2=A0should=C2=A0return all classes (including enums).</div><div>While=C2=
=A0<font size=3D"-1"><font face=3D"Verdana">`</font></font><font size=3D"-1=
"><font face=3D"Verdana"><font size=3D"-1"><font face=3D"Verdana">get_decla=
red_enums()</font></font>`</font></font>=C2=A0should return all enums.</div=
><div><br></div><div>If one really wants all classes except enums, they cou=
ld use=C2=A0<span style=3D"font-family:Verdana">`</span>array_diff(<span st=
yle=3D"font-family:Verdana">get_declared_classes(),=C2=A0</span><span style=
=3D"font-family:Verdana">get_declared_enums()</span><span style=3D"font-fam=
ily:Verdana">`</span>.</div><div>This would avoid the backward compatibilit=
y issues that Larry also mentioned.</div><div><br></div><div>Regards,</div>=
<div>Alex</div><div>=C2=A0</div></div></div>

--000000000000aee4eb061fca3378--