Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124969
Subject: Re: [PHP-DEV] Should there be a `get_declared_enums()` function ?
To: internals@lists.php.net
References: <66BD5F05.8010409@adviesenzo.nl>
 <87fc9033-b0cc-423a-bcb6-8cef287a8ee6@app.fastmail.com>
Message-ID: <66BED43A.2010504@adviesenzo.nl>
Date: Fri, 16 Aug 2024 06:23:22 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <87fc9033-b0cc-423a-bcb6-8cef287a8ee6@app.fastmail.com>
Content-Type: multipart/alternative;
 boundary="------------070209060804060105070000"
From: php-internals_nospam@adviesenzo.nl (Juliette Reinders Folmer)

This is a multi-part message in MIME format.
--------------070209060804060105070000
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit

On 15-8-2024 15:09, Larry Garfield wrote:
> On Wed, Aug 14, 2024, at 8:51 PM, Juliette Reinders Folmer wrote:
>> L.S.,
>>
>> I just noticed the following, which struck me as weird/inconsistent:
>>
>> There are four different OO structures in PHP:
>> 1. Classes
>> 2. Interfaces
>> 3. Traits
>> 4. Enums
>>
>> For all four, an `*_exists()` function is available, i.e.
>> `class_exists()`, `interface_exists()`, `trait_exists()` and
>> `enum_exists()` [2].
>>
>> But only for three out of the four, a `get_declared_*()` function
>> exists.
>> There is `get_declared_classes()`, `get_declared_interfaces()`,
>> `get_declared_traits()`, but no `get_declared_enums()` [2].
>>
>> I'm aware that enums are internally considered classes and that
>> `get_declared_classes()` will retrieve them [1], but the same could be
>> said about interfaces and traits, yet they do have their own
>> `get_declared_*()` function.
>>
>> Should a `get_declared_enums()` function be added ?
>> And should the `get_declared_classes()` function be adjusted to exclude enums ?
>>
>> I did check the enum RFC [3], but I couldn't find any mention or
>> discussion about this in the RFC.
>>
>> Smile,
>> Juliette
>>
>>
>> 1: https://3v4l.org/0ub6I
>> 2: https://www.php.net/manual/en/ref.classobj.php
>> 3: https://wiki.php.net/rfc/enumerations
> Conext: I can't remember the last time I used get_declared_classes() (thanks to autoloading and class_exists() it's a kinda pointless function), so when we were working on enums it never occurred to us to think about it.  It wasn't a deliberate decision to omit, as far as I recall.
>
> I think I'd be open to adding it; my concern would be the overlap with get_declared_classes(), which as you note currently would include enums, and changing that is a BC break (even if a tiny one that I doubt would impact anyone).
>
> --Larry Garfield
>

Thanks for the response. It was exactly a (custom) autoloader situation 
which caused me to start wondering about this.


--------------070209060804060105070000
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">On 15-8-2024 15:09, Larry Garfield
      wrote:<br>
    </div>
    <blockquote
      cite="mid:87fc9033-b0cc-423a-bcb6-8cef287a8ee6@app.fastmail.com"
      type="cite">
      <pre wrap="">On Wed, Aug 14, 2024, at 8:51 PM, Juliette Reinders Folmer wrote:
</pre>
      <blockquote type="cite">
        <pre wrap="">L.S.,

I just noticed the following, which struck me as weird/inconsistent:

There are four different OO structures in PHP:
1. Classes
2. Interfaces
3. Traits
4. Enums

For all four, an `*_exists()` function is available, i.e. 
`class_exists()`, `interface_exists()`, `trait_exists()` and 
`enum_exists()` [2].

But only for three out of the four, a `get_declared_*()` function 
exists.
There is `get_declared_classes()`, `get_declared_interfaces()`, 
`get_declared_traits()`, but no `get_declared_enums()` [2].

I'm aware that enums are internally considered classes and that 
`get_declared_classes()` will retrieve them [1], but the same could be 
said about interfaces and traits, yet they do have their own 
`get_declared_*()` function.

Should a `get_declared_enums()` function be added ?
And should the `get_declared_classes()` function be adjusted to exclude enums ?

I did check the enum RFC [3], but I couldn't find any mention or 
discussion about this in the RFC.

Smile,
Juliette


1: <a class="moz-txt-link-freetext" href="https://3v4l.org/0ub6I">https://3v4l.org/0ub6I</a>
2: <a class="moz-txt-link-freetext" href="https://www.php.net/manual/en/ref.classobj.php">https://www.php.net/manual/en/ref.classobj.php</a>
3: <a class="moz-txt-link-freetext" href="https://wiki.php.net/rfc/enumerations">https://wiki.php.net/rfc/enumerations</a>
</pre>
      </blockquote>
      <pre wrap="">
Conext: I can't remember the last time I used get_declared_classes() (thanks to autoloading and class_exists() it's a kinda pointless function), so when we were working on enums it never occurred to us to think about it.  It wasn't a deliberate decision to omit, as far as I recall.

I think I'd be open to adding it; my concern would be the overlap with get_declared_classes(), which as you note currently would include enums, and changing that is a BC break (even if a tiny one that I doubt would impact anyone).

--Larry Garfield

</pre>
    </blockquote>
    <br>
    Thanks for the response. It was exactly a (custom) autoloader
    situation which caused me to start wondering about this.<br>
    <br>
  </body>
</html>

--------------070209060804060105070000--