Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124960
Feedback-ID: ifab94697:Fastmail
Precedence: bulk
MIME-Version: 1.0
Date: Thu, 15 Aug 2024 23:31:50 +0200
To: "Stephen Reay" <php-lists@koalephant.com>
Cc: internals@lists.php.net
Message-ID: <a897e9e9-dcc7-47f9-86db-c3c15294046a@app.fastmail.com>
In-Reply-To: <845F3549-B1D7-408B-86A5-DE4CA6FE97BD@koalephant.com>
References: <2716f729-4008-4f75-8412-861d8960b746@app.fastmail.com>
 <845F3549-B1D7-408B-86A5-DE4CA6FE97BD@koalephant.com>
Subject: Re: [PHP-DEV] function autoloading v4 RFC
Content-Type: multipart/alternative;
 boundary=501da94a38434184991b18d5c00178a3
From: rob@bottled.codes ("Rob Landers")

--501da94a38434184991b18d5c00178a3
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 15, 2024, at 18:18, Stephen Reay wrote:
>=20
>=20
>> On 15 Aug 2024, at 22:22, Rob Landers <rob@bottled.codes> wrote:
>>=20
>> Hello internals,
>>=20
>> I've decided to attempt an RFC for function autoloading. After readin=
g hundreds of ancient (and recent) emails relating to the topic along wi=
th several abandoned RFCs from the past, and after much review, I've dec=
ided to put forth a variation of a previous RFC, as it seemed the least =
ambitious and the most likely to work:
>>=20
>> https://wiki.php.net/rfc/function_autoloading4
>>=20
>> Please let me know what you think. An implementation should be along =
before opening it for a vote (now that I realize how important that is).
>>=20
>> =E2=80=94 Rob
>=20
> Hi Rob,
>=20
> I like the simplicity of this, however your RFC doesn't document the c=
hanges required to `spl_autoload`[1] to allow it to keep working with th=
is new functionality.

Ah, good catch. I've updated this and gone through other relevant functi=
ons.

>=20
> The same issue (unexpected additional argument) potentially affects us=
erland autoloaders too, but obviously the individual authors can fix tha=
t themselves (whether this would count as a BC break is not immediately =
clear to me)

Userland functions don't throw that error, so it shouldn't be an issue. =
(You can pass as many arguments as you want to a userland function, as l=
ong as there are enough of them).

>=20
>=20
> Slightly tangentially, you may also want to look at a change to `spl_a=
utoload_call` to accept a `SPL_AUTOLOAD_*` argument, so that it works co=
nsistently.

Done.

Thank you Stephen for pointing out this oversight.

>=20
> Cheers
>=20
> Stephen
>=20
> 1: https://www.php.net/spl_autoload
>=20

=E2=80=94 Rob
--501da94a38434184991b18d5c00178a3
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}=0Ap.MsoNormal,p.MsoNoSpacing{margin:0}</=
style></head><body><div>On Thu, Aug 15, 2024, at 18:18, Stephen Reay wro=
te:<br></div><blockquote type=3D"cite" id=3D"qt" style=3D"overflow-wrap:=
break-word;"><div><br></div><div><div><br></div><blockquote type=3D"cite=
"><div>On 15 Aug 2024, at 22:22, Rob Landers &lt;rob@bottled.codes&gt; w=
rote:<br></div><div><br></div><div><div style=3D"font-family:Helvetica;f=
ont-size:12px;font-style:normal;font-variant-caps:normal;font-weight:400=
;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:n=
one;text-wrap:wrap;word-spacing:0px;-webkit-text-stroke-width:0px;text-d=
ecoration-line:none;text-decoration-thickness:initial;text-decoration-st=
yle:initial;text-decoration-color:initial;">Hello internals,<br></div><d=
iv style=3D"font-family:Helvetica;font-size:12px;font-style:normal;font-=
variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:sta=
rt;text-indent:0px;text-transform:none;text-wrap:wrap;word-spacing:0px;-=
webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-t=
hickness:initial;text-decoration-style:initial;text-decoration-color:ini=
tial;"><br></div><div style=3D"font-family:Helvetica;font-size:12px;font=
-style:normal;font-variant-caps:normal;font-weight:400;letter-spacing:no=
rmal;text-align:start;text-indent:0px;text-transform:none;text-wrap:wrap=
;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:non=
e;text-decoration-thickness:initial;text-decoration-style:initial;text-d=
ecoration-color:initial;">I've decided to attempt an RFC for function au=
toloading. After reading hundreds of ancient (and recent) emails relatin=
g to the topic along with several abandoned RFCs from the past, and afte=
r much review, I've decided to put forth a variation of a previous RFC, =
as it seemed the least ambitious and the most likely to work:<br></div><=
div style=3D"font-family:Helvetica;font-size:12px;font-style:normal;font=
-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:st=
art;text-indent:0px;text-transform:none;text-wrap:wrap;word-spacing:0px;=
-webkit-text-stroke-width:0px;text-decoration-line:none;text-decoration-=
thickness:initial;text-decoration-style:initial;text-decoration-color:in=
itial;"><br></div><div style=3D"font-family:Helvetica;font-size:12px;fon=
t-style:normal;font-variant-caps:normal;font-weight:400;letter-spacing:n=
ormal;text-align:start;text-indent:0px;text-transform:none;text-wrap:wra=
p;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line:no=
ne;text-decoration-thickness:initial;text-decoration-style:initial;text-=
decoration-color:initial;"><a href=3D"https://wiki.php.net/rfc/function_=
autoloading4">https://wiki.php.net/rfc/function_autoloading4</a><br></di=
v><div style=3D"font-family:Helvetica;font-size:12px;font-style:normal;f=
ont-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align=
:start;text-indent:0px;text-transform:none;text-wrap:wrap;word-spacing:0=
px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-decorati=
on-thickness:initial;text-decoration-style:initial;text-decoration-color=
:initial;"><br></div><div style=3D"font-family:Helvetica;font-size:12px;=
font-style:normal;font-variant-caps:normal;font-weight:400;letter-spacin=
g:normal;text-align:start;text-indent:0px;text-transform:none;text-wrap:=
wrap;word-spacing:0px;-webkit-text-stroke-width:0px;text-decoration-line=
:none;text-decoration-thickness:initial;text-decoration-style:initial;te=
xt-decoration-color:initial;">Please let me know what you think. An impl=
ementation should be along before opening it for a vote (now that I real=
ize how important that is).<br></div><div style=3D"font-family:Helvetica=
;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:4=
00;letter-spacing:normal;text-align:start;text-indent:0px;text-transform=
:none;text-wrap:wrap;word-spacing:0px;-webkit-text-stroke-width:0px;text=
-decoration-line:none;text-decoration-thickness:initial;text-decoration-=
style:initial;text-decoration-color:initial;"><br></div><div id=3D"qt-si=
g121229152" style=3D"font-family:Helvetica;font-size:12px;font-style:nor=
mal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-=
align:start;text-indent:0px;text-transform:none;text-wrap:wrap;word-spac=
ing:0px;-webkit-text-stroke-width:0px;text-decoration-line:none;text-dec=
oration-thickness:initial;text-decoration-style:initial;text-decoration-=
color:initial;">=E2=80=94 Rob<br></div></div></blockquote></div><div><br=
></div><div>Hi Rob,<br></div><div><br></div><div>I like the simplicity o=
f this, however your RFC doesn't document the changes required to `spl_a=
utoload`[1] to allow it to keep working with this new functionality.<br>=
</div></blockquote><div><br></div><div>Ah, good catch. I've updated this=
 and gone through other relevant functions.<br></div><div><br></div><blo=
ckquote type=3D"cite" id=3D"qt" style=3D"overflow-wrap:break-word;"><div=
><br></div><div>The same issue (unexpected additional argument) potentia=
lly affects userland autoloaders too, but obviously the individual autho=
rs can fix that themselves (whether this would count as a BC break is no=
t immediately clear to me)<br></div></blockquote><div><br></div><div>Use=
rland functions don't throw that error, so it shouldn't be an issue. (Yo=
u can pass as many arguments as you want to a userland function, as long=
 as there are enough of them).<br></div><div><br></div><blockquote type=3D=
"cite" id=3D"qt" style=3D"overflow-wrap:break-word;"><div><br></div><div=
><br></div><div>Slightly tangentially, you may also want to look at a ch=
ange to `spl_autoload_call` to accept a `SPL_AUTOLOAD_*` argument, so th=
at it works consistently.<br></div></blockquote><div><br></div><div>Done=
.<br></div><div><br></div><div>Thank you Stephen for pointing out this o=
versight.</div><div><br></div><blockquote type=3D"cite" id=3D"qt" style=3D=
"overflow-wrap:break-word;"><div><br></div><div>Cheers<br></div><div><br=
></div><div>Stephen<br></div><div><br></div><div>1:&nbsp;<a href=3D"http=
s://www.php.net/spl_autoload">https://www.php.net/spl_autoload</a><br></=
div><div><br></div></blockquote><div><br></div><div id=3D"sig121229152">=
=E2=80=94 Rob<br></div></body></html>
--501da94a38434184991b18d5c00178a3--