Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124873
Subject: Re: [PHP-DEV] Updates needed to various RFCs
To: "Christoph M. Becker" <cmbecker69@gmx.de>,
 "internals@lists.php.net >> PHP internals" <internals@lists.php.net>
References: <66B854C7.5010904@adviesenzo.nl>
 <068b201a-6fd8-4b54-aa01-a1267a7bd7c3@gmx.de>
Message-ID: <66B91D4C.7070002@adviesenzo.nl>
Date: Sun, 11 Aug 2024 22:21:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.7.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <068b201a-6fd8-4b54-aa01-a1267a7bd7c3@gmx.de>
Content-Type: multipart/alternative;
 boundary="------------000208000002000606090500"
From: php-internals_nospam@adviesenzo.nl (Juliette Reinders Folmer)

This is a multi-part message in MIME format.
--------------000208000002000606090500
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit


On 11-8-2024 18:55, Christoph M. Becker wrote:
> On 11.08.2024 at 08:05, Juliette Reinders Folmer wrote:
>
>> I'm currently going through the RFC wiki page and I'm seeing various
>> (PHP 8.4) RFCs which haven't been properly updated after the vote.
>>
>> I've not gone through all of the RFCs, but these are definitely some
>> which I'd like to flag for attention:
>> - https://wiki.php.net/rfc/adding_bcround_bcfloor_bcceil_to_bcmath
>> - https://wiki.php.net/rfc/grapheme_str_split
>> - https://wiki.php.net/rfc/unbundle_imap_pspell_oci8
>> - https://wiki.php.net/rfc/raising_zero_to_power_of_negative_number
> Thanks for reporting!
>
> I've fixed up the first two, but I haven't yet found the PRs regarding
> the extension unbundling, and I'm unsure about the implementation of the
> last RFC; the implementation section has PR #13128, but mentions
> "without fpow yet".

Thanks Christoph! I was tempted to update the RFCs myself, but thought 
it was against protocol for anyone but the RFC owner to do so ? hence my 
email.

  If you need links to PRs/commits, I've got them, as I've been looking 
them up for the initial PHPCompatibility package updates.

For fpow(), these are the relevant ones (and include the fpow() function 
in contrast to the text in the PR description - PR was updated after it 
was originally pulled):
PR: php/php-src#13128
Commit: 
https://github.com/php/php-src/commit/23afe57f01e0915eef246eba60e60fda74fd2dcf

Smile,
Juliette

--------------000208000002000606090500
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <br>
    <div class="moz-cite-prefix">On 11-8-2024 18:55, Christoph M. Becker
      wrote:<br>
    </div>
    <blockquote cite="mid:068b201a-6fd8-4b54-aa01-a1267a7bd7c3@gmx.de"
      type="cite">
      <pre wrap="">On 11.08.2024 at 08:05, Juliette Reinders Folmer wrote:

</pre>
      <blockquote type="cite">
        <pre wrap="">I'm currently going through the RFC wiki page and I'm seeing various
(PHP 8.4) RFCs which haven't been properly updated after the vote.

I've not gone through all of the RFCs, but these are definitely some
which I'd like to flag for attention:
- <a class="moz-txt-link-freetext" href="https://wiki.php.net/rfc/adding_bcround_bcfloor_bcceil_to_bcmath">https://wiki.php.net/rfc/adding_bcround_bcfloor_bcceil_to_bcmath</a>
- <a class="moz-txt-link-freetext" href="https://wiki.php.net/rfc/grapheme_str_split">https://wiki.php.net/rfc/grapheme_str_split</a>
- <a class="moz-txt-link-freetext" href="https://wiki.php.net/rfc/unbundle_imap_pspell_oci8">https://wiki.php.net/rfc/unbundle_imap_pspell_oci8</a>
- <a class="moz-txt-link-freetext" href="https://wiki.php.net/rfc/raising_zero_to_power_of_negative_number">https://wiki.php.net/rfc/raising_zero_to_power_of_negative_number</a>
</pre>
      </blockquote>
      <pre wrap="">
Thanks for reporting!

I've fixed up the first two, but I haven't yet found the PRs regarding
the extension unbundling, and I'm unsure about the implementation of the
last RFC; the implementation section has PR #13128, but mentions
"without fpow yet".
</pre>
    </blockquote>
    <br>
    Thanks Christoph! I was tempted to update the RFCs myself, but
    thought it was against protocol for anyone but the RFC owner to do
    so ? hence my email.<br>
    <br>
     If you need links to PRs/commits, I've got them, as I've been
    looking them up for the initial PHPCompatibility package updates.<br>
    <br>
    For fpow(), these are the relevant ones (and include the fpow()
    function in contrast to the text in the PR description - PR was
    updated after it was originally pulled):<br>
    PR: php/php-src#13128<br>
    Commit:
<a class="moz-txt-link-freetext" href="https://github.com/php/php-src/commit/23afe57f01e0915eef246eba60e60fda74fd2dcf">https://github.com/php/php-src/commit/23afe57f01e0915eef246eba60e60fda74fd2dcf</a><br>
    <br>
    Smile,<br>
    Juliette<br>
  </body>
</html>

--------------000208000002000606090500--