Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124792
Precedence: bulk
MIME-Version: 1.0 (Mimestream 1.3.7)
References: <WAN6ETlWt7JfcVoyeYfY_F_eLE6WzQa87F7yi8SHISmyktMYx7YcA6oG5dis3gFeI36VBjSfjGw4AT6psFFDXEUNRrvKRRn4LxfdCxFBccw=@gpb.moe>
In-Reply-To: <WAN6ETlWt7JfcVoyeYfY_F_eLE6WzQa87F7yi8SHISmyktMYx7YcA6oG5dis3gFeI36VBjSfjGw4AT6psFFDXEUNRrvKRRn4LxfdCxFBccw=@gpb.moe>
Date: Tue, 6 Aug 2024 03:43:21 -0400
Message-ID: <CAEPJdu=oekuHpgKknLt8cESzL4WUn6BS3u19xUxoP861foNF6A@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [VOTE] Transform exit() from a language construct
 into a standard function
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ad43d8061efef2a3"
From: kontakt@beberlei.de (=?UTF-8?Q?Benjamin_Au=C3=9Fenhofer?=)

--000000000000ad43d8061efef2a3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Am 30.07.2024, 11:49:52 schrieb Gina P. Banyard <internals@gpb.moe>:

> Hello Internals,
>
> I have just opened the vote for the "Transform exit() from a language
> construct into a standard function" RFC:
> https://wiki.php.net/rfc/exit-as-function
>
> The vote will last for two weeks until the 13th of August 2024.
>
> Best regards,
>
> Gina P. Banyard
>

Hi Gina,

I was ambivalent to this before, but after reading the discussion, voted no
for two reasons:


   - exit without parenthesis s still not a function, that does not makes
   handling this on extension level (tools, profilers) more reliable, inste=
ad
   more confusing. I don=E2=80=99t mind the work this might cause for an ex=
tension, so
   i don=E2=80=99t join Christoph=E2=80=99s and Derick=E2=80=99s argument h=
ere that this a break for
   extensions that disqualifies the change.
   - If it still does not allow me to set exit as disabled_functions, then
   this creates an inconsistency


I also have a question: From a userland perspective, it looks it creates
inconsistency calling exit with global namespace prefix, depending on
parenthesis or? \exit(); will now work, but \exit; will not?

Also if https://github.com/php/php-src/pull/4084 taught me anything, trying
to add eval support for disabled_functions, then maybe we should throw
warnings instead when using that ini setting to disable op codes, instead
of silently ignoring that this won=E2=80=99t work.

--000000000000ad43d8061efef2a3
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<html><body><div dir=3D"ltr">
    <br>
</div>
<br>
<div class=3D"gmail_quote">
    <div dir=3D"ltr" class=3D"gmail_attr">Am 30.07.2024, 11:49:52 schrieb G=
ina P. Banyard &lt;internals@gpb.moe&gt;:<br></div>
    <blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bor=
der-left:1px solid rgb(204,204,204);padding-left:1ex" type=3D"cite">
       =20
<div>
<div>
    Hello Internals,<br><br>I have just opened the vote for the &quot;Trans=
form exit() from a language construct into a standard function&quot; RFC:<b=
r><a href=3D"https://wiki.php.net/rfc/exit-as-function">https://wiki.php.ne=
t/rfc/exit-as-function</a><br><br>The vote will last for two weeks until th=
e 13th of August 2024.<br><br>Best regards,<br><br>Gina P. Banyard<br>
</div>
</div>
    </blockquote><br>
</div><div class=3D"gmail_quote"><div class=3D"gmail_quote" dir=3D"ltr">Hi =
Gina,</div><div class=3D"gmail_quote" dir=3D"ltr"><br></div><div class=3D"g=
mail_quote" dir=3D"ltr">I was ambivalent to this before, but after reading =
the discussion, voted no for two reasons:</div><div class=3D"gmail_quote" d=
ir=3D"ltr"><br></div><div class=3D"gmail_quote" dir=3D"ltr"><ul dir=3D"ltr"=
 style=3D"margin:0px"><li>exit without parenthesis s still not a function, =
that does not makes handling this on extension level (tools, profilers) mor=
e reliable, instead more confusing. I don=E2=80=99t mind the work this migh=
t cause for an extension, so i don=E2=80=99t join Christoph=E2=80=99s and D=
erick=E2=80=99s argument here that this a break for extensions that disqual=
ifies the change.</li><li>If it still does not allow me to set exit as disa=
bled_functions, then this creates an inconsistency</li></ul><div><br></div>=
<div dir=3D"ltr">I also have a question: From a userland perspective, it lo=
oks it creates inconsistency calling exit with global namespace prefix, dep=
ending on parenthesis or? \exit(); will now work, but \exit; will not?</div=
><div dir=3D"ltr"><br></div><div dir=3D"ltr">Also if=C2=A0<a href=3D"https:=
//github.com/php/php-src/pull/4084">https://github.com/php/php-src/pull/408=
4</a>=C2=A0taught me anything, trying to add eval support for disabled_func=
tions, then maybe we should throw warnings instead when using that ini sett=
ing to disable op codes, instead of silently ignoring that this won=E2=80=
=99t work.</div></div></div></body></html>

--000000000000ad43d8061efef2a3--