Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124790
Message-ID: <b5058a7e-b5bc-4fae-b4a2-ef7ead311c39@gmx.de>
Date: Tue, 6 Aug 2024 00:55:48 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] [VOTE] Transform exit() from a
 languageconstructinto a standard function
Content-Language: de-DE
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>,
 Derick Rethans <derick@php.net>, PHP internals <internals@lists.php.net>
References: <WAN6ETlWt7JfcVoyeYfY_F_eLE6WzQa87F7yi8SHISmyktMYx7YcA6oG5dis3gFeI36VBjSfjGw4AT6psFFDXEUNRrvKRRn4LxfdCxFBccw=@gpb.moe>
 <15bb76a0-cbd7-4145-b429-76d424755106@gmx.de>
 <1a8650d2-7eb5-d645-8132-e5522ad24637@php.net>
 <06ba1d82-6387-46ac-8be3-1d3472993e1a@gmx.de>
 <a2cf19e2-4c42-42a1-b060-205b782252c8@bastelstu.be>
 <e7baad83-9604-4693-aa51-b1148722f750@gmx.de>
 <LrQv9MxcBzy8z0lmKDxDhL-13Ull8cRO5GHlJR9DNMcagZB6XllEot2MdMnC-K31pTCRyfkgLtksJl_UyLKktUmOXgK5VdpPbs2ES3U7PmI=@gpb.moe>
In-Reply-To: <LrQv9MxcBzy8z0lmKDxDhL-13Ull8cRO5GHlJR9DNMcagZB6XllEot2MdMnC-K31pTCRyfkgLtksJl_UyLKktUmOXgK5VdpPbs2ES3U7PmI=@gpb.moe>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:A2NxilRD1oM=;3tOlbFhNtgD0Wm3/8b5A6192l+x
 7CHoquWOqAKdu3TyoB8Hw6PxRTd+jYY0heZdOy/a8mf9sFPSO4uOrQCTrIP+Etq8LAC5MVVTN
 IGfvlfgUralyFvrtiMZTDhpTInKFuL1objSymxP88hx4zOH6cwIdfySZ1dWbKqJGy+a2Y1ZO4
 peYhlb6SjbArYxzQK936KHD9kLcdSiFIZd5RmyxkCQ8pEkTGEuGXe6yTJkXqw9TzSmoNLnDKn
 Cdzh99L9ELz4fLv6IOEfqjx06VItBnt9CkvRXXBsxKi6833wzigaQGBOV8W38+ss+QNr9NZQl
 DrXYL/DlblxNy9aq1aX5CuVhsPUGncyFCtvrZEkVKUHVnu0V13C5tWFmqyBTZ+soRmseBXrQ6
 kXg0UHiDqZDNfbOzBrkYscSC4CrGup6mm2BBpwKUnruPkXMUxyT6jHTzHt7wTjQl3rfFYOc+J
 wXcUlLr0mgMFh4VOhI58Omx5gRI+kocWl+yqxtgL5V24oWsRUv+9cSaiwWegUlkl/+1IBfoyI
 RI1E669eFLo7baJkiM3gfHYibBQKyBmsQ5DhSH/bWIhWKsrZjhA5zr6LLbPrFX2BJLiFkFSZo
 o13x5mlfgN9zsVd6ZJjzauwnRkgfdia4dYY1swP+WGP0HxrGdkuObD1pQ6MNdztnXAL+Of59n
 okIjgtBXnft9PkMvm/kE4wYPE/6qkDGNuRvWIfACcHx2Eg6Z2nynaddWHUQ3AZfywjvhCMyGo
 imOSZjAcmT6m0T0Y3mGzRRGwN8gBXQDmvN50Jh0NGb5iFBKcqyCvvOAXVznwQGOWChVdS6rIM
 IvjZHn+Hb4H0JWGgSYe4sPj7pOxl6KKmlYsOQrLtDPCao=
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 05.08.2024 at 21:37, Gina P. Banyard wrote:

> This sounds like a uopz extension issue that is easily fixed.

Most likely, yes, although still somebody has to provide a fix, and
someone has to do a new release.

> I am not sure why we should bend over backwards for extensions that allo=
w to break usual userland semantics while preventing userland behaviour to=
 be better.

We shouldn't do one or the other without having weighted the pros and
cons.  So what are the pros regarding improved userland behavior:

* we can use named arguments

So we can now write `exit(status =3D 1)` or `exit(status =3D "some error
message`).  I don't see any improvement using named arguments for a
single argument function (maybe unless it is a boolean argument).  And
for a string argument, I don't think that `status` is a sensible
parameter name here.

* pass to functions as callable

That might be a nice feature, but at least I have never seen the need to
pass `exit` as callable.  And it wouldn't be hard to define a wrapper
function (e.g. `my_exit()`) if someone really needs to pass it as a
callable.

* does not respect strict_types and does not follow usual type juggling
semantics

That *might* be an issue (although I've never stumbled upon that), but
it seems to me that this could even be handled in the ZEND_EXIT handler.

Perhaps I've missed some pros, but it seems these have been the ones the
RFC explicitly mentions.

So, what are the cons:

* removing the ZEND_EXIT opcode

That immediately breaks any extension using it.  A quick Github search
lists 3.1 k occurrences[1].

* making exit a "proper" function

It still can be called without parentheses, so I don't regard it as a
proper function.  It *might* even be confusing to readers ("oh, now I
can call a function without arguments by omitting the parentheses =E2=80=
=93 but
why doesn't it work for other functions?").  And the PHP manual even
states (emphasis mine):

| exit is a *language* *construct* and it can be called without
| parentheses if no status is passed.

Weighting the pros and cons is left as an exercise to the reader.

[1] <https://github.com/search?q=3DZEND_EXIT&type=3Dcode>

Thanks,
Christoph