Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124788
Date: Mon, 05 Aug 2024 19:37:51 +0000
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: =?utf-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>, Derick Rethans <derick@php.net>, PHP internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [VOTE] Transform exit() from a languageconstructinto a standard function
Message-ID: <LrQv9MxcBzy8z0lmKDxDhL-13Ull8cRO5GHlJR9DNMcagZB6XllEot2MdMnC-K31pTCRyfkgLtksJl_UyLKktUmOXgK5VdpPbs2ES3U7PmI=@gpb.moe>
In-Reply-To: <e7baad83-9604-4693-aa51-b1148722f750@gmx.de>
References: <WAN6ETlWt7JfcVoyeYfY_F_eLE6WzQa87F7yi8SHISmyktMYx7YcA6oG5dis3gFeI36VBjSfjGw4AT6psFFDXEUNRrvKRRn4LxfdCxFBccw=@gpb.moe> <15bb76a0-cbd7-4145-b429-76d424755106@gmx.de> <1a8650d2-7eb5-d645-8132-e5522ad24637@php.net> <06ba1d82-6387-46ac-8be3-1d3472993e1a@gmx.de> <a2cf19e2-4c42-42a1-b060-205b782252c8@bastelstu.be> <e7baad83-9604-4693-aa51-b1148722f750@gmx.de>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Monday, 5 August 2024 at 18:30, Christoph M. Becker <cmbecker69@gmx.de> =
wrote:

> On 05.08.2024 at 18:52, Tim D=C3=BCsterhus wrote:
>=20
> > On 8/5/24 14:52, Christoph M. Becker wrote:
> >=20
> > > Hmm, so far I only had skimmed the RFC and the related discussions, b=
ut
> > > now I checked out the suggested implementation[1]. Then I tried to
> > > build with PECL/uopz, and of course that failed because ZEND_EXIT is =
no
> > > longer there. Okay, quickly drop that usage; build succeeds. Then I r=
an
> > >=20
> > > <?php
> > > uopz_set_return("exit", function () {echo "hello";}, true);
> > > exit;
> > > ?>
> > >=20
> > > And got
> > >=20
> > > hello
> > >=20
> > > Previously, no output was echoed. While that seems to be fixable in
> >=20
> > Frankly from a userland developer PoV this looks entirely correct: If I
> > override the `exit()` function, then I expect the `exit()` function to
> > be overridden.
>=20
>=20
> I should have clarified, that "fixing" means to restore the expected
> behavior of uopz, namely that accidential attempts to override exit with
> `uopz_set_return()` were silently ignored, but unless `uopz.exit=3D1` is
> set, or `uopz_allow_exit(true)` is called, exit is ignored. Especially
> the latter may be relied upon by tests for legacy code.
>=20
> Christoph

This sounds like a uopz extension issue that is easily fixed.
I am not sure why we should bend over backwards for extensions that allow t=
o break usual userland semantics while preventing userland behaviour to be =
better.


Best regards,

Gina P. Banyard