Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124786
Date: Mon, 05 Aug 2024 19:34:20 +0000
To: Derick Rethans <derick@php.net>
Cc: "Christoph M. Becker" <cmbecker69@gmx.de>, PHP internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] [RFC] [VOTE] Transform exit() from a language construct into a standard function
Message-ID: <eqSxzgF0uqWBxKtKGHBytB97NyjPNwhtKLN_uN72b3GY6yR8XLuQVlBN_l4htCUab2hTKF3QAOZ1YQ0Ol5OhvO4xpzBMpb45OdXNfsOi0gk=@gpb.moe>
In-Reply-To: <1a8650d2-7eb5-d645-8132-e5522ad24637@php.net>
References: <WAN6ETlWt7JfcVoyeYfY_F_eLE6WzQa87F7yi8SHISmyktMYx7YcA6oG5dis3gFeI36VBjSfjGw4AT6psFFDXEUNRrvKRRn4LxfdCxFBccw=@gpb.moe> <15bb76a0-cbd7-4145-b429-76d424755106@gmx.de> <1a8650d2-7eb5-d645-8132-e5522ad24637@php.net>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Monday, 5 August 2024 at 12:04, Derick Rethans <derick@php.net> wrote:

> On Tue, 30 Jul 2024, Christoph M. Becker wrote:
>=20
> > On 30.07.2024 at 11:49, Gina P. Banyard wrote:
> >=20
> > > I have just opened the vote for the "Transform exit() from a
> > > language construct into a standard function" RFC:
> > > https://wiki.php.net/rfc/exit-as-function
> > >=20
> > > The vote will last for two weeks until the 13th of August 2024.
> >=20
> > As userland PHP developer, I always regarded `exit` as a control flow
> > instruction (quite similar to `break`), and as such I'm not really in
> > favor of converting it to a proper function (especially since it is
> > not, because the parantheses could be omitted).
>=20
>=20
> Xdebug uses exit for exactly that too. For control flow analysis. And I
> also always have considered it to be a control flow instruction.
>=20
> I see no benefit in changing it to a function, especially because
> there will never be a function "exit" from it, just only an "entry".
> This breaks function execution symmetry (and causes issues with Xdebug
> when I last tried to make it work with a development branch for this
> RFC).
>=20
> As the RFC is scarce on mitigations for this, I am currently voting "no"
> as I am unsure how certain features in Xdebug could remain working. I
> have written to the list on other reasons before
> (https://externals.io/message/123277#123450) without a conclusion.
>=20
> I'll consider changing it to yes if there is a commitment for addressing
> these feature-maintaining-requirements to keep Xdebug working, either
> through new APIs (think observer) or other mitigations.
>=20
> cheers,
> Derick
>=20
> --
> https://derickrethans.nl | https://xdebug.org | https://dram.io
>=20
> Author of Xdebug. Like it? Consider supporting me: https://xdebug.org/sup=
port
>=20
> mastodon: @derickr@phpc.social @xdebug@phpc.social

I still do not comprehend your issue.
You can either do stuff at compile time, which has been explained before, o=
r use the function call observer for anything runtime related.
The behaviour of exit() is completely observable with the current observer =
framework, so I don't see why anything else needs to be done.


Best regards,

Gina P. Banyard