Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124784
Precedence: bulk
MIME-Version: 1.0
References: <USzt7tZZlO1DmAbSTLhD-bqa23FqZn0zk2aah8Ndxgk9c7RY5PefQ8MjbYPUYAzr2_m4Cf-5AI4PuNBTS84rim_FNS6RaT-cWSv714HEvvU=@gpb.moe>
 <1a88918e-e808-d778-45e1-53797660e093@php.net> <CAPrKfG5Cw_nU7g7FR+t4C1-YZ8CDsDO_-sRs=yEsHO5kCTZL+A@mail.gmail.com>
 <c03eb187-bd21-4a4b-9faf-8d0243eaa994@varteg.nz> <aa6bc7aa-28d9-40ca-974f-65075adb6199@rwec.co.uk>
 <3563cf9b-8eab-4c82-b525-a5d2f9a767bb@varteg.nz> <38920A4B-790D-48C7-B2F6-C49D3F506232@rwec.co.uk>
 <0824789d-0e36-4628-85c1-4b8d9b7f86af@varteg.nz> <ab8c974a-c31c-4ff6-974d-0a8c962d5e22@app.fastmail.com>
 <2244a37f-8c51-448d-8a56-329ff32e6470@bastelstu.be> <AE6EAAFA-3E8F-4B7C-877F-D84FBA8178C5@newclarity.net>
 <fc46131c-9f12-4601-b197-f4d66b79f2f8@varteg.nz> <D748C182-20C0-4BE4-859E-FBE86BB93524@newclarity.net>
 <0e1a21ddef3c7da17a3539b92d5f442763f4b1f8.camel@ageofdream.com>
 <CAPyj-LD02XrZ4F6ZqG0PNLrrfekBHiiz+S24v5nv_9xgW4UKUg@mail.gmail.com>
 <5f1da5195e2aea7ec41e95ff4354f50b1717d3cf.camel@ageofdream.com>
 <CAPyj-LDhFFv=B-324YZDUv8BdV8npj6npLn9jxv3reA9SoGjqw@mail.gmail.com>
 <a97242032874e73480c2883e23745a1691ff261a.camel@ageofdream.com>
 <CAPyj-LC4-euT3ddEXMUv8jdOONrtFu16se4zZ38yrt+oaA845g@mail.gmail.com>
 <599a445530357d080cb59c9443cacd5cfd5da82f.camel@ageofdream.com>
 <CAPyj-LAWOmovv1yt8kesAg55zgD+YEZ7Ow7z6ame_CZsDyBpbQ@mail.gmail.com>
 <896ef99559e4e71d8f1c3abc47415b37ae325e55.camel@ageofdream.com>
 <CAPyj-LAjSHeZ6uzu8dDeYQXP0WqEQFc311_ih1NEZ33eSyAgLQ@mail.gmail.com> <a52e1a4ba4144c77863527e57d9613573c0c1fa7.camel@ageofdream.com>
In-Reply-To: <a52e1a4ba4144c77863527e57d9613573c0c1fa7.camel@ageofdream.com>
Date: Mon, 5 Aug 2024 20:49:16 +0200
Message-ID: <CAPyj-LB7nLh9-qwf8pPL_Z=ab58YV15awsvOua1FODVxUJSjJA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Add Directive to Make All Namespaced Function
 Calls Global
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: tovilo.ilija@gmail.com (Ilija Tovilo)

On Mon, Aug 5, 2024 at 3:33=E2=80=AFPM Nick Lockheart <lists@ageofdream.com=
> wrote:
>
> This is a different problem that could be solved by a sandbox API.

Not sure which case we were talking about then. ClockMock is what I've
been referencing all along.

> > Well, ok. But then we're back to prefixing global calls, which
> > defeats the purpose of the proposal.
>
> Global functions would only need a prefix `\` in the *very rare* cases
> where local functions are set as the default. For most people, the \
> would be omitted, as globals would be set as default for unqualified
> function names.

Right. But apart from mocking, what are these cases? If performance
were no longer an issue, "using global functions" just makes the
language harder to use, removing the local fallback. "using local
functions" may be useful in namespaced code making many calls to
functions within the same namespace. In that case, it would probably
be more useful to switch the lookup order back instead. If you want to
pay zero performance penalty, you can prefix global calls with \.
You'd need to do that with "using local functions" anyway.

As for mocking: If the code needs to change either way, why not make
it testable in the first place, e.g. through dependency injection for
time()? At least this only requires changing the calls that are
mocked, instead of all the calls that aren't.

The main benefit of the approach from ClockMock is that your code
(probably) doesn't need to change. I do think that the entire approach
is hacky, and probably worth solving on a language-level, at least if
possible without adding limitations to the engine. A good first start
would be to know what functions are commonly mocked with this
approach.

Ilija