Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124783
Message-ID: <e7baad83-9604-4693-aa51-b1148722f750@gmx.de>
Date: Mon, 5 Aug 2024 19:30:32 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] [VOTE] Transform exit() from a
 languageconstructinto a standard function
Content-Language: de-DE
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>,
 Derick Rethans <derick@php.net>
Cc: "Gina P. Banyard" <internals@gpb.moe>,
 PHP internals <internals@lists.php.net>
References: <WAN6ETlWt7JfcVoyeYfY_F_eLE6WzQa87F7yi8SHISmyktMYx7YcA6oG5dis3gFeI36VBjSfjGw4AT6psFFDXEUNRrvKRRn4LxfdCxFBccw=@gpb.moe>
 <15bb76a0-cbd7-4145-b429-76d424755106@gmx.de>
 <1a8650d2-7eb5-d645-8132-e5522ad24637@php.net>
 <06ba1d82-6387-46ac-8be3-1d3472993e1a@gmx.de>
 <a2cf19e2-4c42-42a1-b060-205b782252c8@bastelstu.be>
In-Reply-To: <a2cf19e2-4c42-42a1-b060-205b782252c8@bastelstu.be>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:fvQTBdRsOMk=;IgnIn4Lw9vXWey3f0FFRbHyJYXg
 XGW9E305A3g6Rho9+ZnT8PCOR3E2DZ9/d45aeYwEDrgBJS7Ty4nsSHMSuyB1dzptOoUbPR6r3
 tO9v2MBr3HjUMrlx33gDj2z+XBIOPij7DZHogemMmT989R9lfOmFjrSgJIQexUxqq+hEKfMxK
 y1l27rr9vzbTc1TQegMc24pFQkx85p/YRk4U8moXbbwNne4c9gaKupRt3sRsLrPmvFyCwOtv4
 61ESSbhrTYSakJZ2h07gJ/o+wzcbDiDyjHCQeiuj9cWFl8BGxiL2YMR5XwnQvdXVOCaVNsCGj
 Oxppzmm6Ip9uwmY3rx0sZrscCN1+8MtuzDbXOjPn/0C/RggQ7pmNQcPMF5hOwNkwLvhYYCdNJ
 HmkWIu8kRdENMKaL2mLpOxXngHSbKuL/EZAC8qS7BZY9IBg4SEfR0PW4P6b03MGeXsnyGgu0c
 C26hc8ATrVE6e0Q0OnlThidRlHyBaIV7wx/l5nqzqH6JMjGNW4XKcDaJ4kULWK9R1q1U8vLS6
 iMIBAyGYVvw5aRwZ/JVlaxQI+rWJkPdQndkifWMxN0nGS/kjaeNbTHAlS4hoqKVS/fVwgSU/R
 Pcsx2SW8QbOZs3ETnYiywu3yTc1ufxS8ln7h1OjCIWfgWcExkYRC0QF7F5ZGTQDuf7utQgVUi
 sUKSSIg2RIUUguhkZO3IR348STT3rJ4qPnahxNzMQDCQErpwsPeR6ydHdoK+jl/l89qCC7TW3
 W6GTLrNJGW5JWVNj1f/zAXiuJ7z74z8jjgjDCN3298HN8OAnX8e2HNnmbSQA94lhbVngb9L3U
 sxayO9V0fTz+NwXZtZtZHQow==
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 05.08.2024 at 18:52, Tim D=C3=BCsterhus wrote:

> On 8/5/24 14:52, Christoph M. Becker wrote:
>
>> Hmm, so far I only had skimmed the RFC and the related discussions, but
>> now I checked out the suggested implementation[1].=C2=A0 Then I tried t=
o
>> build with PECL/uopz, and of course that failed because ZEND_EXIT is no
>> longer there.=C2=A0 Okay, quickly drop that usage; build succeeds.=C2=
=A0 Then I ran
>>
>> <?php
>> uopz_set_return("exit", function () {echo "hello";}, true);
>> exit;
>> ?>
>>
>> And got
>>
>> hello
>>
>> Previously, no output was echoed.=C2=A0 While that seems to be fixable =
in
>
> Frankly from a userland developer PoV this looks entirely correct: If I
> override the `exit()` function, then I expect the `exit()` function to
> be overridden.

I should have clarified, that "fixing" means to restore the expected
behavior of uopz, namely that accidential attempts to override exit with
`uopz_set_return()` were silently ignored, but unless `uopz.exit=3D1` is
set, or `uopz_allow_exit(true)` is called, exit is ignored.  Especially
the latter may be relied upon by tests for legacy code.

Christoph