Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124782
Message-ID: <d7cd95e4-978e-4fd8-8a80-027c76fc3bbb@bastelstu.be>
Date: Mon, 5 Aug 2024 19:11:43 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] [VOTE] Transform exit() from a language construct
 into a standard function
To: Levi Morrison <levi.morrison@datadoghq.com>,
 "Gina P. Banyard" <internals@gpb.moe>
Cc: PHP internals <internals@lists.php.net>
References: <WAN6ETlWt7JfcVoyeYfY_F_eLE6WzQa87F7yi8SHISmyktMYx7YcA6oG5dis3gFeI36VBjSfjGw4AT6psFFDXEUNRrvKRRn4LxfdCxFBccw=@gpb.moe>
 <CAAKU0unkZ6Tc4NZ3Yqpsq5ef_ya+QfvEv8j-7wqcbL5FtW7-Mw@mail.gmail.com>
Content-Language: en-US
In-Reply-To: <CAAKU0unkZ6Tc4NZ3Yqpsq5ef_ya+QfvEv8j-7wqcbL5FtW7-Mw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 8/5/24 18:06, Levi Morrison wrote:
> After thinking about this several times over the course of discussion
> and again now that it's in voting, I have decided to vote no. I am in
> favor of this change, I just think given the concerns it's best to
> wait for PHP 9.0 to do it. Maybe the concerns with control flow can be
> improved by better inference/marking of functions which are
> `noreturn`, at least for known functions (of which `\exit` definitely
> would be).

As I've just explained in my response to Derick within the discussion 
thread related to this RFC: The information is already there, it just 
needs to be used.

For a test I've just added the following code snippet to 
`zend_compile_call()`:

     zend_type return_type = fbc->common.arg_info[-1].type;
     if (ZEND_TYPE_CONTAINS_CODE(return_type, IS_NEVER)) {
     	printf("%s has return type never\n", ZSTR_VAL(lcname));
     } else {
     	printf("%s doesn't have return type never\n", ZSTR_VAL(lcname));
     }

and then I executed the following test script:

     <?php

     namespace Foo;

     function a() {
     	\strrev('foo');
     	exit(new \stdClass());
     }

     try {
     	a();
     } catch (\Throwable) {}
     echo "executed", PHP_EOL;

when running this script, I receive the following output:

     strrev doesn't have return type never
     exit has return type never
     executed

Best regards
Tim Düsterhus