Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124767
Message-ID: <a52e1a4ba4144c77863527e57d9613573c0c1fa7.camel@ageofdream.com>
Subject: Re: [PHP-DEV] [RFC] Add Directive to Make All Namespaced Function
 Calls Global
To: internals@lists.php.net
Date: Mon, 05 Aug 2024 09:33:17 -0400
In-Reply-To: <CAPyj-LAjSHeZ6uzu8dDeYQXP0WqEQFc311_ih1NEZ33eSyAgLQ@mail.gmail.com>
References: 
	<USzt7tZZlO1DmAbSTLhD-bqa23FqZn0zk2aah8Ndxgk9c7RY5PefQ8MjbYPUYAzr2_m4Cf-5AI4PuNBTS84rim_FNS6RaT-cWSv714HEvvU=@gpb.moe>
	 <1a88918e-e808-d778-45e1-53797660e093@php.net>
	 <CAPrKfG5Cw_nU7g7FR+t4C1-YZ8CDsDO_-sRs=yEsHO5kCTZL+A@mail.gmail.com>
	 <c03eb187-bd21-4a4b-9faf-8d0243eaa994@varteg.nz>
	 <aa6bc7aa-28d9-40ca-974f-65075adb6199@rwec.co.uk>
	 <3563cf9b-8eab-4c82-b525-a5d2f9a767bb@varteg.nz>
	 <38920A4B-790D-48C7-B2F6-C49D3F506232@rwec.co.uk>
	 <0824789d-0e36-4628-85c1-4b8d9b7f86af@varteg.nz>
	 <ab8c974a-c31c-4ff6-974d-0a8c962d5e22@app.fastmail.com>
	 <2244a37f-8c51-448d-8a56-329ff32e6470@bastelstu.be>
	 <AE6EAAFA-3E8F-4B7C-877F-D84FBA8178C5@newclarity.net>
	 <fc46131c-9f12-4601-b197-f4d66b79f2f8@varteg.nz>
	 <D748C182-20C0-4BE4-859E-FBE86BB93524@newclarity.net>
	 <0e1a21ddef3c7da17a3539b92d5f442763f4b1f8.camel@ageofdream.com>
	 <CAPyj-LD02XrZ4F6ZqG0PNLrrfekBHiiz+S24v5nv_9xgW4UKUg@mail.gmail.com>
	 <5f1da5195e2aea7ec41e95ff4354f50b1717d3cf.camel@ageofdream.com>
	 <CAPyj-LDhFFv=B-324YZDUv8BdV8npj6npLn9jxv3reA9SoGjqw@mail.gmail.com>
	 <a97242032874e73480c2883e23745a1691ff261a.camel@ageofdream.com>
	 <CAPyj-LC4-euT3ddEXMUv8jdOONrtFu16se4zZ38yrt+oaA845g@mail.gmail.com>
	 <599a445530357d080cb59c9443cacd5cfd5da82f.camel@ageofdream.com>
	 <CAPyj-LAWOmovv1yt8kesAg55zgD+YEZ7Ow7z6ame_CZsDyBpbQ@mail.gmail.com>
	 <896ef99559e4e71d8f1c3abc47415b37ae325e55.camel@ageofdream.com>
	 <CAPyj-LAjSHeZ6uzu8dDeYQXP0WqEQFc311_ih1NEZ33eSyAgLQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-2 
Precedence: bulk
MIME-Version: 1.0
From: lists@ageofdream.com (Nick Lockheart)

>=20
> Consider this example:
>=20
> <?php
> namespace Foo;
> echo time();
>=20
> With my proposal, this would now always call the global time()
> function. You were suggesting that "using local functions" would help
> mitigate this, but I don't think it does.
>=20
> * The user can't add "using local functions" to this file, because in
> a production environment where ClockMock isn't used, there is no
> local
> time() function. With "using local functions" having no fallback, the
> global function would not be called, and hence the code would error.
> Your proposal would only help if the semantics were "use local
> function if available, or global function otherwise", which is what
> we
> have currently.
> * Symfony can't enable the "using local functions" option either when
> including your file, because it would require modifying the source
> code. That leaves eval(), which would really already solve this
> problem if you replace calls to time() with something else.

This is a different problem that could be solved by a sandbox API.

> Well, ok. But then we're back to prefixing global calls, which
> defeats the purpose of the proposal.=20

Global functions would only need a prefix `\` in the *very rare* cases
where local functions are set as the default. For most people, the \
would be omitted, as globals would be set as default for unqualified
function names.