Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124742
Precedence: bulk
MIME-Version: 1.0
References: <CAPyj-LCoBY2bPHLmsyONYDbY9aRSraLz5QNskeTiWfpMD0pTSg@mail.gmail.com>
 <c385b525-37f7-446b-aa96-72272ef9e407@app.fastmail.com>
In-Reply-To: <c385b525-37f7-446b-aa96-72272ef9e407@app.fastmail.com>
Date: Sun, 4 Aug 2024 19:41:17 +0200
Message-ID: <CAPyj-LA4kTJTrQZUkn9kNMvWdH6SsFGU5mBO6EcpuUcRpXesgw@mail.gmail.com>
Subject: Re: [PHP-DEV] [Concept] Flip relative function lookup order (global,
 then local)
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
From: tovilo.ilija@gmail.com (Ilija Tovilo)

Hi Rob

On Fri, Aug 2, 2024 at 7:10=E2=80=AFPM Rob Landers <rob@bottled.codes> wrot=
e:
>
> So, what you=E2=80=99re saying is that symfony and laravel can get a perf=
ormance increase by simply adding a \ in the right places? Why don=E2=80=99=
t they do that instead of changing the language?

Nothing, of course. However, a Symfony maintainer has expressed
uninterest in prefixing all internal function calls, including
automated use statements at the top of the file. Even if they did,
most users will not.

> For functions/classes in the same exact namespace, you don=E2=80=99t need=
 a use statement. But after this change, you do in certain cases?
>
> namespace Foo;
>
> function array_sum($bar) {}
>
> function baz($bar) {
>   return array_sum($bar);
> }
>
> So, how do you use that function in the same file?

Yes. But I'm not sure how that's different from today? If there's a
local and global function declared with the same name, and you intend
to call the global one, you'll already need to disambiguate the call
with a \.

With this change, your two options would be to:

* Prefix your calls with namespace\. That's quite ugly, but is the
syntax we currently offer.
* Add a `use array_sum;` to the top of the file.

An explicit use has upsides too. It makes it much more obvious that
the global function is shadowed.

> We can only see open source code when doing impact analysis. This means p=
icking even a slightly =E2=80=9Cpopular=E2=80=9D name could go very poorly.

Yes, and there are many more than 10 000 composer repositories. An
impact analysis can give you an approximation for breakage, not
absolute numbers.

Ilija