Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124735
Precedence: bulk
MIME-Version: 1.0
References: <USzt7tZZlO1DmAbSTLhD-bqa23FqZn0zk2aah8Ndxgk9c7RY5PefQ8MjbYPUYAzr2_m4Cf-5AI4PuNBTS84rim_FNS6RaT-cWSv714HEvvU=@gpb.moe>
 <1a88918e-e808-d778-45e1-53797660e093@php.net> <CAPrKfG5Cw_nU7g7FR+t4C1-YZ8CDsDO_-sRs=yEsHO5kCTZL+A@mail.gmail.com>
 <c03eb187-bd21-4a4b-9faf-8d0243eaa994@varteg.nz> <aa6bc7aa-28d9-40ca-974f-65075adb6199@rwec.co.uk>
 <3563cf9b-8eab-4c82-b525-a5d2f9a767bb@varteg.nz> <38920A4B-790D-48C7-B2F6-C49D3F506232@rwec.co.uk>
 <0824789d-0e36-4628-85c1-4b8d9b7f86af@varteg.nz> <ab8c974a-c31c-4ff6-974d-0a8c962d5e22@app.fastmail.com>
 <2244a37f-8c51-448d-8a56-329ff32e6470@bastelstu.be> <AE6EAAFA-3E8F-4B7C-877F-D84FBA8178C5@newclarity.net>
 <fc46131c-9f12-4601-b197-f4d66b79f2f8@varteg.nz> <D748C182-20C0-4BE4-859E-FBE86BB93524@newclarity.net>
 <0e1a21ddef3c7da17a3539b92d5f442763f4b1f8.camel@ageofdream.com>
In-Reply-To: <0e1a21ddef3c7da17a3539b92d5f442763f4b1f8.camel@ageofdream.com>
Date: Sun, 4 Aug 2024 14:23:23 +0200
Message-ID: <CADyq6sJqxFsXj245ZmEM-SL6YAK4btTFqP0D1+gnwDY9sm-YAw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] Add Directive to Make All Namespaced Function
 Calls Global
To: Nick Lockheart <lists@ageofdream.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="0000000000002a56b7061edaa19f"
From: ocramius@gmail.com (Marco Pivetta)

--0000000000002a56b7061edaa19f
Content-Type: text/plain; charset="UTF-8"

Hey Nick,
On Sun, 4 Aug 2024 at 13:42, Nick Lockheart <lists@ageofdream.com> wrote:

> This also prevents the parser from using dedicated opcodes for built-in
> functions.
>
> This incurs a performance penalty.
>

For many, many years, tools like `doctrine/coding-standard` have imported
global functions.

The performance benefit is minimal and opt-in at very minimal effort for
userland (literally "run a decent coding standards tool").

Changing this behavior breaks use-cases like shadowing internal functions,
which are useful for testing / stubbing / etc. I disagree with the
technique, but it is a valid and relied-upon use-case nonetheless.

Better ways forward:

 * endorse userland to use a CS tool
 * namespace performance-sensitive PHP functions, so we can exclude the
entire problem, by having people use the namespaced variant :P


Marco Pivetta

https://mastodon.social/@ocramius

https://ocramius.github.io/

--0000000000002a56b7061edaa19f
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hey Nick,</div><div class=3D"gmail_quote"><div dir=3D=
"ltr" class=3D"gmail_attr">On Sun, 4 Aug 2024 at 13:42, Nick Lockheart &lt;=
<a href=3D"mailto:lists@ageofdream.com">lists@ageofdream.com</a>&gt; wrote:=
</div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;b=
order-left:1px solid rgb(204,204,204);padding-left:1ex">
This also prevents the parser from using dedicated opcodes for built-in<br>
functions.<br>
<br>
This incurs a performance penalty.<br></blockquote><div><br></div><div>For =
many, many years, tools like `doctrine/coding-standard` have imported globa=
l functions.</div><div><br></div><div>The performance benefit is minimal an=
d opt-in at very minimal effort for userland (literally &quot;run a decent =
coding standards tool&quot;).<br></div><div><br></div><div>Changing this be=
havior breaks use-cases like shadowing internal functions, which are useful=
 for testing / stubbing / etc. I disagree with the technique, but it is a v=
alid and relied-upon use-case nonetheless.</div><div><br></div><div>Better =
ways forward:</div><div><br></div><div>=C2=A0* endorse userland to use a CS=
 tool</div><div>=C2=A0* namespace performance-sensitive PHP functions, so w=
e can exclude the entire problem, by having people use the namespaced varia=
nt :P <br></div><div><div><br></div><div dir=3D"ltr"><br clear=3D"all"><div=
><div dir=3D"ltr" class=3D"gmail_signature"><div dir=3D"ltr">Marco Pivetta =
<br><br><a href=3D"https://mastodon.social/@ocramius" target=3D"_blank">htt=
ps://mastodon.social/@ocramius</a><br><br><a href=3D"https://ocramius.githu=
b.io/" target=3D"_blank">https://ocramius.github.io/</a></div></div></div><=
/div>=C2=A0</div></div></div>

--0000000000002a56b7061edaa19f--