Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124730
Precedence: bulk
MIME-Version: 1.0
References: <CAPyj-LCoBY2bPHLmsyONYDbY9aRSraLz5QNskeTiWfpMD0pTSg@mail.gmail.com>
 <48c22449-6cdf-449f-917f-365506e3f2d0@scriptfusion.com> <cededcb399dccc64131fec1d19821ace42e5a761.camel@ageofdream.com>
In-Reply-To: <cededcb399dccc64131fec1d19821ace42e5a761.camel@ageofdream.com>
Date: Fri, 2 Aug 2024 19:48:38 -0300
Message-ID: <CADK1yXJY+wtqqt+DUP83SiEn=cj8QfmGK6BVacYM8qddX5xEDw@mail.gmail.com>
Subject: Re: [PHP-DEV] [Concept] Flip relative function lookup order (global,
 then local)
To: Nick Lockheart <lists@ageofdream.com>
Cc: internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000f1a99b061ebb22c1"
From: deleugyn@gmail.com (Deleu)

--000000000000f1a99b061ebb22c1
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 2, 2024 at 7:03=E2=80=AFPM Nick Lockheart <lists@ageofdream.com=
> wrote:

> I was thinking about a similar problem this week.
>
> If class A relies on class B, but you want to swap out
> class B with a stub to test class A in isolation,
> is there a way to make every call to class B,
> from class A, actually call a different class
> during the test, without modifying class A's code?
>
>
> Minimal code for discussion purposes:
>
>
> // conf class in global namespace
> abstract class CONF {
>    const DATABASE_HOST_NAME =3D 'db.example.com';
>    const DATABASE_NAME =3D 'production';
>    const DATABASE_USER_NAME =3D 'prod_user';
>    const DATABASE_PASSWORD =3D '123';
> }
>
>
> // conf class in test namespace:
> namespace test;
> abstract class CONF {
>    const DATABASE_HOST_NAME =3D 'db.sandbox.com';
>    const DATABASE_NAME =3D 'test';
>    const DATABASE_USER_NAME =3D 'test_user';
>    const DATABASE_PASSWORD =3D 'abc';
> }
>
>
> // SQL class in global namespace
> class SQL {
>
>    private function Init(){
>       self::$oPDO =3D new PDO(
>          'mysql:host=3D'.CONF::DATABASE_HOST_NAME.
>          ';dbname=3D'.CONF::DATABASE_NAME.';charset=3Dutf8mb4',
>          CONF::DATABASE_USER_NAME,
>          CONF::DATABASE_PASSWORD,
>          []
>       );
>    }
> }
>
> // Testing class in test namespace:
> namespace test;
> class SQLTester {
>
>    // How do I make the SQL class see \test\CONF instead of
>    // \CONF, when SQL calls for CONF in this test scope,
>    /// without changing anything inside of the SQL class?
> }
>
>
> I think some kind of sandboxing tools would be useful for
> build/test/deployment.
>

You could hack this out using the autoloader, but it's something that the
PHP community frowns upon, imo. A much prevalent practice in the PHP
ecosystem is a Dependency Injection container. A somewhat similar concept
exists in the Javascript ecosystem with hoisting import statements and
mocking modules, but if you don't understand the system and are unaware
that order of import execution will matter on whether the mock succeeds or
not plays a huge role in making it a cumbersome and awkward system.

Regardless, it's not possible for functions as users don't control function
autoloader.
--=20
Marco Deleu

--000000000000f1a99b061ebb22c1
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Fri, Aug 2, 2024 at 7:03=E2=80=AFP=
M Nick Lockheart &lt;<a href=3D"mailto:lists@ageofdream.com">lists@ageofdre=
am.com</a>&gt; wrote:</div><blockquote class=3D"gmail_quote" style=3D"margi=
n:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex=
">
I was thinking about a similar problem this week.<br>
<br>
If class A relies on class B, but you want to swap out<br>
class B with a stub to test class A in isolation,<br>
is there a way to make every call to class B,<br>
from class A, actually call a different class<br>
during the test, without modifying class A&#39;s code?<br>
<br>
<br>
Minimal code for discussion purposes:<br>
<br>
<br>
// conf class in global namespace<br>
abstract class CONF {<br>
=C2=A0 =C2=A0const DATABASE_HOST_NAME =3D &#39;<a href=3D"http://db.example=
.com" rel=3D"noreferrer" target=3D"_blank">db.example.com</a>&#39;;<br>
=C2=A0 =C2=A0const DATABASE_NAME =3D &#39;production&#39;;<br>
=C2=A0 =C2=A0const DATABASE_USER_NAME =3D &#39;prod_user&#39;;<br>
=C2=A0 =C2=A0const DATABASE_PASSWORD =3D &#39;123&#39;;<br>
}<br>
<br>
<br>
// conf class in test namespace:<br>
namespace test;<br>
abstract class CONF {<br>
=C2=A0 =C2=A0const DATABASE_HOST_NAME =3D &#39;<a href=3D"http://db.sandbox=
.com" rel=3D"noreferrer" target=3D"_blank">db.sandbox.com</a>&#39;;<br>
=C2=A0 =C2=A0const DATABASE_NAME =3D &#39;test&#39;;<br>
=C2=A0 =C2=A0const DATABASE_USER_NAME =3D &#39;test_user&#39;;<br>
=C2=A0 =C2=A0const DATABASE_PASSWORD =3D &#39;abc&#39;;<br>
}<br>
<br>
<br>
// SQL class in global namespace<br>
class SQL {<br>
<br>
=C2=A0 =C2=A0private function Init(){<br>
=C2=A0 =C2=A0 =C2=A0 self::$oPDO =3D new PDO(<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&#39;mysql:host=3D&#39;.CONF::DATABASE_HO=
ST_NAME.<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0&#39;;dbname=3D&#39;.CONF::DATABASE_NAME.=
&#39;;charset=3Dutf8mb4&#39;,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0CONF::DATABASE_USER_NAME,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0CONF::DATABASE_PASSWORD,<br>
=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0[]<br>
=C2=A0 =C2=A0 =C2=A0 );<br>
=C2=A0 =C2=A0}<br>
}<br>
<br>
// Testing class in test namespace:<br>
namespace test;<br>
class SQLTester {<br>
<br>
=C2=A0 =C2=A0// How do I make the SQL class see \test\CONF instead of<br>
=C2=A0 =C2=A0// \CONF, when SQL calls for CONF in this test scope,<br>
=C2=A0 =C2=A0/// without changing anything inside of the SQL class?<br>
}<br>
<br>
<br>
I think some kind of sandboxing tools would be useful for<br>
build/test/deployment.<br>
</blockquote></div><br clear=3D"all"><div>You could hack this out using the=
 autoloader, but it&#39;s something that the PHP community frowns upon, imo=
. A much prevalent practice in the PHP ecosystem is a Dependency Injection =
container. A somewhat similar concept exists in the Javascript ecosystem wi=
th hoisting import statements and mocking modules, but if you don&#39;t und=
erstand the system and are unaware that order of import execution will matt=
er on whether the mock succeeds or not plays a huge role in making it a cum=
bersome and awkward system.</div><div><br></div><div>Regardless, it&#39;s n=
ot possible for functions as users don&#39;t control function autoloader.</=
div><span class=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" c=
lass=3D"gmail_signature"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"=
><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr"><div dir=3D"ltr">Marco =
Deleu</div></div></div></div></div></div></div></div></div>

--000000000000f1a99b061ebb22c1--