Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124728
Message-ID: <cededcb399dccc64131fec1d19821ace42e5a761.camel@ageofdream.com>
Subject: Re: [PHP-DEV] [Concept] Flip relative function lookup order
 (global, then local)
To: internals@lists.php.net
Date: Fri, 02 Aug 2024 18:00:33 -0400
In-Reply-To: <48c22449-6cdf-449f-917f-365506e3f2d0@scriptfusion.com>
References: 
	<CAPyj-LCoBY2bPHLmsyONYDbY9aRSraLz5QNskeTiWfpMD0pTSg@mail.gmail.com>
	 <48c22449-6cdf-449f-917f-365506e3f2d0@scriptfusion.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4-2 
Precedence: bulk
MIME-Version: 1.0
From: lists@ageofdream.com (Nick Lockheart)

On Fri, 2024-08-02 at 21:37 +0100, Bilge wrote:
> Hi Ilija,
> I think this proposal has legs, and you are right to rekindle it,
> instead of letting it die quietly.
> On 02/08/2024 17:51, Ilija Tovilo wrote:
> =C2=A0
> > * Some mocking libraries (e.g. Symfony's ClockMock [5])
> > intentionally
> > declare functions called from some file in the files namespace to
> > intercept these calls. This use-case would break. That said, it is
> > somewhat of a fragile approach to begin with, given that it
> > wouldn't
> > work for fully qualified calls, or unnamespaced code.
> >=20
> My only concern is there needs to be an alternative way to do this:
> intercepting internal calls. Sometimes, whether due to poor
> architecture or otherwise, we just need to be able to replace an
> internal function call. One example I can think of recently is where
> I had to replace `header()` with a void function in tests, just to
> stop some legacy code emitting headers before the main framework
> kicked in, then unable to emit its own response because HTTP headers
> had already been sent. In a perfect world it shouldn't be necessary,
> but sometimes it is, so I think for this proposal to be palpable
> there must still be a way to achieve this.
> Cheers,
> =C2=A0Bilge
> =C2=A0


I was thinking about a similar problem this week.

If class A relies on class B, but you want to swap out
class B with a stub to test class A in isolation,
is there a way to make every call to class B,
from class A, actually call a different class
during the test, without modifying class A's code?


Minimal code for discussion purposes:


// conf class in global namespace
abstract class CONF {
   const DATABASE_HOST_NAME =3D 'db.example.com';
   const DATABASE_NAME =3D 'production';
   const DATABASE_USER_NAME =3D 'prod_user';
   const DATABASE_PASSWORD =3D '123';
}


// conf class in test namespace:
namespace test;
abstract class CONF {
   const DATABASE_HOST_NAME =3D 'db.sandbox.com';
   const DATABASE_NAME =3D 'test';
   const DATABASE_USER_NAME =3D 'test_user';
   const DATABASE_PASSWORD =3D 'abc';
}


// SQL class in global namespace
class SQL {

   private function Init(){
      self::$oPDO =3D new PDO(
         'mysql:host=3D'.CONF::DATABASE_HOST_NAME.
         ';dbname=3D'.CONF::DATABASE_NAME.';charset=3Dutf8mb4',
         CONF::DATABASE_USER_NAME,
         CONF::DATABASE_PASSWORD,
         []
      );
   }
}

// Testing class in test namespace:
namespace test;
class SQLTester {

   // How do I make the SQL class see \test\CONF instead of
   // \CONF, when SQL calls for CONF in this test scope,
   /// without changing anything inside of the SQL class?
}


I think some kind of sandboxing tools would be useful for
build/test/deployment.