Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124727
Content-Type: multipart/alternative;
 boundary="------------i8FtGSRQ2b0oWRH99jzCWUZA"
Message-ID: <48c22449-6cdf-449f-917f-365506e3f2d0@scriptfusion.com>
Date: Fri, 2 Aug 2024 21:37:23 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [Concept] Flip relative function lookup order (global,
 then local)
To: internals@lists.php.net
References: <CAPyj-LCoBY2bPHLmsyONYDbY9aRSraLz5QNskeTiWfpMD0pTSg@mail.gmail.com>
Content-Language: en-GB
In-Reply-To: <CAPyj-LCoBY2bPHLmsyONYDbY9aRSraLz5QNskeTiWfpMD0pTSg@mail.gmail.com>
From: bilge@scriptfusion.com (Bilge)

This is a multi-part message in MIME format.
--------------i8FtGSRQ2b0oWRH99jzCWUZA
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Ilija,

I think this proposal has legs, and you are right to rekindle it, 
instead of letting it die quietly.

On 02/08/2024 17:51, Ilija Tovilo wrote:
> * Some mocking libraries (e.g. Symfony's ClockMock [5]) intentionally
> declare functions called from some file in the files namespace to
> intercept these calls. This use-case would break. That said, it is
> somewhat of a fragile approach to begin with, given that it wouldn't
> work for fully qualified calls, or unnamespaced code.
>
My only concern is there needs to be an alternative way to do this: 
intercepting internal calls. Sometimes, whether due to poor architecture 
or otherwise, we just need to be able to replace an internal function 
call. One example I can think of recently is where I had to replace 
`header()` with a void function in tests, just to stop some legacy code 
emitting headers before the main framework kicked in, then unable to 
emit its own response because HTTP headers had already been sent. In a 
perfect world it shouldn't be necessary, but sometimes it is, so I think 
for this proposal to be palpable there must still be a way to achieve this.

Cheers,
Bilge

--------------i8FtGSRQ2b0oWRH99jzCWUZA
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 7bit

<!DOCTYPE html>
<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">
      <p>Hi Ilija,</p>
      <p>I think this proposal has legs, and you are right to rekindle
        it, instead of letting it die quietly.</p>
    </div>
    <div class="moz-cite-prefix">On 02/08/2024 17:51, Ilija Tovilo
      wrote:<span style="white-space: pre-wrap">
</span></div>
    <blockquote type="cite"
cite="mid:CAPyj-LCoBY2bPHLmsyONYDbY9aRSraLz5QNskeTiWfpMD0pTSg@mail.gmail.com">
      <pre class="moz-quote-pre" wrap="">* Some mocking libraries (e.g. Symfony's ClockMock [5]) intentionally
declare functions called from some file in the files namespace to
intercept these calls. This use-case would break. That said, it is
somewhat of a fragile approach to begin with, given that it wouldn't
work for fully qualified calls, or unnamespaced code.

</pre>
    </blockquote>
    <p>My only concern is there needs to be an alternative way to do
      this: intercepting internal calls. Sometimes, whether due to poor
      architecture or otherwise, we just need to be able to replace an
      internal function call. One example I can think of recently is
      where I had to replace `header()` with a void function in tests,
      just to stop some legacy code emitting headers before the main
      framework kicked in, then unable to emit its own response because
      HTTP headers had already been sent. In a perfect world it
      shouldn't be necessary, but sometimes it is, so I think for this
      proposal to be palpable there must still be a way to achieve this.</p>
    <p>Cheers,<br>
      Bilge<br>
    </p>
  </body>
</html>

--------------i8FtGSRQ2b0oWRH99jzCWUZA--