Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124722
Message-ID: <bc6dbbc1-9b12-4c24-b476-2bd1ef343e35@nunninger.info>
Date: Fri, 2 Aug 2024 19:49:54 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [Concept] Flip relative function lookup order (global,
 then local)
To: PHP internals <internals@lists.php.net>
References: <CAPyj-LCoBY2bPHLmsyONYDbY9aRSraLz5QNskeTiWfpMD0pTSg@mail.gmail.com>
Content-Language: de-DE-frami, en-US
In-Reply-To: <CAPyj-LCoBY2bPHLmsyONYDbY9aRSraLz5QNskeTiWfpMD0pTSg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:VsDIsUONylU=;StPefbSI0xmkuDCXtYk6NJMm/Mx
 AQeo5eGhfnLzh+PqLBWdqRagCFcoMPtVt5xNJX/nBk3nVFfZbe/C1rezS8zNJ/RmIuI2YwVru
 yw7FN0v7lfmmnoGl0YoFbxZ7df1SP28iUVeQKet8mRE7Q0+uEZfFhXtynl+r9kziLbU4HBm+7
 YVB23dm2IFSOwx0+Q+KFAyX0MCrmVhmaMePSwhRQPaRqvasxXZTzoe9ZjUrmbbZkoR8RCZ0Vd
 vJ5blkIRDGcpTfVZuybXX2xf7j5uneqtsjf8RFghbRmuiK+pGK1wPv9rHtvkD3yoeDYlM7ru2
 C0mmwAz2sgr+z2tV6RcaJ2ebX296Zbypk+vOHxQmB+Qo4mIbAAypSW6YTmfec1wxEpGseJdK9
 TLgL599aLu/7ZpZoITMHDxdRobANiZH5MnScwBjXezKp7JD5UFl1khthe0VtXC9JCnY17uNRw
 /KylTrfkTMowsAhj1PB8S11ZDx99+d+Ed+zlN9HaQTyeI3xWgAYzdn4OVDi/2cOl/z7hLosyH
 L5Ve/Rkub+FQxs9Kr4L2lvPdtCmbDR8jLsd9woQDM/DrBtp0zZuwzuWNtnvHeyiNklKEFODE+
 0IW0W5/xIAvut8XVL1C/FnEyt55u2vmAfp5favM7tuO1t6Rb4C2mvmghC53aSihamCZpWacFV
 3NmDsc9EarPwREcPM5AI27n6JsxIladoHMp4nOmQ95cqLB6XkNXB/5CGDzOHs/up4PvWWeq8s
 LqqfGRfXgHqGDGnaoKyn9SobOKAJwb0ug==
From: thomas@nunninger.info (Thomas Nunninger)

Hi,

Am 02.08.24 um 18:51 schrieb Ilija Tovilo:

...
> There are a few noteworthy downsides:
> 
> * Unqualified calls to functions in the same namespace would be
> slightly slower, because they now involve checking global scope first.
> I believe that unqualified, global calls are much more common, so this
> change should still result in a net positive. It's also possible to
> avoid this cost by adding a `use function` to the top of the file.
> * Introducing new functions in the global namespace could cause a BC
> break for unqualified calls, if the function happens to have the same
> name. This is unfortunate, but likely rare. Since new functions are
> only introduced in minor/major versions, this should be manageable,
> but must be considered for every PHP upgrade.
> * Some mocking libraries (e.g. Symfony's ClockMock [5]) intentionally
> declare functions called from some file in the files namespace to
> intercept these calls. This use-case would break. That said, it is
> somewhat of a fragile approach to begin with, given that it wouldn't
> work for fully qualified calls, or unnamespaced code.

Similar to Symfony's ClockMock this "feature" was propagated some years 
ago to e.g. intercept calls to the file system when running tests where 
the application was not designed with test-ability in mind.

Regards,
Thomas