Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124620
Feedback-ID: ifab94697:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-582-g5a02f8850-fm-20240719.002-g5a02f885
Precedence: bulk
MIME-Version: 1.0
Message-ID: <7b295e3d-68fc-47b5-81ee-e5e09d7c17a8@app.fastmail.com>
In-Reply-To: <d8c8b2ff-b567-4be0-850a-b24844bbd49f@app.fastmail.com>
References: <0a6a61cd-f203-4dea-a7f8-97e6b885c52d@app.fastmail.com>
 <b5c0be62-ea39-47fb-a8f8-ab6cd5ee3dab@app.fastmail.com>
 <CP8P284MB2148CB72E1A6A7AB5F29E8F093AE2@CP8P284MB2148.BRAP284.PROD.OUTLOOK.COM>
 <a3154cde-73ca-4b8e-bf90-b9aeabd5fbce@app.fastmail.com>
 <66c4ac1c-b3d7-4b20-b986-1fe1a464f485@app.fastmail.com>
 <4e7714cb-0d88-43f5-aa30-9adb799e0b28@seld.be>
 <161d5b04-4d94-47e9-a248-61639d688381@app.fastmail.com>
 <d8c8b2ff-b567-4be0-850a-b24844bbd49f@app.fastmail.com>
Date: Fri, 26 Jul 2024 17:35:07 +0200
To: internals@lists.php.net
Subject: Re: [PHP-DEV] [RFC] Asymmetric Visibility, v2
Content-Type: multipart/alternative;
 boundary=8373db61504a4ed7bd1ba1994f3c0fc2
From: rob@bottled.codes ("Rob Landers")

--8373db61504a4ed7bd1ba1994f3c0fc2
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 26, 2024, at 16:27, Larry Garfield wrote:
> On Fri, Jul 26, 2024, at 12:58 PM, Rob Landers wrote:
>=20
> >> And now that I see it spelled out more, I do agree that while it ap=
pears a bit more verbose, and this "(set)" looks odd at first, having al=
l the visibility upfront is a lot clearer than having to read through th=
e hooks to see what visibility applies.
> >
> > On a large property hook that potentially span hundreds of lines, I'=
d=20
> > rather only need to scroll up to the "set =3D>" to see how it is set=
 vs.=20
> > going all the way back up to the property itself.
>=20
> If someone has a property hook that is hundreds of lines long, their c=
ode is already crap and there's no hope for them.
>=20
> --Larry Garfield
>=20

True, but we don't always get to choose what code we work on.

=E2=80=94 Rob
--8373db61504a4ed7bd1ba1994f3c0fc2
Content-Type: text/html;charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Fri, Jul 26,=
 2024, at 16:27, Larry Garfield wrote:<br></div><blockquote type=3D"cite=
" id=3D"qt" style=3D""><div>On Fri, Jul 26, 2024, at 12:58 PM, Rob Lande=
rs wrote:<br></div><div><br></div><div>&gt;&gt; And now that I see it sp=
elled out more, I do agree that while it appears a bit more verbose, and=
 this "(set)" looks odd at first, having all the visibility upfront is a=
 lot clearer than having to read through the hooks to see what visibilit=
y applies.<br></div><div>&gt;<br></div><div>&gt; On a large property hoo=
k that potentially span hundreds of lines, I'd&nbsp;<br></div><div>&gt; =
rather only need to scroll up to the "set =3D&gt;" to see how it is set =
vs.&nbsp;<br></div><div>&gt; going all the way back up to the property i=
tself.<br></div><div><br></div><div>If someone has a property hook that =
is hundreds of lines long, their code is already crap and there's no hop=
e for them.<br></div><div><br></div><div>--Larry Garfield<br></div><div>=
<br></div></blockquote><div><br></div><div>True, but we don't always get=
 to choose what code we work on.</div><div><br></div><div id=3D"sig12122=
9152">=E2=80=94 Rob<br></div></body></html>
--8373db61504a4ed7bd1ba1994f3c0fc2--