Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124592
Message-ID: <c6f86d3b-1458-4775-8da9-e9c23e9086ea@bastelstu.be>
Date: Thu, 25 Jul 2024 20:35:38 +0200
Precedence: bulk
MIME-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4
To: Nick Lockheart <lists@ageofdream.com>, internals@lists.php.net
References: <USzt7tZZlO1DmAbSTLhD-bqa23FqZn0zk2aah8Ndxgk9c7RY5PefQ8MjbYPUYAzr2_m4Cf-5AI4PuNBTS84rim_FNS6RaT-cWSv714HEvvU=@gpb.moe>
 <1a88918e-e808-d778-45e1-53797660e093@php.net>
 <CAPrKfG5Cw_nU7g7FR+t4C1-YZ8CDsDO_-sRs=yEsHO5kCTZL+A@mail.gmail.com>
 <95147d9d-d6e8-4396-bf0b-409c33679f90@bastelstu.be>
 <68ba999c63215204227eae87af69572d25e6b1b8.camel@ageofdream.com>
Content-Language: en-US
In-Reply-To: <68ba999c63215204227eae87af69572d25e6b1b8.camel@ageofdream.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
From: tim@bastelstu.be (=?UTF-8?Q?Tim_D=C3=BCsterhus?=)

Hi

On 7/25/24 19:28, Nick Lockheart wrote:
> I'm in the process of refactoring an old framework and I just found a
> use of sha1(). It's being used to generate a unique resource lock. It
> doesn't need to be secure, just a fast and random UID.

SHA-1 is a deterministic algorithm, thus it is unable to generate a 
random UID. Whatever this code is doing can most likely be more reliably 
achieved in a different way.

Best regards
Tim Düsterhus