Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124558
Message-ID: <e29c8c84-2b41-4123-9411-a3b58a1b18d7@gmx.de>
Date: Tue, 23 Jul 2024 16:32:47 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4
Content-Language: de-DE
To: Jakub Zelenka <bukka@php.net>, "Gina P. Banyard" <internals@gpb.moe>
Cc: PHP internals <internals@lists.php.net>
References: <USzt7tZZlO1DmAbSTLhD-bqa23FqZn0zk2aah8Ndxgk9c7RY5PefQ8MjbYPUYAzr2_m4Cf-5AI4PuNBTS84rim_FNS6RaT-cWSv714HEvvU=@gpb.moe>
 <CAEKnhAGqzhwssfUmu_4-8AR-kXp7FH6PPhDdR8X7uPJk-hDiWg@mail.gmail.com>
In-Reply-To: <CAEKnhAGqzhwssfUmu_4-8AR-kXp7FH6PPhDdR8X7uPJk-hDiWg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:u5/ldzlCUHc=;/BmqUaGSds2IC1uGl674qvIVlQQ
 hW1ZcHPcuNUwUkf/0qacrLpcKZ+ZHJlKsLyJfjsqDkwwgr/Hw3pACGMnUEUr+LeS2i3Eq9pTu
 w0hO1/3ZQsAykb87AKNKIyD9Rp/oeK8EkIpaTsWu2o0JktIlo1lfIuGVXFK/fX5msOJaBDAef
 MEUQj0IYUtagNnw815ch9ZAgy3+eEZk9/lDQiEcnF0QPRex1HUS3mAo3SSS/RWPWls/7gBUGr
 WXay/2uqikKlD/0A79K0h3Sj9yHugZQga9fRFKrXRxLHog8XaoqS19gqFtfVY8tp8YD0nXCLr
 CipKIY7yG0fCRxjreIBf9kCwO53OdSG01AkO5LSzUSu21NI06shzh+sQUsyHjwJsITlo6VnXN
 rVbjsVYIrLkWBqOMKSzpG/xjiLnMdhRGR9LnjffP0PF84Rnlr6u6hMX7jFT8wh6oLsNfiVIGq
 nZklsa9OR/3Z1lOdfphuGo/VwV2lGmwn506u2n7/PKYJwlVJ4MpxYor9jYRz8DHZswLcygQxZ
 ipe7JFZ58m/Ak9vRGyQN0z3MG57NCevRcKaPDXVV85zAOa3RI+/GY8wtCTC55Kghy9FMa49I1
 9lE8BGxk2sFDPtcReUvj70ampJ3Mk1OMzc18t+ReYoVq1sq4reKuyTvEDIyHEVZYckEfa02jU
 vuNn+NN4NtMa2ZH7jm1FDAOBQ5O9vY/+V6KGe+jVhnLeyfE487lBLmY5N05BC8HfCQcHpwpi3
 jhyMgJxqViWUIZvTYHZ48Py3pvIR9LG20Il35VMu9UflwCz66P57wcajoE4weF/mSQmuoVUJO
 J0S6FLCqDleHqqL7jj0/G7yQ==
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi Jakub!

On 22.07.2024 at 12:59, Jakub Zelenka wrote:

> On Fri, Jul 19, 2024 at 6:42=E2=80=AFPM Gina P. Banyard <internals@gpb.m=
oe> wrote:
>
>> I have opened the vote for the mega deprecation RFC:
>> https://wiki.php.net/rfc/deprecations_php_8_4
>
> Just wanted to send some reasoning of my no votes.
>
> The CSV one is also a bit weird because the default is non empty paramet=
er
> so I'm not sure what this actually brings except some inconsistency. Peo=
ple
> that explicitly set it, do that probably for some reason. I would really
> prefer not to try to change this functionality as the BC breaks will cau=
se
> more issues.

The default "\\" likely causes more harm than good for almost anybody.
It basically enables a proprietary extension to CSV (something like
DSV), but there are a couple of issues where it is totally unclear what
should happen, and there still might be unresolved (because
unresolvable) tickets lying around about that.

I do have to agree, though, that this deprecation is somewhat
unfortunate, since an empty string is only accepted as of PHP 7.4.0, so
there is likely some code around which passes e.g. "\0" which also
disables the proprietary extension if there are no NUL bytes in the CSV
file (or to be written to a CSV file).

For that reason I didn't vote on that deprecation, although I would not
like to keep that proprietary extension forever.

Cheers,
Christoph