Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124545
Precedence: bulk
MIME-Version: 1.0
References: <USzt7tZZlO1DmAbSTLhD-bqa23FqZn0zk2aah8Ndxgk9c7RY5PefQ8MjbYPUYAzr2_m4Cf-5AI4PuNBTS84rim_FNS6RaT-cWSv714HEvvU=@gpb.moe>
 <CAEKnhAGqzhwssfUmu_4-8AR-kXp7FH6PPhDdR8X7uPJk-hDiWg@mail.gmail.com>
In-Reply-To: <CAEKnhAGqzhwssfUmu_4-8AR-kXp7FH6PPhDdR8X7uPJk-hDiWg@mail.gmail.com>
Date: Mon, 22 Jul 2024 12:39:24 +0100
Message-ID: <CAEKnhAGX9iYxZP9uP0hswrdv6v2SG6TRTS-YP2VaE1JzS4pWxw@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d635cf061dd47f35"
From: bukka@php.net (Jakub Zelenka)

--000000000000d635cf061dd47f35
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 22, 2024 at 11:59=E2=80=AFAM Jakub Zelenka <bukka@php.net> wrot=
e:

> I think we should also keep file_put_contents array argument as it might
> actually be used with iovec in the future which could be a significant
> optimization - need to check details if that would work but if it does, i=
t
> could be a pretty good optimization.
>

I had a bit closer look on this one and it should be possible to optimize
it for some cases. We could basically introduce something like
php_stream_writev. It would need to have logic to do the same sort
concatenation if filters used or for stream wrappers not supporting iovec.
But for plain wrapper, we should be able to support it and it could be a
good optimization for some users and a way how to cleanly expose it. So I
would suggest to remove this from this list as there seems to be a good use
case for this functionality.

Regards

Jakub

--000000000000d635cf061dd47f35
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Mon, Jul 22, 2024 at 11:59=E2=80=AFAM =
Jakub Zelenka &lt;<a href=3D"mailto:bukka@php.net">bukka@php.net</a>&gt; wr=
ote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quote" =
style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);pa=
dding-left:1ex"><div dir=3D"ltr"><div class=3D"gmail_quote"><div>I think we=
 should also keep=C2=A0file_put_contents array argument as it might actuall=
y be used with iovec in the future which could be a significant optimizatio=
n - need to check details if that would work but if it does, it could be a =
pretty good optimization.</div></div></div></blockquote><div><br></div><div=
>I had a bit closer look on this one and it should be possible to optimize =
it for some cases. We could basically introduce something like php_stream_w=
ritev. It would need to have logic to do the same sort concatenation if fil=
ters used or for stream wrappers not supporting iovec. But for plain wrappe=
r, we should be able to support it and it could be a good optimization for =
some users and a way how to cleanly expose it. So I would suggest to remove=
 this from this list as there seems to be a good use case for this function=
ality.</div><div><br></div><div>Regards</div><div><br></div><div>Jakub</div=
></div></div>

--000000000000d635cf061dd47f35--