Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124544
Precedence: bulk
MIME-Version: 1.0
References: <USzt7tZZlO1DmAbSTLhD-bqa23FqZn0zk2aah8Ndxgk9c7RY5PefQ8MjbYPUYAzr2_m4Cf-5AI4PuNBTS84rim_FNS6RaT-cWSv714HEvvU=@gpb.moe>
In-Reply-To: <USzt7tZZlO1DmAbSTLhD-bqa23FqZn0zk2aah8Ndxgk9c7RY5PefQ8MjbYPUYAzr2_m4Cf-5AI4PuNBTS84rim_FNS6RaT-cWSv714HEvvU=@gpb.moe>
Date: Mon, 22 Jul 2024 11:59:53 +0100
Message-ID: <CAEKnhAGqzhwssfUmu_4-8AR-kXp7FH6PPhDdR8X7uPJk-hDiWg@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [VOTE] Deprecations for PHP 8.4
To: "Gina P. Banyard" <internals@gpb.moe>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000084760c061dd3f2d0"
From: bukka@php.net (Jakub Zelenka)

--00000000000084760c061dd3f2d0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

On Fri, Jul 19, 2024 at 6:42=E2=80=AFPM Gina P. Banyard <internals@gpb.moe>=
 wrote:

> Hello internals,
>
> I have opened the vote for the mega deprecation RFC:
> https://wiki.php.net/rfc/deprecations_php_8_4
>
> Reminder, each vote must be submitted individually.
>
>
>
Just wanted to send some reasoning of my no votes.

I voted no on those output handlers as there might be potentially better
solutions. The whole output stuff needs a closer look so I think we should
wait on this until the review is done.

Otherwise I also voted no for the mysqli_kill and mysqli_refresh functions
as I feel that it's not a big deal to keep them (zero maintenance
basically) and there will be likely users to use them. I think it would
make sense to not add them but if there are already there I don't see a
point to remove them.

I think we should also keep file_put_contents array argument as it might
actually be used with iovec in the future which could be a significant
optimization - need to check details if that would work but if it does, it
could be a pretty good optimization.

The CSV one is also a bit weird because the default is non empty parameter
so I'm not sure what this actually brings except some inconsistency. People
that explicitly set it, do that probably for some reason. I would really
prefer not to try to change this functionality as the BC breaks will cause
more issues.

All my other no are mainly about the BC concerns that I have.

Regards

Jakub

--00000000000084760c061dd3f2d0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div>Hi,</div><br><div class=3D"gmail_quote"><div dir=3D"l=
tr" class=3D"gmail_attr">On Fri, Jul 19, 2024 at 6:42=E2=80=AFPM Gina P. Ba=
nyard &lt;internals@gpb.moe&gt; wrote:<br></div><blockquote class=3D"gmail_=
quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,=
204);padding-left:1ex">Hello internals,<br>
<br>
I have opened the vote for the mega deprecation RFC:<br>
<a href=3D"https://wiki.php.net/rfc/deprecations_php_8_4" rel=3D"noreferrer=
" target=3D"_blank">https://wiki.php.net/rfc/deprecations_php_8_4</a><br>
<br>
Reminder, each vote must be submitted individually.<br>
<br><br></blockquote><div><br></div><div>Just wanted to send some reasoning=
 of my no votes.=C2=A0</div><div><br></div><div>I voted no on those output =
handlers as there might be potentially better solutions. The whole output s=
tuff needs a closer look so I think we should wait on this until the review=
 is done.</div><div><br></div><div>Otherwise I also voted no for the mysqli=
_kill and mysqli_refresh functions as I feel that it&#39;s not a big deal t=
o keep them (zero maintenance basically) and there will be likely users to =
use them. I think it would make sense to not add them but if there are alre=
ady there I don&#39;t see a point to remove them.</div><div><br></div><div>=
I think we should also keep=C2=A0file_put_contents array argument as it mig=
ht actually be used with iovec in the future which could be a significant o=
ptimization - need to check details if that would work but if it does, it c=
ould be a pretty good optimization.</div><div><br></div><div>The CSV one is=
 also a bit weird because the default is non empty parameter so I&#39;m not=
 sure what this actually brings except some inconsistency. People that expl=
icitly set it, do that probably for some reason. I would really prefer not =
to try to change this functionality as the BC breaks will cause more issues=
.</div><div><br></div><div>All my other no are mainly about the BC concerns=
 that I have.</div><div><br></div><div>Regards</div><div><br></div><div>Jak=
ub</div></div></div>

--00000000000084760c061dd3f2d0--