Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124536
Date: Sun, 21 Jul 2024 14:51:33 +0000
To: Niels Dossche <dossche.niels@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Subject: Re: [PHP-DEV] Add tidyNode::getNextSibling() and tidyNode::getPreviousSibling()
Message-ID: <4OwOBcK1vaq2GrG8iGlfXqW9wDq0cu4YRfLNGWuUHoU1fwjSj2r3QloQW_CIHgKXutwgOmIxQbIQTXko8yRBDP7HRrzqUGcow3aNBW6WUF4=@gpb.moe>
In-Reply-To: <aeed6a7c-5514-4aa5-b29c-ac59d602d6bc@gmail.com>
References: <aeed6a7c-5514-4aa5-b29c-ac59d602d6bc@gmail.com>
Feedback-ID: 96993444:user:proton
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
From: internals@gpb.moe ("Gina P. Banyard")

On Sunday, 21 July 2024 at 12:24, Niels Dossche <dossche.niels@gmail.com> w=
rote:

> Hi internals
>=20
> I opened a PR to add the getNextSibling() and getPreviousSibling() method=
s to the tidyNode class.
> As the class is final, this has no BC break concerns.
>=20
> The reason for adding this is that it's inconvenient to walk the tree sol=
ely using the existing getParent() method and ->child property.
>=20
> Since it's a tree anyway, methods to obtain the previous or next sibling =
are natural en convenient.
>=20
> Just sending this mail to see if anyone objects to this.
> PR link: https://github.com/php/php-src/pull/15047
>=20
> Kind regards
> Niels

I think this makes sense and is a nice convenience addition.

Best regards,

Gina P. Banyard