Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:124530 X-Original-To: internals@lists.php.net Delivered-To: internals@lists.php.net Received: from php-smtp4.php.net (php-smtp4.php.net [45.112.84.5]) by qa.php.net (Postfix) with ESMTPS id 1020B1A00B7 for ; Sun, 21 Jul 2024 11:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=php.net; s=mail; t=1721561100; bh=qLpnqXzxEz5OCzH8mqjvxE8IDB51DnVwogfCoWYjVVI=; h=Date:To:From:Subject:From; b=BYmcPKDiR/QpftgYD9sZ9WZJnAnmpAQWAcOhk9HNHZ+YuGj0Y69AjXjYAOl926yfY nW992Oldc3rB58RpQEwJ5OqN/P5SdYtHncKXCEe6AN3+IwkbCU8JbcgSuHaoclSkxw 3EuWuhg2sF2YgzqvdDhA44a9ZrKTxrZg5CdTdy2+vcgB3YIt4snQQeD5QUocT+DY79 ogEtQYzucvzH1ftT+t/uM9WY3kJIx8UA77OP14PJj5BHeqLCGE5X32dYi33c87htjl fXbcVHLgLfd8UVgyNifqzO214ousuq61uhC8dg+ze9EehVp7e47qggusYh5NRwqz/a GfS+YZHM6WdZw== Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 3559D1801EC for ; Sun, 21 Jul 2024 11:24:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DMARC_PASS,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=4.0.0 X-Spam-Virus: No X-Envelope-From: Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sun, 21 Jul 2024 11:24:56 +0000 (UTC) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4265b7514fcso15162005e9.1 for ; Sun, 21 Jul 2024 04:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721561003; x=1722165803; darn=lists.php.net; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=qLpnqXzxEz5OCzH8mqjvxE8IDB51DnVwogfCoWYjVVI=; b=BPt5ud3kF7j4ah0shLqZjRH4hZwMmxwQ6UcsxD7Pf9cmo/KBedaiozAYi6bNyjwKys DslIexnYnLF0GI8oL/vfe5rsJ7ZwSMi+i8/eC9B19V6J6RAPsKfFBZF4ToC4WdJnMUgB XpeNJa4rmM5dm3EGQXU0T242Bn9pL9p4AGJYl41bj7RBv9eMkTF7MhfTU+WNcYFcWaUW eyFAax11KswzJze3/DqI1amxI06shIMT5C8z4atB/CL4+CNGhUE46EYa7xY25Y6CtxQa vXj7Se6MDRyT3GYyXKFbgKlVNZeZJ8JGSkHfm3ZngPwWsEFswApai8ADKPQVsRe8yNq+ B/MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721561003; x=1722165803; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=qLpnqXzxEz5OCzH8mqjvxE8IDB51DnVwogfCoWYjVVI=; b=dpy/4fXSqTubEr9NotjBPmRBXpp4SZatS+AD7083wfQMzdRwK5yXRAJbsJD3h2bNlK xRXJsjdvyxsWMqQuY0SRjv6sSEoWDlunyZhG5GUZNN/yPbYwzMuQNmU9r3HlM8r9oI7R /xrQ7sT9WHIrIGPEjB8tKU5kAdUjv7Ur+004H1lp5VTTtYarWYm/aOumqu2o+O/g1IQy bxKT8iJHGqixr0YIi9fpZGoUMUq1BwbgwJyqtDOmoNXzrgdiIRKocRlORXrPtbtUQr3s nxYkMZszlE5p1RJTTjnmKgcC+mwCLP/fA9vzDTmwAt+LReElMMV7cs0qPL+tKRFK31G5 s23w== X-Gm-Message-State: AOJu0YxYMWVX+XYdlgeM29VVaQCSHeMRJAZ26IslMWOVEDvhYlqco2b9 J08OAfWM/wGK2cWw39WtN1U8i9rs8UlqMxJ9MvaduTyuAeDOZq94qRkIqQGV X-Google-Smtp-Source: AGHT+IEejRmEVFHaGEzVCUySWw8QkHCsdITiHcQHJ+N40TCVeJZkm8HQFellOeUKxarS0osIjWnu1g== X-Received: by 2002:a05:600c:a012:b0:426:6327:5a16 with SMTP id 5b1f17b1804b1-427da854efemr26635795e9.18.1721561002464; Sun, 21 Jul 2024 04:23:22 -0700 (PDT) Received: from [192.168.0.103] (178-117-134-240.access.telenet.be. [178.117.134.240]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427d2a5c3d4sm113735235e9.17.2024.07.21.04.23.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 Jul 2024 04:23:22 -0700 (PDT) Message-ID: Date: Sun, 21 Jul 2024 13:24:28 +0200 Precedence: bulk list-help: list-post: List-Id: internals.lists.php.net x-ms-reactions: disallow MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: PHP internals Subject: [PHP-DEV] Add tidyNode::getNextSibling() and tidyNode::getPreviousSibling() Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit From: dossche.niels@gmail.com (Niels Dossche) Hi internals I opened a PR to add the getNextSibling() and getPreviousSibling() methods to the tidyNode class. As the class is final, this has no BC break concerns. The reason for adding this is that it's inconvenient to walk the tree solely using the existing getParent() method and ->child property. Since it's a tree anyway, methods to obtain the previous or next sibling are natural en convenient. Just sending this mail to see if anyone objects to this. PR link: https://github.com/php/php-src/pull/15047 Kind regards Niels