Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124515
Precedence: bulk
MIME-Version: 1.0
References: <66984FD0.5090805@adviesenzo.nl> <C74348B0-A64C-4F4E-9789-440E65E94B15@gmail.com>
 <f6ff45c5-94b9-4ebd-b9ab-c9a9ba42b7e7@bastelstu.be> <84999002-cff1-436a-8036-b7b4facb2cba@gmx.de>
 <237f2004-92dd-46e5-9946-91b8c8d97166@bastelstu.be>
In-Reply-To: <237f2004-92dd-46e5-9946-91b8c8d97166@bastelstu.be>
Date: Sat, 20 Jul 2024 10:38:45 -0500
Message-ID: <CAJp_myWVcRZStRX3UGk7z_PVCssUy2_X+VHoEUqWxC3qTxmurQ@mail.gmail.com>
Subject: Re: [PHP-DEV] Request for opinions: bug vs feature - change
 intokenization of yield from
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>
Cc: "Christoph M. Becker" <cmbecker69@gmx.de>, =?UTF-8?Q?Marco_Aur=C3=A9lio_Deleu?= <deleugyn@gmail.com>, 
	Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000020a789061daf9c03"
From: mweierophinney@gmail.com ("Matthew Weier O'Phinney")

--00000000000020a789061daf9c03
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Jul 20, 2024, 9:31=E2=80=AFAM Tim D=C3=BCsterhus <tim@bastelstu.be>=
 wrote:

> Hi
>
> On 7/19/24 00:51, Christoph M. Becker wrote:
> > And frankly, how much code would be affected?  I mean, does anybody
> > actually put a comment between `yield` and `from`?  Is there a case
> > where this may make sense?  "Because we can" isn't a strong argument, i=
n
> > my opinion.
>
> I don't really follow this line of argumentation:
>
> If folks do not use the syntax anyways, then we do not need to have this
> discussion, because the tools can just ignore it existing. That also
> means we do not need to revert the change in PHP.
>
> If folks use the syntax, then reverting the change is a breaking change
> for them.
>

By this line of reasoning, any bug that makes it into the engine that
somebody finds a use for shouldn't be fixed.

I totally understand wanting to keep this in, but because it made it in
without an RFC, it's (a) inconsistent with other areas of the language, and
(b) does not have a full design which includes tokenizer support.

Considering the brief time it's been in the engine, and the fact that it's
not documented, I feel it should be reverted and only re-added if someone
takes the time and effort to propose the change properly.

>
>

--00000000000020a789061daf9c03
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"auto"><div><br><br><div class=3D"gmail_quote"><div dir=3D"ltr" =
class=3D"gmail_attr">On Sat, Jul 20, 2024, 9:31=E2=80=AFAM Tim D=C3=BCsterh=
us &lt;<a href=3D"mailto:tim@bastelstu.be" target=3D"_blank" rel=3D"norefer=
rer">tim@bastelstu.be</a>&gt; wrote:<br></div><blockquote class=3D"gmail_qu=
ote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex=
">Hi<br>
<br>
On 7/19/24 00:51, Christoph M. Becker wrote:<br>
&gt; And frankly, how much code would be affected?=C2=A0 I mean, does anybo=
dy<br>
&gt; actually put a comment between `yield` and `from`?=C2=A0 Is there a ca=
se<br>
&gt; where this may make sense?=C2=A0 &quot;Because we can&quot; isn&#39;t =
a strong argument, in<br>
&gt; my opinion.<br>
<br>
I don&#39;t really follow this line of argumentation:<br>
<br>
If folks do not use the syntax anyways, then we do not need to have this <b=
r>
discussion, because the tools can just ignore it existing. That also <br>
means we do not need to revert the change in PHP.<br>
<br>
If folks use the syntax, then reverting the change is a breaking change <br=
>
for them.<br></blockquote></div></div><div dir=3D"auto"><br></div><div dir=
=3D"auto">By this line of reasoning, any bug that makes it into the engine =
that somebody finds a use for shouldn&#39;t be fixed.=C2=A0</div><div dir=
=3D"auto"><br></div><div dir=3D"auto">I totally understand wanting to keep =
this in, but because it made it in without an RFC, it&#39;s (a) inconsisten=
t with other areas of the language, and (b) does not have a full design whi=
ch includes tokenizer support.=C2=A0</div><div dir=3D"auto"><br></div><div =
dir=3D"auto">Considering the brief time it&#39;s been in the engine, and th=
e fact that it&#39;s not documented, I feel it should be reverted and only =
re-added if someone takes the time and effort to propose the change properl=
y.=C2=A0</div><div dir=3D"auto"><div class=3D"gmail_quote"><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;pad=
ding-left:1ex"><br>
</blockquote></div></div></div>

--00000000000020a789061daf9c03--