Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124507
Precedence: bulk
MIME-Version: 1.0
References: <CAH5C8xUb1O20ZDrOQNC=ckFxHUUWSK7sw_njQQzFBd0qgQqoww@mail.gmail.com>
 <CAM7F2--2W67u-awM-3QuDGqA6ojr4yAqAiaJ0dBxKxb65Hc2Rg@mail.gmail.com>
In-Reply-To: <CAM7F2--2W67u-awM-3QuDGqA6ojr4yAqAiaJ0dBxKxb65Hc2Rg@mail.gmail.com>
Date: Fri, 19 Jul 2024 16:55:27 -0600
Message-ID: <CAM7F2-88Gz-iqGVKRdsfaDeK4Oy6EQ+cg23SzWcxA+0Cmbd+RA@mail.gmail.com>
Subject: Re: [PHP-DEV] [RFC] [Discussion] Add WHATWG compliant URL parsing API
To: =?UTF-8?B?TcOhdMOpIEtvY3Npcw==?= <kocsismate90@gmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000004880f061da19831"
From: lnearwaju@gmail.com (Lanre)

--00000000000004880f061da19831
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, Jul 8, 2024 at 11:24=E2=80=AFAM Lanre <lnearwaju@gmail.com> wrote:

>
> On Fri, Jun 28, 2024 at 3:38=E2=80=AFPM M=C3=A1t=C3=A9 Kocsis <kocsismate=
90@gmail.com>
> wrote:
>
>> Hi Everyone,
>>
>> I've been working on a new RFC for a while now, and time has come to
>> present it to a wider audience.
>>
>> Last year, I learnt that PHP doesn't have built-in support for parsing
>> URLs according to any well established standards (RFC 1738 or the WHATWG
>> URL living standard), since the parse_url() function is optimized for
>> performance instead of correctness.
>>
>> In order to improve compatibility with external tools consuming URLs
>> (like browsers), my new RFC would add a WHATWG compliant URL parser
>> functionality to the standard library. The API itself is not final by an=
y
>> means, the RFC only represents how I imagined it first.
>>
>> You can find the RFC at the following link:
>> https://wiki.php.net/rfc/url_parsing_api
>>
>> Regards,
>> M=C3=A1t=C3=A9
>>
>>
> I was exploring wrapping ada_url for PHP (
> https://github.com/lnear-dev/ada-url). It works, but it's a bit slower,
> likely due to the implementation of the objects. I was planning to embed
> the zvals directly in the object, similar to PhpToken, but I haven't had
> the chance and don't really need it anymore. Shouldn't be too much work t=
o
> clean it up though
>

I=E2=80=99ve updated the implementation, and with Ada 2.9.0, the performanc=
e is now
closer to `parse_url` for short URLs and even outperforms it for longer
URLs. You can see the benchmarks in the "Run benchmark script" section of
[this GitHub Actions run](
https://github.com/lnear-dev/ada-url/actions/runs/9982725628/job/2758901155=
4
).

cheers,
Lanre

--00000000000004880f061da19831
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr">On Mon, Jul 8, 2024 at 11:24=E2=80=AFAM L=
anre &lt;<a href=3D"mailto:lnearwaju@gmail.com">lnearwaju@gmail.com</a>&gt;=
 wrote:<br></div><div class=3D"gmail_quote"><blockquote class=3D"gmail_quot=
e" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204)=
;padding-left:1ex"><div dir=3D"ltr"><div dir=3D"ltr"><br></div><div class=
=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jun 28, 2024=
 at 3:38=E2=80=AFPM M=C3=A1t=C3=A9 Kocsis &lt;<a href=3D"mailto:kocsismate9=
0@gmail.com" target=3D"_blank">kocsismate90@gmail.com</a>&gt; wrote:<br></d=
iv><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;bord=
er-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr">Hi Ev=
eryone,<div><br></div><div>I&#39;ve been working on a new RFC for a while n=
ow, and time has come to present it to a wider audience.</div><div><br></di=
v><div>Last year, I learnt that PHP doesn&#39;t have built-in support for p=
arsing URLs according to any well established=C2=A0standards (RFC=C2=A01738=
 or the WHATWG URL living standard), since the parse_url() function is opti=
mized for performance instead of correctness.</div><div><br></div><div>In o=
rder to improve compatibility with external tools consuming=C2=A0URLs (like=
 browsers), my new RFC would add a WHATWG compliant URL parser functionalit=
y to the standard library. The API itself is not final by any means, the RF=
C only represents how I imagined it first.</div><div><br></div><div>You can=
 find the RFC at the following link:=C2=A0<a href=3D"https://wiki.php.net/r=
fc/url_parsing_api" target=3D"_blank">https://wiki.php.net/rfc/url_parsing_=
api</a></div><div><br></div><div>Regards,</div><div>M=C3=A1t=C3=A9</div><di=
v><br></div></div></blockquote><div><br></div><div>I was exploring wrapping=
 <code>ada_url</code> for PHP (<a rel=3D"noreferrer" href=3D"https://github=
.com/lnear-dev/ada-url" target=3D"_blank">https://github.com/lnear-dev/ada-=
url</a>). It works, but it&#39;s a bit slower, likely due to the implementa=
tion of the objects. I was planning to embed the zvals directly in the obje=
ct, similar to <code>PhpToken</code>, but I haven&#39;t had the chance and =
don&#39;t really need it anymore. Shouldn&#39;t be too much work to clean i=
t up though=C2=A0<br></div></div></div></blockquote><div><br></div><div>I=
=E2=80=99ve updated the implementation, and with Ada 2.9.0, the performance=
 is now closer to `parse_url` for short URLs and even outperforms it for lo=
nger URLs. You can see the benchmarks in the &quot;Run benchmark script&quo=
t; section of [this GitHub Actions run](<a href=3D"https://github.com/lnear=
-dev/ada-url/actions/runs/9982725628/job/27589011554">https://github.com/ln=
ear-dev/ada-url/actions/runs/9982725628/job/27589011554</a>).</div><div><br=
></div><div>cheers,</div><div>Lanre=C2=A0</div></div></div>

--00000000000004880f061da19831--