Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124504
Precedence: bulk
MIME-Version: 1.0
References: <CABY-Mhz36WtLx_1bWAmK8rUpqAQTEw3H1mziPa5TH4nEgeHYFg@mail.gmail.com>
In-Reply-To: <CABY-Mhz36WtLx_1bWAmK8rUpqAQTEw3H1mziPa5TH4nEgeHYFg@mail.gmail.com>
Date: Fri, 19 Jul 2024 01:37:59 +0200
Message-ID: <CAMkukMwXDSjL9hAhZQgD6VYxrodjOTyvrpPF6fwiQOnudafcpw@mail.gmail.com>
Subject: Re: [PHP-DEV] Optional constructor body
To: Oliver Nybroe <olivernybroe@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000537311061d8e121d"
From: hello@faizanakram.me (Faizan Akram Dar)

--000000000000537311061d8e121d
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 19, 2024 at 1:34=E2=80=AFAM Oliver Nybroe <olivernybroe@gmail.c=
om>
wrote:

> Hello internals.
>
> I am looking into making the constructor body optional in classes,
> essentially allowing you to write
>
> ```
> class User {
>     public function __construct(
>         private string $name,
>     )
> }
> ```
>
> Currently to make this code valid, it would have to be written the
> following way
>
> ```
> class User {
>     public function __construct(
>         public string $name,
>     ) {}
> }
> ```
>
> With the introduction or constructor property promotion in 8.0, we often
> see classes where the constructor has an empty body, and my guess would b=
e
> that this will only increase with the introduction of property access hoo=
ks
> in 8.4 which is allowed to be defined in the constructor also.
>
> This change would only be a cosmetic change and simplify the userland cod=
e
> by removing two redundant characters.
>
>
>
> This would be my first RFC and I am willing to try and implement it
> myself.
>
>
> Best regards
> Oliver Nybroe (he/him)
>


FWIW, there is already a PR for it (
https://github.com/php/php-src/issues/8420) which also contains the RFC
draft.

Kind regards,
Faizan

--000000000000537311061d8e121d
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr"><div dir=3D"ltr"><br></div><br><div class=3D"gmail_quote">=
<div dir=3D"ltr" class=3D"gmail_attr">On Fri, Jul 19, 2024 at 1:34=E2=80=AF=
AM Oliver Nybroe &lt;<a href=3D"mailto:olivernybroe@gmail.com">olivernybroe=
@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D"gmail_quote" style=
=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding=
-left:1ex"><div dir=3D"ltr"><div>Hello internals.=C2=A0<br><br>I am looking=
 into making the constructor body optional in classes, essentially allowing=
 you to write</div><div><br></div><div>```</div><div>class User {<br>=C2=A0=
 =C2=A0 public function __construct(<br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 private=
 string $name,<br>=C2=A0 =C2=A0 )<br>}<br></div><div>```</div><div><br>Curr=
ently to make this code valid, it would have to be written the following wa=
y<br><br>```<br>class User {<br>=C2=A0 =C2=A0 public function __construct(<=
br>=C2=A0 =C2=A0 =C2=A0 =C2=A0 public string $name,<br>=C2=A0 =C2=A0 ) {}<b=
r>}<br>```</div><div><br></div><div>With the introduction or constructor pr=
operty promotion in 8.0, we often see classes where the constructor has an =
empty body, and my guess would be that this will only increase with the int=
roduction of property access hooks in 8.4 which is allowed to be defined in=
 the constructor also.=C2=A0<br><br>This change would only be a cosmetic ch=
ange and simplify the userland code by removing two redundant characters.=
=C2=A0<br><br></div><div><br></div><div><br></div><div>This would be my fir=
st RFC and I am willing to try and implement it myself.=C2=A0</div><div><br=
></div><br clear=3D"all"><div><div dir=3D"ltr" class=3D"gmail_signature"><d=
iv dir=3D"ltr">Best regards<div>Oliver Nybroe (he/him)</div></div></div></d=
iv></div></blockquote><div><br></div><div><br></div><div>FWIW, there is alr=
eady a PR for it (<a href=3D"https://github.com/php/php-src/issues/8420">ht=
tps://github.com/php/php-src/issues/8420</a>) which also contains the RFC d=
raft.<br><br>Kind regards,<br>Faizan</div><div>=C2=A0</div></div></div>

--000000000000537311061d8e121d--