Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:124502
Message-ID: <84999002-cff1-436a-8036-b7b4facb2cba@gmx.de>
Date: Fri, 19 Jul 2024 00:51:56 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PHP-DEV] Request for opinions: bug vs feature - change
 intokenization of yield from
Content-Language: de-DE
To: =?UTF-8?Q?Tim_D=C3=BCsterhus?= <tim@bastelstu.be>,
 =?UTF-8?Q?Marco_Aur=C3=A9lio_Deleu?= <deleugyn@gmail.com>,
 Juliette Reinders Folmer <php-internals_nospam@adviesenzo.nl>
Cc: PHP internals <internals@lists.php.net>
References: <66984FD0.5090805@adviesenzo.nl>
 <C74348B0-A64C-4F4E-9789-440E65E94B15@gmail.com>
 <f6ff45c5-94b9-4ebd-b9ab-c9a9ba42b7e7@bastelstu.be>
In-Reply-To: <f6ff45c5-94b9-4ebd-b9ab-c9a9ba42b7e7@bastelstu.be>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
UI-OutboundReport: notjunk:1;M01:P0:OwwPj0nAiBI=;DIQm/SULzkAlvxpjOq8tHIW5vPn
 FpmS9W1Q+pYLpg1qWURsMVWF/h5kvj3ZXetS3ru6kq8eQVd3Qf+Aff0A5AG7Mkv5koqOBqpNE
 VYkenajMnhppZ4dULDxDNsL76+AdOsZuuR524rZzc73XC7tsojGLF1nDxD0L7F9+ONJUsVHUe
 9474i2j8ig/yHm7mFAjJaqrAUqDk/i6eUkHyRyyRman0CRjtRiQOQPawKtZwQ2NRlPB7nTdrX
 0TO7YD9/Aw06aNuDGciX6VukxD4WuDG3pSs9LqVL2CbQGnidRHUaPnphqjO3U2LTDkbEpyGBY
 srdOKUISqhtgtWc1MoMhlGTBi/WblSDMLxODFyy/C0C9AOqIh090C3aTSVkPESM4j9Zh3IXUn
 mjSy9SplXY9hoHMl1c5tFdh0nKxpm5FSC0dYJTbwOtJ/RBHKRBVKtNcf4HsrrfLHmP2eudBbX
 Aruc+nCq5YP4XRAT20sf+jeIUZHeCJl14XSDJwxn8bFVeNMK169W37KeNE/jVVXC7jHtqmft6
 ls01Nu+aJdVUS1IxL1Tfdieb0REpLffSknaNF6bV6XD3FNMQ5nnA0NIJ19jQUXeB/Fy26bdzL
 90PFgHc9nRNvr5UGPcxaryIv3XWDHdNqtel1MNqKe1uPqZSeWRoZrkXFo4RwYV4yHzq2120Dy
 nG4aHySLGsDtUnWVWy/Je90PvGDMzQvm+2w6xSFVZzY1km6hlRFx/HOTkkzq3bHf4IjkAe7Nl
 +bEoWTOsuEKJBYfM+/VdUJf4kzvIiS9CwRKr15oUzkj2xCH97ZGnDb2eR3bR0WQ35op9E/Ofz
 bdte+fJ3xtTEQQT3em3Uhdow==
From: cmbecker69@gmx.de ("Christoph M. Becker")

Hi Tim!

On 18.07.2024 at 21:05, Tim D=C3=BCsterhus wrote:

> On 7/18/24 19:48, Marco Aur=C3=A9lio Deleu wrote:
>
>> Forcing all tooling that uses token_get_all() to handle this
>> unintentional change seems to generate more unnecessary and real
>> busywork for something only theoretical possible to break.
>
> The tools are required to handle this either way, because there are
> released version with this specific tokenization and they are not going
> away.

Well, these tools could reject such code, and tell users to update to a
version where this is no longer valid syntax.

> Ubuntu 24.04 LTS ships with PHP 8.3.6 and generally Ubuntu backports
> security fixes instead of upgrading to newer patch versions. As an
> example, Ubuntu 22.04 LTS ships with PHP 8.1.2 + security fixes, not
> with 8.1.29 (which is the newest 8.1.x as of now).
>
> Thus the ship has effectively sailed due to the inclusion in Ubuntu
> 24.04 LTS as the arguably most widely used Linux distro.

I have to agree that this is a strong argument, but I don't think we're
absolutely obliged to stick with what have right now.  We still can
claim that we've made an unintended behavioral change, aka. introduced a
bug, and fix it =E2=80=93 downstream projects have to deal with this (the =
same
as we may have to deal with unwelcome upstream fixes).

And frankly, how much code would be affected?  I mean, does anybody
actually put a comment between `yield` and `from`?  Is there a case
where this may make sense?  "Because we can" isn't a strong argument, in
my opinion.

Cheers,
Christoph